Skip to content

Next

  • Projects
  • Groups
  • Snippets
  • Help
    • Loading...
    • Help
    • Support
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
GitLab FOSS
GitLab FOSS
  • Project overview
    • Project overview
    • Details
    • Activity
    • Releases
    • Cycle Analytics
    • Insights
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
    • Charts
    • Locked Files
  • Issues 1
    • Issues 1
    • List
    • Boards
    • Labels
    • Service Desk
    • Milestones
  • Merge Requests 1
    • Merge Requests 1
  • CI / CD
    • CI / CD
    • Pipelines
    • Jobs
    • Schedules
    • Charts
  • Security & Compliance
    • Security & Compliance
    • Dependency List
  • Packages
    • Packages
    • Container Registry
  • Snippets
    • Snippets
  • Members
    • Members
  • Collapse sidebar
  • Activity
  • Graph
  • Charts
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
  • GitLab.org
  • GitLab FOSSGitLab FOSS
  • Merge Requests
  • !14053

Merged
Opened Sep 05, 2017 by Sean McGivern@smcgivern🎄6 of 8 tasks completed6/8 tasks
  • Report abuse
Report abuse

Add setting to resolve outdated diff comments on push

What does this MR do?

Adds a new project setting for MRs that, when set, automatically resolved outdated diff discussions on a push to an MR.

Are there points in the code the reviewer needs to double check?

I think the whole resolve_without_save thing makes sense, but would be good to check!

Screenshots

When the setting is enabled:

image

Expanded:

image

Does this MR meet the acceptance criteria?

  • Changelog entry added, if necessary
  • Documentation created/updated
  • API support added
  • Tests added for this feature/bug
  • Review
    • Has been reviewed by Backend
  • Conform by the merge request performance guides
  • Conform by the style guides
  • Squashed related commits together

What are the relevant issue numbers?

Closes https://gitlab.com/gitlab-org/gitlab-ce/issues/36994.

Edited Sep 06, 2017 by Sean McGivern
  • Discussion 6
  • Commits 8
  • Pipelines 5
  • Changes 29
Assignee
Assign to
10.0
Milestone
10.0
Assign milestone
Time tracking
4
Labels
Community contribution Plan [DEPRECATED] devops::plan merge requests
Assign labels
  • View project labels
Reference: gitlab-org/gitlab-foss!14053

Revert this merge request

This will create a new commit in order to revert the existing changes.

Switch branch
Cancel
A new branch will be created in your fork and a new merge request will be started.

Cherry-pick this merge request

Switch branch
Cancel
A new branch will be created in your fork and a new merge request will be started.