Commit status create (API): Can no longer use links under NAT with 'target_url'
Hi, we're using an external CI system for the NetworkManager CI hosted at the freedesktop.gitlab.com
They have updated recently to current version 12.1.6 of CE gitlab.
We are using API to set commit statuses from our otherwise jenkins based system that show within pipelines as 'external'. We are setting the "target_url" to a particular job link in our system that is under redhat internal network as we have the hardware needed available there.
Since the update we are getting this every time:
{"message":{"target_url":["is blocked: Host cannot be resolved or invalid"]}}
Figured out that the gitlab started to actually check whether the link provided does work. Doesn't necessarily feel like a bug, but surely this is fairly strange, I see no reason why we should be able to use link under NAT for external CI system. Relevant devs that use that gitlab project of course have access to that system. Also - I have not found any mention of such a new feature in the CE changelog...
Direct API example:
curl --request POST --header "PRIVATE-TOKEN: xxxxx" "https://gitlab.freedesktop.org/api/v4/projects/411/statuses/cd664f52529260a365819037cfbd6a3f6cfef468?state=success&name=NetworkManagerCI&target_url=https://desktopqe-jenkins.rhev-ci-vms.eng.rdu2.redhat.com/job/beaker-NetworkManager-gitlab-trigger-code-upstream/571/&description=Successful" {"message":{"target_url":["is blocked: Host cannot be resolved or invalid"]}}%