Inconsistent e-mail subjects in merge request notifications
Summary
E-mail subjects in merge request notifications sometimes contain project's group name and sometimes don't, which causes that the e-mails are not correctly threaded in Gmail (and probably other e-mail clients) - it creates two threads per merge merge request.
It seems that this was broken in Gitlab 12.0.2 in commit https://gitlab.com/gitlab-org/gitlab-ce/commit/480eb370a477c3a230cec1ff43a71066ab5be6f9. The merge request notifications did not contain group name in e-mail subjects in previous Gitlab versions.
Steps to reproduce
- Create a group and a project under the group.
- Enable
Receive notifications about your own activity
in User Settings -> Notifications. - Submit new merge request.
- Add some comment to the merge request.
- Add some commit to the merge request.
What is the current bug behavior?
- The new merge request notification has subject
#{project.name} | #{commit.title} (!#{merge_request.id})
. - The "new comment notification" has subject
Re: #{project.name} | #{project.group.name} | #{commit.title} (!#{merge_request.id})
. - The "new commit notification" has subject
Re: #{project.name} | #{commit.title} (!#{merge_request.id})
.
What is the expected correct behavior?
All merge request related notifications should have group name in the e-mail subject if project belongs to a group.