Wrong param for url in cycle analytics
Summary
For project names with whitespaces inside them, url for cycle analytics events were not build right
Steps to reproduce
- Find a project with cycle analytics events
- Change its name to one with whitespaces (
public-project
topublic project
) - Check Cycle Analytics page for this project
- No events are rendered, there is 500 error in network
Example Project
https://staging.gitlab.com/privgroupgosia/testproject-in-namespace
What is the current bug behavior?
Events endpoint returns 500
as it cannot create url for events (issues or merge request)
What is the expected correct behavior?
Events endpoints return events
Relevant logs and/or screenshots
https://sentry.gitlab.net/gitlab/staginggitlabcom/issues/892184/?query=is:unresolved
Output of checks
This bug happens on Staging
Results of GitLab environment info
Expand for output related to GitLab environment info
(For installations with omnibus-gitlab package run and paste the output of:
sudo gitlab-rake gitlab:env:info
)(For installations from source run and paste the output of:
sudo -u git -H bundle exec rake gitlab:env:info RAILS_ENV=production
)
Results of GitLab application Check
Expand for output related to the GitLab application check
(For installations with omnibus-gitlab package run and paste the output of:
sudo gitlab-rake gitlab:check SANITIZE=true
)(For installations from source run and paste the output of:
sudo -u git -H bundle exec rake gitlab:check RAILS_ENV=production SANITIZE=true
)(we will only investigate if the tests are passing)
Possible fixes
(If you can, link to the line of code that might be responsible for the problem)