TIMEOUT_SECONDS for codeclimate not passed to container
Summary
The container for codeclimate documents it accepts environment variables for TIMEOUT_SECONDS.
Steps to reproduce
- Set a new environment variables for TIMEOUT_SECONDS with a value 30
- Analyse the project with codeclimate
- It should time out after 30 seconds, but this never happens
What is the current bug behavior?
Any value set in the TIMEOUT_SECONDS is not respected, and always the default of 900 seconds is used.
What is the expected correct behavior?
A timeout should occur after the set number of seconds.
Results of GitLab environment info
System information System: Proxy: no Current User: git Using RVM: no Ruby Version: 2.5.3p105 Gem Version: 2.7.6 Bundler Version:1.17.3 Rake Version: 12.3.2 Redis Version: 3.2.12 Git Version: 2.18.1 Sidekiq Version:5.2.5 Go Version: unknown GitLab information Version: 11.10.4-ee Revision: 88a3c791734 Directory: /opt/gitlab/embedded/service/gitlab-rails DB Adapter: PostgreSQL DB Version: 9.6.11 URL: https://git.eurail.com HTTP Clone URL: https://git.eurail.com/some-group/some-project.git SSH Clone URL: ssh://git@git.eurail.com:922/some-group/some-project.git Elasticsearch: no Geo: no Using LDAP: yes Using Omniauth: yes Omniauth Providers: GitLab Shell Version: 9.0.0 Repository storage paths: - default: /var/opt/gitlab/git-data/repositories GitLab Shell path: /opt/gitlab/embedded/service/gitlab-shell Git: /opt/gitlab/embedded/bin/git
Possible fixes
In gitlab-org/security-products/codequality@231cd511 this was accidentally removed. It changed from:
--env CONTAINER_TIMEOUT_SECONDS=$CONTAINER_TIMEOUT_SECONDS
to
--env CONTAINER_TIMEOUT_SECONDS
so any value set as the environment variable is actually never passed to the container.