review app not being stopped when branch deleted
Summary
On gitlab.com, the review apps in our project are not being stopped when the related merge requests are merged and the branch deleted.
I can't figure out a way to debug this; there doesn't seem to be anything in the gitlab ui to tell me why the job is triggered.
Steps to reproduce
- Create new branch, wait for review app to spin up
- Delete branch
(Our gitlab-ci.yml is a little complex/different to the standard autodevops template as we need the review apps to be spun up on predictable hostnames from a set that have been pre-registered with various external systems.)
Example Project
https://gitlab.com/fintechlabs/fapi-conformance-suite/
in particular:
https://gitlab.com/fintechlabs/fapi-conformance-suite/blob/master/.gitlab-ci.yml
I noticed we weren't following the documentation in one place, so I fixed that expecting it would solve the issue:
https://gitlab.com/fintechlabs/fapi-conformance-suite/merge_requests/418
but it didn't help.
What is the current bug behavior?
The stop job does not run.
The job works fine if we manually go to the pipeline page and tell the job to run.
What is the expected correct behavior?
The stop job should run when the branch is deleted as per https://docs.gitlab.com/ee/ci/yaml/#environmenton_stop
Output of checks
This bug happens on GitLab.com