Remove support for `AUTO_DEVOPS_DOMAIN`

KUBE_INGRESS_BASE_DOMAIN was introduced on https://gitlab.com/gitlab-org/gitlab-ce/issues/52363 / https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/24580 deprecating AUTO_DEVOPS_DOMAIN. In the next major milestone (%12.0 ?), we need to remove support for AUTO_DEVOPS_DOMAIN from our codebase.

We need to also remove the ProjectAutoDevops#domain

Follow-up

• https://gitlab.com/gitlab-org/gitlab-ce/issues/62128

Workflow

If users have their own .gitlab-ci.yml, then they are un-affected.

If users use Auto DevOps, then those who have switched to setting the domain in cluster settings will be un-affected. (available since 11.8).

(Also note 11.8 will have migrated the data via a post-deploy migration)

For those who haven't done so, the Auto DevOps pipeline will fail with the following message:

In order to deploy or use Review Apps,
KUBE_INGRESS_BASE_DOMAIN variables must be set
From 11.8, you can set KUBE_INGRESS_BASE_DOMAIN in cluster settings
or by defining a variable at group or project level.
You can also manually add it in .gitlab-ci.yml

added backend + 1 deleted label

mentioned in issue #52363 (closed)

@mayra-cabrera depending on how much delay it would add I think it would be best if you could create an MR that deprecates this env var and just leave it as WIP so that when %12.0 happens we can just merge it rather than having to figure out what the deprecation strategy was meant to be many months after changing this code.

I think this would be much more efficient since trying to remember what we did months ago generally adds overhead.

@DylanGriffith yes that's the strategy we discussed the other day. Thanks for writing it up. I created the issue because I needed to point it on the documentation changes

mentioned in merge request !24741 (closed)

changed the description

changed title from Deprecate AUTO_DEVOPS_DOMAIN in favor of KUBE_INGRESS_BASE_DOMAIN to {+Completely remove AUTO_DEVOPS_DOMAIN support+}

mentioned in merge request !24740 (merged)

mentioned in merge request !24580 (merged)

We also need to remove legacy_auto_devops domain method https://gitlab.com/gitlab-org/gitlab-ce/blob/d9af3752fcfa6e97bcec82515b0cbc1ab88285de/app/models/clusters/cluster.rb#L225

As an FYI, my domain under the '.online' TLD was rejected by something, deleted from the UI and broke all of my auto-deployments.

As an FYI, my domain under the '.online' TLD was rejected by something, deleted from the UI and broke all of my auto-deployments.

@infowolfe you may be looking for https://gitlab.com/gitlab-org/gitlab-ce/issues/57650 . This was a regression and we hope to roll out the fix in the next few days. Sorry for the inconvenience.

@danielgruesso Can we schedule this for %12.0 ?

changed milestone to %12.0

Thanks @tkuah, added.

added Category:Auto DevOps deprecation devopsconfigure [DEPRECATED] labels

changed title from {-Completely remove AUTO_DEVOPS_DOMAIN support-} to {+Remove support for AUTO_DEVOPS_DOMAIN+}

added [deprecated] Accepting merge requests label

added Deliverable label

assigned to @tkuah

Picking this up

mentioned in merge request !28460 (merged)

removed [deprecated] Accepting merge requests label

added breaking change label

added to epic &1333

We also need to consider to remove the ProjectAutoDevops#domain

I think this could be a follow-up issue to remove the form, and the database column.

Oh, the form has been removed in https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/24580/diffs#diff-content-ddda314a2f8d38776ea54e1d2deddaee9d8d99ec

Will remove in https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/28574 as part of this issue

mentioned in merge request !28574 (merged)

changed the description

closed via merge request !28574 (merged)

mentioned in commit 9209736a

mentioned in issue gl-retrospectives/configure#11 (closed)

added depth label

@tkuah @tauriedavis while doing FA for this issue I noticed that all pipelines continue to work successfully. In the even a user was using the variable when upgrading from 11.11 to 12.0, how would they find out the variable is no longer working?

@danielgruesso if KUBE_INGRESS_BASE_DOMAIN, which is the replacement for AUTO_DEVOPS_DOMAIN is defined in any way, then the pipeline will continue to work.

KUBE_INGRESS_BASE_DOMAIN is populated when we set the domain for the cluster - was that the case in your FA ?

See https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/28460#note_173989033 for an example of what happens when KUBE_INGRESS_BASE_DOMAIN is not present.

KUBE_INGRESS_BASE_DOMAIN is populated when we set the domain for the cluster - was that the case in your FA ?

Yes it was, which explains why I didn't see the failure message.

See https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/28460#note_173989033 for an example of what happens when KUBE_INGRESS_BASE_DOMAIN is not present.

Perfect, was missing that. Thank you much for the clarification @tkuah

changed the description

added groupconfigure [DEPRECATED] label

---

added groupenvironments label and removed groupconfigure [DEPRECATED] label