Skip to content

Update icon for Azure OmniAuth provider

Summary

The icon shown for Azure OmniAuth provider is incorrect/non-standard and misleading to our users.

Ideally it should be changed to the image recommended by Microsoft.

Steps to reproduce

Follow the steps at https://docs.gitlab.com/ee/integration/azure.html

The logo that is then shown on the login screen is inconsistent with Azure's Active Directory branding.

Example Project

I don't think this applies?

What is the current bug behavior?

A Microsoft Windows logo is shown on the sign-in screen.

What is the expected correct behavior?

A "Sign in with Microsoft" logo should be shown, as described here:

https://docs.microsoft.com/en-us/azure/active-directory/develop/active-directory-branding-guidelines#visual-guidance-for-sign-in

Relevant logs and/or screenshots

Screenshot of current logo used: Sign_in___GitLab

Output of checks

(If you are reporting a bug on GitLab.com, write: This bug happens on GitLab.com)

I don't think this applies

Results of GitLab environment info

Expand for output related to GitLab environment info
System information
System:
Current User:	git
Using RVM:	no
Ruby Version:	2.3.6p384
Gem Version:	2.6.13
Bundler Version:1.13.7
Rake Version:	12.3.0
Redis Version:	3.2.11
Git Version:	2.14.3
Sidekiq Version:5.0.5
Go Version:	unknown

GitLab information Version: 10.7.3 Revision: 2555d6c Directory: /opt/gitlab/embedded/service/gitlab-rails DB Adapter: postgresql URL: https://gitlab-testing.data.bas.ac.uk HTTP Clone URL: https://gitlab-testing.data.bas.ac.uk/some-group/some-project.git SSH Clone URL: git@gitlab-testing.data.bas.ac.uk:some-group/some-project.git Using LDAP: no Using Omniauth: yes Omniauth Providers: azure_oauth2

GitLab Shell Version: 7.1.2 Repository storage paths:

  • default: /var/opt/gitlab/git-data/repositories Hooks: /opt/gitlab/embedded/service/gitlab-shell/hooks Git: /opt/gitlab/embedded/bin/git

Results of GitLab application Check

Expand for output related to the GitLab application check
Check GitLab API access: OK
Redis available via internal API: OK

Access to /var/opt/gitlab/.ssh/authorized_keys: OK gitlab-shell self-check successful

Checking GitLab Shell ... Finished

Checking Sidekiq ...

Running? ... yes Number of Sidekiq processes ... 1

Checking Sidekiq ... Finished

Reply by email is disabled in config/gitlab.yml Checking LDAP ...

LDAP is disabled in config/gitlab.yml

Checking LDAP ... Finished

Checking GitLab ...

Git configured correctly? ... yes Database config exists? ... yes All migrations up? ... yes Database contains orphaned GroupMembers? ... no GitLab config exists? ... yes GitLab config up to date? ... yes Log directory writable? ... yes Tmp directory writable? ... yes Uploads directory exists? ... yes Uploads directory has correct permissions? ... yes Uploads directory tmp has correct permissions? ... skipped (no tmp uploads folder yet) Init script exists? ... skipped (omnibus-gitlab has no init script) Init script up-to-date? ... skipped (omnibus-gitlab has no init script) Projects have namespace: ... can't check, you have no projects Redis version >= 2.8.0? ... yes Ruby version >= 2.3.5 ? ... yes (2.3.6) Git version >= 2.9.5 ? ... yes (2.14.3) Git user has default SSH configuration? ... yes Active users: ... 2

Checking GitLab ... Finished

Possible fixes

(If you can, link to the line of code that might be responsible for the problem)