GH import fails for projects with empty wiki repo
If a project has a wiki enabled but there is no content, the import will always fail. Given that this is a majority of the cases (as wiki is enabled by default) the impact is huge. There is no way to check if wiki really exists using API. The
git clone always returns 128 status code if something is wrong, either network issue or authentication failure, or repo simply does not exist.
|GH wiki state||GitLab wiki state|
|wiki exists (with content)||wiki is imported|
|wiki exists (with no content)||wiki IS NOT created|
|wiki is disabled||wiki is created|
I can think of two approaches:
- If we fail we create an empty repo, so Geo will work properly at least. The working implementation is here https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/17112
- Always mark the import as successful if we failed to import a wiki. The thing is that GH does not have separate permissions for a wiki so if we failed to import it, the reason is a non-existent wiki or network issue (well some other errors are possible too) but not the lake of permissions, which mitigate the impact of this error suppression a bit.