HipChat Push Notification always says "... 17 more commits", even when many more were pushed
Summary
When pushing a large-ish number of commits at once, the HipChat push notifications always seem to say "... 17 more commits", even when I pushed many more than that.
Pushing 5 commits, however, will list the first three, then "... 2 more commits".
Steps to reproduce
Push > 20 commits at a time with the HipChat push notification enabled.
What is the current bug behavior?
Incorrect count of pushed commits.
What is the expected correct behavior?
The correct remaining number of commits should be displayed, or, if that cannot be done accurately / efficiently, it should say something suitably vague like "... many more commits".
Relevant logs and/or screenshots
Output of checks
Results of GitLab environment info
Expand for output related to GitLab environment info
System information System: Current User: git Using RVM: no Ruby Version: 2.3.5p376 Gem Version: 2.6.13 Bundler Version:1.13.7 Rake Version: 12.3.0 Redis Version: 3.2.11 Git Version: 2.14.3 Sidekiq Version:5.0.4 Go Version: unknownGitLab information Version: 10.3.1 Revision: 63aec1b Directory: /opt/gitlab/embedded/service/gitlab-rails DB Adapter: postgresql URL: https://git.dqecom.com HTTP Clone URL: https://git.dqecom.com/some-group/some-project.git SSH Clone URL: git@git.dqecom.com:some-group/some-project.git Using LDAP: yes Using Omniauth: no
GitLab Shell Version: 5.10.2 Repository storage paths:
- default: /var/opt/gitlab/git-data/repositories Hooks: /opt/gitlab/embedded/service/gitlab-shell/hooks Git: /opt/gitlab/embedded/bin/git
Results of GitLab application Check
Expand for output related to the GitLab application check
Checking GitLab Shell ...GitLab Shell version >= 5.10.2 ? ... OK (5.10.2) Repo base directory exists? default... yes Repo storage directories are symlinks? default... no Repo paths owned by git:root, or git:git? default... yes Repo paths access is drwxrws---? default... yes hooks directories in repos are links: ... 3/1 ... ok 5/2 ... ok 5/3 ... ok 5/4 ... ok 5/5 ... ok 5/6 ... ok 5/7 ... ok 5/8 ... ok 5/9 ... ok 5/10 ... ok 5/11 ... ok 2/13 ... ok 7/14 ... ok 5/15 ... ok 5/16 ... ok 3/17 ... ok 8/18 ... ok 10/19 ... ok 3/20 ... ok 3/21 ... ok 2/22 ... ok 3/23 ... ok 5/24 ... ok 3/25 ... ok 5/26 ... ok 5/27 ... ok 3/28 ... ok 3/29 ... ok 7/30 ... ok 3/31 ... ok 7/32 ... ok 3/33 ... ok 7/51 ... ok 18/52 ... ok 18/53 ... ok 3/54 ... ok 3/55 ... ok 3/56 ... ok 2/57 ... ok 19/58 ... ok 2/59 ... ok 3/60 ... ok 2/61 ... ok 21/62 ... ok 21/63 ... ok 3/64 ... ok 4/65 ... ok 21/66 ... ok 10/67 ... ok 4/68 ... repository is empty 3/69 ... ok 3/70 ... ok 21/71 ... ok 17/72 ... ok 3/73 ... repository is empty 32/74 ... ok 3/76 ... repository is empty 2/77 ... ok 2/78 ... ok 2/79 ... ok 33/80 ... ok 33/81 ... ok 34/82 ... ok 12/83 ... ok 34/84 ... ok 33/85 ... ok 3/86 ... repository is empty 31/87 ... ok 3/88 ... ok 38/89 ... ok 38/90 ... ok 15/91 ... ok 2/92 ... ok 2/93 ... ok 7/94 ... ok 7/95 ... ok 3/96 ... ok 38/97 ... ok 40/98 ... ok 21/99 ... ok 42/100 ... ok 42/101 ... repository is empty 33/102 ... repository is empty 2/103 ... ok Running /opt/gitlab/embedded/service/gitlab-shell/bin/check Check GitLab API access: OK Redis available via internal API: OK
Access to /var/opt/gitlab/.ssh/authorized_keys: OK gitlab-shell self-check successful
Checking GitLab Shell ... Finished
Checking Sidekiq ...
Running? ... yes Number of Sidekiq processes ... 1
Checking Sidekiq ... Finished
Checking Reply by email ...
IMAP server credentials are correct? ... yes Init.d configured correctly? ... skipped MailRoom running? ... skipped
Checking Reply by email ... Finished
Checking LDAP ...
Server: ldapmain LDAP authentication... Success LDAP users with access to your GitLab server (only showing the first 100 results) [REDACTED]
Checking LDAP ... Finished
Checking GitLab ...
Git configured correctly? ... yes Database config exists? ... yes All migrations up? ... yes Database contains orphaned GroupMembers? ... no GitLab config exists? ... yes GitLab config up to date? ... yes Log directory writable? ... yes Tmp directory writable? ... yes Uploads directory exists? ... yes Uploads directory has correct permissions? ... yes Uploads directory tmp has correct permissions? ... yes Init script exists? ... skipped (omnibus-gitlab has no init script) Init script up-to-date? ... skipped (omnibus-gitlab has no init script) Projects have namespace: ... 3/1 ... yes 5/2 ... yes 5/3 ... yes 5/4 ... yes 5/5 ... yes 5/6 ... yes 5/7 ... yes 5/8 ... yes 5/9 ... yes 5/10 ... yes 5/11 ... yes 2/13 ... yes 7/14 ... yes 5/15 ... yes 5/16 ... yes 3/17 ... yes 8/18 ... yes 10/19 ... yes 3/20 ... yes 3/21 ... yes 2/22 ... yes 3/23 ... yes 5/24 ... yes 3/25 ... yes 5/26 ... yes 5/27 ... yes 3/28 ... yes 3/29 ... yes 7/30 ... yes 3/31 ... yes 7/32 ... yes 3/33 ... yes 7/51 ... yes 18/52 ... yes 18/53 ... yes 3/54 ... yes 3/55 ... yes 3/56 ... yes 2/57 ... yes 19/58 ... yes 2/59 ... yes 3/60 ... yes 2/61 ... yes 21/62 ... yes 21/63 ... yes 3/64 ... yes 4/65 ... yes 21/66 ... yes 10/67 ... yes 4/68 ... yes 3/69 ... yes 3/70 ... yes 21/71 ... yes 17/72 ... yes 3/73 ... yes 32/74 ... yes 3/76 ... yes 2/77 ... yes 2/78 ... yes 2/79 ... yes 33/80 ... yes 33/81 ... yes 34/82 ... yes 12/83 ... yes 34/84 ... yes 33/85 ... yes 3/86 ... yes 31/87 ... yes 3/88 ... yes 38/89 ... yes 38/90 ... yes 15/91 ... yes 2/92 ... yes 2/93 ... yes 7/94 ... yes 7/95 ... yes 3/96 ... yes 38/97 ... yes 40/98 ... yes 21/99 ... yes 42/100 ... yes 42/101 ... yes 33/102 ... yes 2/103 ... yes Redis version >= 2.8.0? ... yes Ruby version >= 2.3.5 ? ... yes (2.3.5) Git version >= 2.7.3 ? ... yes (2.14.3) Git user has default SSH configuration? ... yes Active users: ... 16
Checking GitLab ... Finished
Possible fixes
(If you can, link to the line of code that might be responsible for the problem)