Skip to content

Next

  • Projects
  • Groups
  • Snippets
  • Help
    • Loading...
    • Help
    • Support
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
GitLab FOSS
GitLab FOSS
  • Project overview
    • Project overview
    • Details
    • Activity
    • Releases
    • Cycle Analytics
    • Insights
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
    • Charts
    • Locked Files
  • Issues 0
    • Issues 0
    • List
    • Boards
    • Labels
    • Service Desk
    • Milestones
  • Merge Requests 0
    • Merge Requests 0
  • CI / CD
    • CI / CD
    • Pipelines
    • Jobs
    • Schedules
    • Charts
  • Security & Compliance
    • Security & Compliance
    • Dependency List
  • Packages
    • Packages
    • Container Registry
  • Snippets
    • Snippets
  • Members
    • Members
  • Collapse sidebar
  • Activity
  • Graph
  • Charts
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
  • GitLab.org
  • GitLab FOSSGitLab FOSS
  • Issues
  • #36292

Closed
Open
Opened Aug 10, 2017 by James Lopez@jameslopez🌴
  • Report abuse
  • New issue
Report abuse New issue

Improve performance creating MR diffs via GitHub import

As part of generating a diff in the DB for a specific MR, we call ensure_commits_sha that goes and fetches the MR ref:

merge_request.fetch_ref

However, we are already fetching this ref previously as part of the import process. Plus we could have skipped both altogether by fetching all refs at once.

Related issues

  • Discussion
  • Designs
Assignee
Assign to
10.1
Milestone
10.1
Assign milestone
Time tracking
None
Due date
None
4
Labels
Platform [DEPRECATED] backend import performance
Assign labels
  • View project labels
Reference: gitlab-org/gitlab-foss#36292