JiraService does not return error information in result message
Overview
The JIRA project service will never return a value in the error_message
flash message used when "testing settings".
This requires users to review the production.log for JiraService Send message errors.
Fix
We catch the following exceptions
Timeout::Error, Errno::EINVAL, Errno::ECONNRESET, Errno::ECONNREFUSED, URI::InvalidURIError, JIRA::HTTPError
When sending a JIRA request https://gitlab.com/gitlab-org/gitlab-ce/blob/master/app/models/project_services/jira_service.rb#L297-298 - This always returns nil
on an exception. Therefore the value of result
(returned to the controller) is always nil
https://gitlab.com/gitlab-org/gitlab-ce/blob/master/app/models/project_services/jira_service.rb#L174-175
__
Edited by Chris