"Merge automatically when build succeeds" fails silently if pre-receive hooks fail
Summary
Build succeeded 4 days ago but the branch was never merged.
Steps to reproduce
- Fast-forward merges
- Option
Only allow merge requests to be merged if the build succeeds
is on. - Approvals are on
- 'Only allow merge requests to be merged if all discussions are resolved' is off
- Web-hooks triggering Jenkins pipeline
Make the per-receive hooks refuse the merge.
What is the current bug behavior?
Nothing happens.
What is the expected correct behavior?
The commiter is notified that merge failed. The reason for failure is displayed on the MR page.
Relevant logs and/or screenshots
System information
System:
Current User: git
Using RVM: no
Ruby Version: 2.3.3p222
Gem Version: 2.6.6
Bundler Version:1.13.7
Rake Version: 10.5.0
Sidekiq Version:4.2.7
GitLab information
Version: 8.16.4-ee
Revision: 93daa28
Directory: /opt/gitlab/embedded/service/gitlab-rails
DB Adapter: PostgreSQL
DB Version: 9.2.18
URL: https://git.acme-internal.com
HTTP Clone URL: https://git.acme-internal.com/some-group/some-project.git
SSH Clone URL: git@git.acme-internal.com:some-group/some-project.git
Elasticsearch: no
Geo: no
Using LDAP: yes
Using Omniauth: no
GitLab Shell
Version: 4.1.1
Repository storage paths:
- default: /var/opt/gitlab/git-data/repositories
Hooks: /opt/gitlab/embedded/service/gitlab-shell/hooks/
Git: /opt/gitlab/embedded/bin/git