Extend feature tests for commit statuses
Description
We recently had a regression which caused CI statuses on badges to be reported incorrectly.
Fix for that in https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/8286, changed how we calculate commit status and it introduced even worse problem.
The fix completely broken reporting a commit status on master
. This change was then reverted on master
and stable
branches, see https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/8286#note_20461082.
This was not caught by our tests, which means that test coverage for displaying commit status is insufficient.
Proposal
Add additional feature tests for rendering correct commit statuses.