Skip to content

Next

  • Projects
  • Groups
  • Snippets
  • Help
    • Loading...
    • Help
    • Support
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
GitLab FOSS
GitLab FOSS
  • Project overview
    • Project overview
    • Details
    • Activity
    • Releases
    • Cycle Analytics
    • Insights
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
    • Charts
    • Locked Files
  • Issues 2
    • Issues 2
    • List
    • Boards
    • Labels
    • Service Desk
    • Milestones
  • Merge Requests 1
    • Merge Requests 1
  • CI / CD
    • CI / CD
    • Pipelines
    • Jobs
    • Schedules
    • Charts
  • Security & Compliance
    • Security & Compliance
    • Dependency List
  • Packages
    • Packages
    • Container Registry
  • Snippets
    • Snippets
  • Members
    • Members
  • Collapse sidebar
  • Activity
  • Graph
  • Charts
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
  • GitLab.org
  • GitLab FOSSGitLab FOSS
  • Issues
  • #25748

Closed
Open
Opened Dec 16, 2016 by Chris@MrChrisW☯
  • Report abuse
  • New issue
Report abuse New issue

Loading project/group/global milestones times out

Summary

Loading project/group/global milestones times out

Steps to reproduce

  • GitLab CE milestones https://gitlab.com/gitlab-org/gitlab-ce/milestones will time out with 502
    • Fixed in !8146 (merged)
  • GitLab-org group milestones https://gitlab.com/groups/gitlab-org/milestones time out with 502
  • Global milestones on https://gitlab.com/dashboard/milestones also time out with 502

Cause

This is caused by a security fix which checks permission on issues to be included or counted in those pages. Milestonish#issues_visible_to_user has been updated to use IssuesFinder, but this isn't fast enough at the moment.

For project milestone pages this is fixed by !8146 (merged), but for group/global milestones things are more complicated. Since they are just collections of milestones we have to check multiple milestones, and can't easily force the database to filter issues by milestone_id first. The query in Milestonish#issues_visible_to_user needs to be updated to produce more efficient SQL, which might involve changes to IssuesFinder

JSON load works https://gitlab.com/gitlab-org/gitlab-ce/milestones.json

This could be related to https://gitlab.com/gitlab-org/gitlab-ce/issues/24201 (long SQL query)

//cc @stanhu

Related issues

  • Discussion
  • Designs
Assignee
Assign to
8.16
Milestone
8.16
Assign milestone
Time tracking
None
Due date
None
7
Labels
Next Patch Release Plan [DEPRECATED] bug devops::plan milestones performance reproduced on GitLab.com
Assign labels
  • View project labels
Reference: gitlab-org/gitlab-foss#25748