No timeout for HTTParty calls that GitLab makes
A customer reported that they integrate GitLab with TeamCity and their TeamCity server is quite slow. This heavily affects the performance of their GitLab server.
The reason for that is: we synchronously (because Ruby
We don't set any timeout for this request. HTTParty does not have a default timeout, so I believe that the timeout being used is 60 seconds (from
Net::HTTP). By opening multiple browser tabs on MR page it's quite easy to keep all Unicorn processes busy.
In fact, it's also a security threat for GitLab.com.
- (easy) Add more strict default timeout for HTTParty.
- (more advanced) http://martinfowler.com/bliki/CircuitBreaker.html