Support for relative urls
I'm bringing this up as @axil created WIP MR to introduce support into omnibus packages: omnibus-gitlab!401 (closed)
Introducing this into omnibus-gitlab package will require some major changes in the package.
Some of the problems are described in the MR but before this gets continued we need to address the status of relative_url
support in GitLab itself.
At the moment we have a soft recommendation not to use relative_url .
We also have number of issues in GitLab.com issue tracker and github issue tracker related to relative url issues.
I think we need to discuss what is the path we should take:
- Preserve current situation of kinda supporting it with all the problems that exist and reject it from omnibus-package. => This would mean that only with installation from source relative url can be used. If this is the case it should be clearly stated in the README that omnibus-gitlab packages do not support relative urls.
- Support it in full. => This would mean a lot of work fixing all the issues in GitLab and also the work needed to make this work in omnibus-gitlab
- Remove the support for it. => Seems extreme.
- ?????
I personally don't see options other than what I listed above. To me the option 1. seems like the best one where we would explain the status and link to the current issues with it calling users to contribute fixes to improve it.
cc @rspeicher @dzaporozhets @DouweM @jeroenvanbaarsen @axil @jacobvosmaer @JobV @stanhu @sytses @haynes @dblessing