Skip to content

Next

GitLab FOSS
GitLab FOSS
Closed
Opened by Ben Bodenmiller@bbodenmiller
Report abuse New issue

Fix Gmail Actions

In relation to https://github.com/gitlabhq/gitlabhq/blob/master/doc/integration/gitlab_buttons_in_gmail.md & http://feedback.gitlab.com/forums/176466-general/suggestions/6534681-add-view-pull-request-buttons-for-gmail it looks like there may be some problems with the email markup/Gmail actions that may be causing Google's rejection of the schema whitelisting.

GitLab footer:

<div class=3D'footer' style=3D'margin-top: 10px;'>
<p>
=E2=80=94
<br>
<a href=3D"https://gitlab.com/gitlab-org/gitlab-development-kit/merge_req=
uests/54#note_1111544">View it on GitLab</a>
<script type=3D"application/ld+json">{"@context":"http://schema.org","@ty=
pe":"EmailMessage","action":{"@type":"ViewAction","name":"View Merge requ=
est","url":"https://gitlab.com/gitlab-org/gitlab-development-kit/merge_re=
quests/54#note_1111544"}}</script>
You're receiving this notification because you are a member of the GitLab=
.org / GitLab Development Kit project team.
</p>
</div>

GitHub footer:

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">&mdash;<br>Reply to this email directly or <a href="https://github.com/OneBusAway/onebusaway-iphone/pull/418#issuecomment-96448442">view it on GitHub</a>.<img alt="" height="1" src="https://github.com/notifications/beacon/ABIzTFhXRPJLm54dMx-vyWsOQ56dS9oZks5oDW6agaJpZM4EIoiH.gif" width="1" /></p>
<div itemscope itemtype="http://schema.org/EmailMessage">
  <div itemprop="action" itemscope itemtype="http://schema.org/ViewAction">
    <link itemprop="url" href="https://github.com/OneBusAway/onebusaway-iphone/pull/418#issuecomment-96448442"></link>
    <meta itemprop="name" content="View Pull Request"></meta>
  </div>
  <meta itemprop="description" content="View this Pull Request on GitHub"></meta>
</div>

Per https://developers.google.com/gmail/markup/reference/go-to-action Json-Ld and Microdata formats are both acceptable but I'm wondering if Google has a problem with the "3D"s showing up before the single and double quote marks as well as the line truncation method.

If you take the exact text from above and paste it at https://www.google.com/webmasters/markup-tester/u/0/ GitHub's passes but GitLab's does not.

Since Gmail is displaying the emails properly theoretically Gmail is processing them correctly but I'm just guessing as to potential problems. Has anyone been able to attempt to send schemas to themselves from GitLab and seen if it works (see https://developers.google.com/gmail/markup/registering-with-google)... I'm having issues getting my dev environment to send emails so have been unable to test.

Linked issues