Code review functionality is crippled
One of the key selling points to our leadership was the code review functionality within GitLab. Unfortunately this great functionality is being crippled and held back by the fact that all changes are shown at once on a merge request. While we are working to get our engineers to shift into a pre-release code review process, it's a slow transition since it's a big shift in mind-set.
Let's take GitLab to the next level and allow users to review one file at a time in a merge request or commit review. This will decrease the load on the server (we have had to bump our server up to 12GB of RAM, increase the unicorn worker memory limit, and increase the reverse proxy timeout) and quite honestly make code review more intuitive - the current review process doesn't really scale to large projects with small teams (eg. silo'd developers with a peer review).
Ideal Acceptance Criteria
- Code review of changes initially displays a list of the files changed. Two ideas for UX design might be
- A straight list view of the files that may be "opened" in an accordion like manner to load the diff for that file.
- Navigation similar to the file browser.
- Differences are processed on a per-file basis on the server side (unless otherwise requested).