Merging a commit that closes an issue - that has been reopened - into a fork of the repository causes the issue to be closed again.
If you make a commit which closes an issue, reopen the issue, and then in a fork of that repository merge the commit into said fork, it will close the issue again.
We saw this happen here when I pulled in changes from upstream to my fork of the
www-gitlab-com repo, which included a commit by Heather that had previously closed the issue.
Steps to reproduce
Repo1with 1 commit, we'll call it
Issue1by committing to
Repo1with a commit message that says
Fixes Issue #1, we'll call this
Issue1from the Issue view.
- Pull the changes from
Repo1into your fork of
- Note that
Issue1(which was re-opened) in
Repo1has been closed by merging
Note that you may need to perform some of these steps with a second account. I'm not sure if that matters for this bug, but I can update the reproduction steps if that'd be preferable.
I expected that the issue would not close because I brought
Repo2 up-to-date with
- the commit was already in the upstream repository and GitLab should be smart enough to notice that.
- I didn't have the permissions to change the status of the upstream issues, so I shouldn't have been able to close the issue.
Relevant logs and/or screenshots
It started here.
I don't even know where to start :D