GitLab FOSS issueshttps://gitlab.com/gitlab-org/gitlab-foss/-/issues2019-09-10T17:23:13Zhttps://gitlab.com/gitlab-org/gitlab-foss/-/issues/30126Native group milestones2019-09-10T17:23:13ZVictor Wuvictor@gitlab.comNative group milestones## Resources
BE @felipe_artur | FE @selfup | UX @cperessini | PM @victorwu
## Problem
* Currently we have no "native" notion of group milestones. Instead, when we create a group milestone, we are really creating multiple project milest...## Resources
BE @felipe_artur | FE @selfup | UX @cperessini | PM @victorwu
## Problem
* Currently we have no "native" notion of group milestones. Instead, when we create a group milestone, we are really creating multiple project milestones.
* This causes a lot of difficulty with groups. Especially as we expand on groups/subgroups functionality and group boards, we will want a coherent notion of group milestones to aggregate issues together in some time period.
## Design
We'll be adding the new concept of milestones scoped to a group, i.e. group milestones.
Group milestones will have the following attributes *only*:
- Title, Description, Start date, Due date
Possible states of a group milestone:
- Open, Closed
- (Note that you _cannot_ delete a group milestone.)
**Important note**: A group milestone cannot share a title with a milestone in one of its projects. If the user tries give a group milestone a title that's already being used in one of its projects, an error banner should show up: `Milestone title is already in use at the project level`
### Milestones list view at the dashboard level
- This page currently shows all project milestones across all groups in the instance (that you have access to). There will be no functional changes here. For example, `https://gitlab.com/dashboard/milestones`.
- Note that group milestones _are not_ shown on this page.
- The view is similar to the group milestones page (below).
![Screen_Shot_2017-06-26_at_13.27.43](/uploads/f88a913069c9b6e987aad144877fad0b/Screen_Shot_2017-06-26_at_13.27.43.png)
### Milestones list view at the project level
- For example, `https://gitlab.com/gitlab-org/gitlab-ce/milestones`.
- No change on this page.
### Milestones list view in a group
- This page _now_ combines group milestones (new) and project milestones (existing) from all projects in the group.
- For example, `https://gitlab.com/groups/gitlab-org/milestones`.
- The one line of text at the top saying `Only milestones from GitLab.org group are listed here.` should be removed.
- We show all milestones in the same list. This is the simplest approach for a first iteration and we can look into separating them into tabs in the future.
- Next to the name of each milestone we show if it's a group or project milestone. _This is new._
- Project milestones
- The information displayed below (milestone name, start and end dates, number/links to issues/merge requests, links to milestones of respective project milestone pages) is not changed.
- Group milestones
- The information displayed below should only be start date and due date.
- Progress bar
- Show the progress bar for project milestones (existing) and group milestones (new).
- Show the edit button if you have the right permissions. (For both project and group milestones.)
- Show the close button if you have the right permissions. (For both project and group milestones.)
- Remove the `Delete` button in this view (for both project and group milestones), as we want to move away from objects being delete-able.
- Show the `New milestone` button at the top right corner if you have the right permissions. This button takes you to the page for creating a new group milestone.
- The `New milestone` button currently takes you to a form where you can create multiple project milestones at once. This view should not be accessible any more.
- No particular requirement of ordering the items in this list view for this iteration. (Whatever is existing/most straightforward works.)
![group__milestones-no-access](/uploads/21bc4fa4617d4bdb8c3a9621fdd93124/group__milestones-no-access.png)
![group__milestones--access](/uploads/b24785d1e6151f484c4d140fd7898e37/group__milestones--access.png)
### Creating a group milestone
This page will be a simple form where you can enter the milestone's basic attributes. This form is identical to the project milestone form.
![Screenshot_2017-06-09_13.20.35](/uploads/e9ed04da59dd12a9d683364d113473bb/Screenshot_2017-06-09_13.20.35.png)
### Editing a group milestone
Just like creating a milestone, the project milestone form can be reused here
![Screenshot_2017-06-09_13.20.23](/uploads/6ca7964347a3f369888dff2f810e83f5/Screenshot_2017-06-09_13.20.23.png)
### Project milestone view
- Example: `https://gitlab.com/groups/gitlab-org/milestones/91?title=9.1`.
- No change in this view.
### Group milestone view
- The group milestone page will show its basic attributes as shown in the mockup. Other features (how many issues belong to it, burndown chart, etc.) are out of scope.
For group milestones we won't be able to show the list of issues and merge requests inside the milestone page in the first iteration. For that reason, we show links to the full lists in the content section.
For example, the `issues` link in the group milestone `9.2` in the group `GitLab.org` would take you to:
`https://gitlab.com/groups/gitlab-org/issues?scope=all&state=opened&milestone_title=9.2`
![group__milestone](/uploads/4791975bb85ee0f1766318e769144222/group__milestone.png)
### Associating an issue or merge request with a milestone
- A given issue/MR can only be associated with one milestone. An issue/MR can be associated either with a project milestone or a group milestone.
- An issue/MR can only be associated with a group milestone if the group is the direct parent of the issue/MR's project (other layers of subgroups are out of scope)
- When assigning a milestone an issue/MR, we show group and project milestones in the same dropdown, there is no difference between them.
- Slash commands and other ways to associate/disassociate an issue/MR with a group milestone are out of scope.
- System notes are out of scope.
### Filtering issues and merge requests by group milestones
It'll be possible to filter issues and Merge Requests by group milestone in addition to by project milestone. This will be possible in the project pages:
* `https://gitlab.com/group/project/issues`
* `https://gitlab.com/group/project/merge_requests`
Filtering in other areas of GitLab such as the group page and the board are out of scope.
No changes to any UI. Project milestones and group milestones are indistinguishable in the UI here (similar to group labels and project labels).
### Moving issues from one project to another project
- Consider that your issue is in Project `P`. Your issue is associated with the `P` project milestone called `BetaRelease`. Now you are moving the issue to Project `Q`. `P` and `Q` may or may not be in the same group.
- Look for a project milestone in `Q` called `BetaRelease`. If it exists, then the new issue in `Q` should have that project milestone.
- If `Q` does not have any project milestone called `BetaRelease`, then the new issue should not have any milestone associated with it.
- Consider that your issue is in Project `P`. `P` belongs to Group `G`. `G` has a group milestone called `AlphaRelease`. Your issue is associated with that `AlphaRelease` group milestone. There is another Project `Q` which belongs to Group `G`. There is another Project `R` which belongs to another Group `H`.
- Suppose you are moving your issue from `P` to `Q`. The new issue retains the same group milestone.
- Suppose you are moving your issue from `P` to `R`.
- Look for a group milestone in `H` called `AlphaRelease`. If it exists, then the new issue in `R` should have that group milestone.
- If `H` does not have group milestone called `AlphaRelease`, then the new issue should not have any milestone associated with it.9.4Felipe ArturVictor Wuvictor@gitlab.comFelipe Arturhttps://gitlab.com/gitlab-org/gitlab-foss/-/issues/30725UNCHECKING of External User is not setting project limit of User to Admin Def...2019-09-10T17:12:53ZArihantUNCHECKING of External User is not setting project limit of User to Admin Default Value1. Our default Admin settings for Project limit is 10.
2. When I mark a USER as external user, then user's personal project limit is automatically set to "0" Zero.
3. But when we unmark the user as external user, then user's personal p...1. Our default Admin settings for Project limit is 10.
2. When I mark a USER as external user, then user's personal project limit is automatically set to "0" Zero.
3. But when we unmark the user as external user, then user's personal project limit is not changing to default Admin settings for Project limit "10". but it remains "0" Zero only.
Expected behavior ==> As soon as USER is UNMARKED as external user, then user's personal settings for project limit should reflect default Admin settings for Project limit.(10)
Reported for `8.14.6.` Reproduced in `9.0.3`
Ticket: https://gitlab.zendesk.com/agent/tickets/72191
This looks like more of an UI issue. Thoughts?
cc// @stanhu @jschatz19.4https://gitlab.com/gitlab-org/gitlab-foss/-/issues/30196Investigate bypassing the login procedure for most feature specs2019-09-10T17:07:00ZRobert SpeicherInvestigate bypassing the login procedure for most feature specsMost feature specs depend on a user being authenticated, and most of them handle it by calling our helper method `login_as`, which calls `login_with`, which actually loads the sign in page, fills in the form, and clicks submit. Because w...Most feature specs depend on a user being authenticated, and most of them handle it by calling our helper method `login_as`, which calls `login_with`, which actually loads the sign in page, fills in the form, and clicks submit. Because we redirect to the dashboard after a successful sign-in, that's two full request cycles every time a test needs an authenticated user. We probably do that hundreds of times across the suite. The cost gets even higher when that test is using the JavaScript driver.
This is testing too much. We've [got an entire feature test dedicated to testing logins](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/spec/features/login_spec.rb); we should consider this area well-tested and allow ourselves to bypass this full login procedure everywhere else.
Basically I want to replace almost every `login_as` call with something like `set_current_user` which just authenticates the user at the lowest-possible level, probably through Warden.
cc @rymai9.4Robert SpeicherRobert Speicherhttps://gitlab.com/gitlab-org/gitlab-foss/-/issues/29203Make CI artifacts to be stored on object storage2019-09-10T16:43:47ZKamil TrzcińskiMake CI artifacts to be stored on object storageFollowing the discussion from here: https://gitlab.com/gitlab-org/gitlab-ce/issues/26897 it seems that artifacts do grow significantly and it is also harder and harder. We should use CarrierWave and feed that with possibility to point to...Following the discussion from here: https://gitlab.com/gitlab-org/gitlab-ce/issues/26897 it seems that artifacts do grow significantly and it is also harder and harder. We should use CarrierWave and feed that with possibility to point to external storage (S3/AWS).
## Documentation blurb
As companies continue to embrace CI/CD across the organization, their artifact storage needs naturally increase as well. With GitLab 9.3 we are proud to announce that [CI artifacts](https://docs.gitlab.com/ce/user/project/pipelines/job_artifacts.html) can now be saved to [object storage](https://en.wikipedia.org/wiki/Object_storage), like Amazon S3 or Google Cloud Storage. Leveraging these cloud services enables artifacts to be saved cost effectively, reliably, and with nearly infinite scalability.9.4Kamil TrzcińskiKamil Trzcińskihttps://gitlab.com/gitlab-org/gitlab-foss/-/issues/33550system group renamed to system02019-09-10T15:58:27ZUmputunsystem group renamed to system0### Summary
Version 9.2.5 migrated my `system` group path to `system0`. This is **really bad idea** as it breaks everything related to cloned path. It is not just .git/config change but also everything relying on git paths. For exampl...### Summary
Version 9.2.5 migrated my `system` group path to `system0`. This is **really bad idea** as it breaks everything related to cloned path. It is not just .git/config change but also everything relying on git paths. For example, such projects in Go won't be valid anymore and each project in `system` group has to be modified to became "go gettable" again. I don't know what was the reason to make "Path system is a reserved name" but this is really huge issue for anyone used "system" group prior to 9.2.5
### Steps to reproduce
install anything prior to 9.2.5, add "system" group, upgrade to 9.2.5 and see it renamed to "system0"
### What is the current *bug* behavior?
`system` group renamed (migrated) to `system0` automatically
### What is the expected *correct* behavior?
it should not touch any of my groups and rename it
/label ~bug 9.4Bob Van Landuytbob@gitlab.comBob Van Landuytbob@gitlab.comhttps://gitlab.com/gitlab-org/gitlab-foss/-/issues/34932Spanish translation for Pipeline Schedules List Page2019-08-30T14:47:38ZFabio BusattoSpanish translation for Pipeline Schedules List Page**Internationalise Pipeline Schedules List Page** (#33947)
As part of our on-going effort to internationalise GitLab (#4012)
- **Spanish**
- [X] Header message
- [X] `All` - `Active` - `Inactive` tabs
- [X] `New schedule` button
...**Internationalise Pipeline Schedules List Page** (#33947)
As part of our on-going effort to internationalise GitLab (#4012)
- **Spanish**
- [X] Header message
- [X] `All` - `Active` - `Inactive` tabs
- [X] `New schedule` button
- [X] Table header
- [X] Table content
- [X] `Edit` - `Delete` button tooltips
- [X] `Delete` confirmation popup message9.4https://gitlab.com/gitlab-org/gitlab-foss/-/issues/32793Internationalise Commits Page2019-08-30T14:47:37ZMike Bartlettmike.bartlett@gmail.comInternationalise Commits Page### Resources
FE @iamphill
As part of our on-going effort to internationalise GitLab in https://gitlab.com/gitlab-org/gitlab-ce/issues/4012
## List of areas to translate
- [ ] Switch branch widget
- [ ] Filter input placehold...### Resources
FE @iamphill
As part of our on-going effort to internationalise GitLab in https://gitlab.com/gitlab-org/gitlab-ce/issues/4012
## List of areas to translate
- [ ] Switch branch widget
- [ ] Filter input placeholder text
- [ ] RSS tooltip
- [ ] Date separater in commit list
- [ ] Copy SHA tooltip
- [ ] `Browse Files` button9.4Phil HughesPhil Hugheshttps://gitlab.com/gitlab-org/gitlab-foss/-/issues/34502Gitlab::Git::Hook should set the GL_REPOSITORY environment variable2019-08-16T15:15:08ZJacob Vosmaerjacob@gitlab.comGitlab::Git::Hook should set the GL_REPOSITORY environment variablehttps://sentry.gitlap.com/gitlab/devgitlaborg/issues/34971/events/2130800/
When introducing the GL_REPOSITORY variable we overlooked the Gitlab::Git::Hook class.
This has been causing PostReceive jobs to fail on dev.gitlab.org since ht...https://sentry.gitlap.com/gitlab/devgitlaborg/issues/34971/events/2130800/
When introducing the GL_REPOSITORY variable we overlooked the Gitlab::Git::Hook class.
This has been causing PostReceive jobs to fail on dev.gitlab.org since https://gitlab.com/gitlab-org/gitlab-shell/merge_requests/136 was merged.
The GL_REPOSITORY variable should be among those [set on the hook process](https://gitlab.com/gitlab-org/gitlab-ce/blob/ff048ba8a353f25341694db89c8ef5680fa574e8/lib/gitlab/git/hook.rb#L38-42).9.4Alejandro Rodríguezalejandro@gitlab.comAlejandro Rodríguezalejandro@gitlab.comhttps://gitlab.com/gitlab-org/gitlab-foss/-/issues/26404Developers should be able to create new projects in group2019-08-08T15:43:25ZMark PundsackDevelopers should be able to create new projects in group### Description
AFAIK, Developers (the role) can't create new projects in a group and need to ask an admin to create the project for them. This is silly. Developers should be able to create projects and be owners of the project by def...### Description
AFAIK, Developers (the role) can't create new projects in a group and need to ask an admin to create the project for them. This is silly. Developers should be able to create projects and be owners of the project by default so that they can delete the project if they made a mistake, for exmaple. An admin can always take away ownership permissions later if needed. An EE option could make this group-configurable.
### Proposal
### Links / references9.4https://gitlab.com/gitlab-org/gitlab-foss/-/issues/27645Brackets added for incoming email comments using Exchange 20132019-08-07T08:42:29ZChrisBrackets added for incoming email comments using Exchange 2013### Summary
Incoming emails sent from Outlook over Exchange 2013 appear to have brackets added to the issue comment.
### Steps to reproduce
1. Reply to an email from GitLab using Outlook
### Expected behavior
New comment d...### Summary
Incoming emails sent from Outlook over Exchange 2013 appear to have brackets added to the issue comment.
### Steps to reproduce
1. Reply to an email from GitLab using Outlook
### Expected behavior
New comment does not contain brackets.
### Actual behavior
New comment contains two `[` brackets.
### Relevant logs and/or screenshots
**Screenshots - GitLab Only**
+ https://drive.google.com/file/d/0B_4wYK1qcPT1X3BTTWJOM2JlZHc/view
+ https://drive.google.com/file/d/0B_4wYK1qcPT1cVRHTGg0QVpXeDA/view
**Raw Email - GitLab Only**
+ https://drive.google.com/a/gitlab.com/file/d/0B_4wYK1qcPT1TFBmYlFmN0Y5M0E/view?usp=sharing
+ https://drive.google.com/a/gitlab.com/file/d/0B_4wYK1qcPT1MTJwLVV6c2RVZ2c/view?usp=sharing
### Output of checks
+ GitLab 8.16.3
+ https://gitlab.zendesk.com/agent/tickets/58233
+ https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/73979.4https://gitlab.com/gitlab-org/gitlab-foss/-/issues/31435Issue title on tooltip is cut off2019-08-07T08:39:02ZFilipa LacerdaIssue title on tooltip is cut off### Resources
FE @fatihacet
After creating an issue from an unresolved discussion, the issue title on the tooltip link is cut off:
![Screen_Shot_2017-04-26_at_09.12.33](/uploads/9d16126b9a1ec3601fee519b8361b2f2/Screen_Shot_2017-0...### Resources
FE @fatihacet
After creating an issue from an unresolved discussion, the issue title on the tooltip link is cut off:
![Screen_Shot_2017-04-26_at_09.12.33](/uploads/9d16126b9a1ec3601fee519b8361b2f2/Screen_Shot_2017-04-26_at_09.12.33.png)9.4Fatih AcetFatih Acethttps://gitlab.com/gitlab-org/gitlab-foss/-/issues/31763Tweak styling of milestone page2019-08-07T08:38:42ZVictor Wuvictor@gitlab.comTweak styling of milestone page### Resources
FE @selfup
### Current
![螢幕快照_2017-05-03_17.27.21](/uploads/95934e95aa6421ff2e8a99827b44775a/螢幕快照_2017-05-03_17.27.21.png)
### Proposed
- Also change the tooltip of the burndown chart to say:
- `177 open issu...### Resources
FE @selfup
### Current
![螢幕快照_2017-05-03_17.27.21](/uploads/95934e95aa6421ff2e8a99827b44775a/螢幕快照_2017-05-03_17.27.21.png)
### Proposed
- Also change the tooltip of the burndown chart to say:
- `177 open issues on Apr 17, 2017`
- `20 open issue weight on Apr 17, 2017`
![螢幕快照_2017-05-03_17.25.35](/uploads/856b09df5a4dafda208be98c0efb61b2/螢幕快照_2017-05-03_17.25.35.png)9.4https://gitlab.com/gitlab-org/gitlab-foss/-/issues/31952Completely stop using /api/v3/internal2019-08-07T08:38:26ZSean McGivernCompletely stop using /api/v3/internalI noticed that we still have calls to this from gitlab-shell: https://gitlab.com/gitlab-org/gitlab-shell/blob/master/lib/gitlab_net.rb#L138 Looking at https://log.gitlap.com/ backs this up. We should fix gitlab-shell to only use the v4 A...I noticed that we still have calls to this from gitlab-shell: https://gitlab.com/gitlab-org/gitlab-shell/blob/master/lib/gitlab_net.rb#L138 Looking at https://log.gitlap.com/ backs this up. We should fix gitlab-shell to only use the v4 API in plenty of time before v3 goes away.9.4https://gitlab.com/gitlab-org/gitlab-foss/-/issues/32042Trello Power-Up to attach merge request2019-08-07T08:38:23ZVictor Wuvictor@gitlab.comTrello Power-Up to attach merge request### Resources
FE @ClemMakesApps
- Create a Trello Power-Up (https://trello.com/power-ups) to integrate with GitLab.
- Connect to GitLab from within a Trello board. Point to a GitLab project.
- From within a Trello card, attach a ...### Resources
FE @ClemMakesApps
- Create a Trello Power-Up (https://trello.com/power-ups) to integrate with GitLab.
- Connect to GitLab from within a Trello board. Point to a GitLab project.
- From within a Trello card, attach a merge request.
- Trello Developer docs: https://developers.trello.com
Similar to the Trello-Bitbucket integration
<img src="/uploads/ab1dc6f5fd5e1754ecbc890ed45bbcf2/2017-05-09_13.46.23.gif" height="300px" />
### Why we want to do this
- Trello is telling us that there is a lot of requests for a GitLab Power-Up. Many people are asking for this integration.
- A lot of Trello users want to use GitLab to do merge requests. Let's build out the smallest piece and use that as a mechanism to garner further feedback.9.4Clement HoClement Hohttps://gitlab.com/gitlab-org/gitlab-foss/-/issues/32455Gray line separating issuable notes has inconsistent length2019-08-07T08:37:54ZMike GreilingGray line separating issuable notes has inconsistent lengthIssuable comments have separating lines below them which extend all the way to the left, but other notes have lines that stop at the left margin. I believe making them all stop at the margin would look much better.
![Screen_Shot_2017...Issuable comments have separating lines below them which extend all the way to the left, but other notes have lines that stop at the left margin. I believe making them all stop at the margin would look much better.
![Screen_Shot_2017-05-17_at_4.02.39_PM](/uploads/c6bc905716bdfbf5c0ba38f1d21401f5/Screen_Shot_2017-05-17_at_4.02.39_PM.png)
Tagging ~UX just to get a final opinion before diving in to make any changes.9.4https://gitlab.com/gitlab-org/gitlab-foss/-/issues/32971Avoid periods in merge request widget2019-08-07T08:37:13ZMark PundsackAvoid periods in merge request widget### Resources
FE: @psimyn
In ![](https://gitlab.com/gitlab-org/gitlab-ce/uploads/f2c0ab3f7f3eaf2e7b888a57e7d525fd/image.png) we see many lines of text. Three of them are terminated with a period, the rest are not. How do we decide ...### Resources
FE: @psimyn
In ![](https://gitlab.com/gitlab-org/gitlab-ce/uploads/f2c0ab3f7f3eaf2e7b888a57e7d525fd/image.png) we see many lines of text. Three of them are terminated with a period, the rest are not. How do we decide what is a sentence or not? It feels like we should be more consistent one way or the other.
Interestingly, the ones with periods all end in links. It's almost like someone misinterpreted the UX guide on avoiding periods (https://docs.gitlab.com/ce/development/ux_guide/copy.html#avoid-periods) and put periods on lines that end in a link rather than lines that are *followed by* a link.
In the screenshot above, it seems like zero of the lines should have periods at the end.
### Design
- [ ] remove periods as per UX Guidelines
/cc @dimitrieh @victorwu9.4Simon KnoxSimon Knoxhttps://gitlab.com/gitlab-org/gitlab-foss/-/issues/33205API returns 500 when sending "remove_source_branch: false" for MR creation an...2019-08-07T08:36:57ZOswaldo FerreiraAPI returns 500 when sending "remove_source_branch: false" for MR creation and updateIt's a minor bug that currently doesn't block users from creating MR's through the API with 'remove source branch' disabled by default (after https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/11558 got merged). That's because sendin...It's a minor bug that currently doesn't block users from creating MR's through the API with 'remove source branch' disabled by default (after https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/11558 got merged). That's because sending `remove_source_branch: false` is not necessary, since today we don't remove the source branch by default.
But, if an user tries to send `remove_source_branch: false`, for whatever reason, this person would see a `500`, that's due to this particular line:
https://gitlab.com/gitlab-org/gitlab-ce/blob/ead94db602f6f2e4d3b790bd4c7e645494d72318/lib/api/merge_requests.rb#L100
`remove_source_branch` is removed from params _only_ if it has a truthy value, which is not the case. So internally we try to create/update the MR with this get a `500`.
Report from https://gitlab.com/gitlab-org/gitlab-ce/issues/32823:
```
ActiveRecord::UnknownAttributeError (unknown attribute 'remove_source_branch' for MergeRequest.):
/opt/gitlab/embedded/lib/ruby/gems/2.3.0/gems/activerecord-4.2.8/lib/active_record/attribute_assignment.rb:59:in `rescue in _assign_attribute'
/opt/gitlab/embedded/lib/ruby/gems/2.3.0/gems/activerecord-4.2.8/lib/active_record/attribute_assignment.rb:54:in `_assign_attribute'
/opt/gitlab/embedded/lib/ruby/gems/2.3.0/gems/activerecord-4.2.8/lib/active_record/attribute_assignment.rb:41:in `block in assign_attributes'
/opt/gitlab/embedded/lib/ruby/gems/2.3.0/gems/activerecord-4.2.8/lib/active_record/attribute_assignment.rb:35:in `each'
/opt/gitlab/embedded/lib/ruby/gems/2.3.0/gems/activerecord-4.2.8/lib/active_record/attribute_assignment.rb:35:in `assign_attributes'
/opt/gitlab/embedded/lib/ruby/gems/2.3.0/gems/attr_encrypted-3.0.3/lib/attr_encrypted/adapters/active_record.rb:28:in `perform_attribute_assignment'
/opt/gitlab/embedded/lib/ruby/gems/2.3.0/gems/attr_encrypted-3.0.3/lib/attr_encrypted/adapters/active_record.rb:36:in `assign_attributes'
/opt/gitlab/embedded/service/gitlab-rails/app/services/issuable_base_service.rb:173:in `create'
/opt/gitlab/embedded/service/gitlab-rails/app/services/merge_requests/create_service.rb:16:in `execute'
```
Changing this line to the following might be enough to solve the issue:
```
mr_params[:force_remove_source_branch] = mr_params.delete(:remove_source_branch)
````
Note that sending `remove_source_branch: false` to the API seems to never have worked before.9.4Felipe ArturFelipe Arturhttps://gitlab.com/gitlab-org/gitlab-foss/-/issues/33381Merge request widget issue reference should have (closed)2019-08-07T08:36:46ZJohn Vandenbergjayvdb@gmail.comMerge request widget issue reference should have (closed)### Resources
FE @jschatz1
- In the screenshot below, the `Closes issue #26481` near the bottom should have `(closed)` next to it, similar to what it is above higher in the screenshot.
- ~~Also, it should simply say `Closes #2648...### Resources
FE @jschatz1
- In the screenshot below, the `Closes issue #26481` near the bottom should have `(closed)` next to it, similar to what it is above higher in the screenshot.
- ~~Also, it should simply say `Closes #26481 (closed)`.~~ <- This will be changed in https://gitlab.com/gitlab-org/gitlab-ce/issues/32641.
![Screen_Shot_2017-06-07_at_09.14.02](/uploads/62cdc0d0f43c27a4b42f5e82215401f5/Screen_Shot_2017-06-07_at_09.14.02.png)
### Original issue
- Original title
Warning if MR auto closes an issue that is already closed
- Original description
If an issue has been closed, any MR which attempts to 'auto close' the issue should show a warning or be blocked, as the commit message needs to be updated, and possibly the MR needs to be re-evaluated9.4https://gitlab.com/gitlab-org/gitlab-foss/-/issues/33473Group label promotion permissions2019-08-07T08:36:41ZVictor Wuvictor@gitlab.comGroup label promotion permissionsFollow up to https://gitlab.com/gitlab-org/gitlab-ce/issues/33154:
These roles can promote labels: Reporter, Developer, Master, Owner
These roles _cannot_: GuestFollow up to https://gitlab.com/gitlab-org/gitlab-ce/issues/33154:
These roles can promote labels: Reporter, Developer, Master, Owner
These roles _cannot_: Guest9.4https://gitlab.com/gitlab-org/gitlab-foss/-/issues/33533UX improvements for Related Issues feature2019-08-07T08:36:36ZDimitrie HoekstraUX improvements for Related Issues featurecomes from: https://gitlab.com/gitlab-org/gitlab-ee/merge_requests/2050#note_31919518
### Proposal
- Transition between no related issues box to related issues title box.
- that its visible by default, instead of loading in?
- Transi...comes from: https://gitlab.com/gitlab-org/gitlab-ee/merge_requests/2050#note_31919518
### Proposal
- Transition between no related issues box to related issues title box.
- that its visible by default, instead of loading in?
- Transition while it loads the issues Suggestion: Instead of showing the loading in the corner - it is hard to see it - show the empty box where we show the issues with a loading. It would match all current behavior.
- thinking on this again, i think this is the better suggestion, even if it may spring the page a little.. as we use the same loading behaviour elsewhere.
- Add issues button on click shows no feedback. All vue components show a loading while waiting for server response. Should we do the same here?
- yes a little spinner icon when the button is loading would be nice feedback comparable with somewhere else in the application
@MadLittleMods @filipa9.4Eric Eastwoodcontact@ericeastwood.comEric Eastwoodcontact@ericeastwood.com