GitLab FOSS issueshttps://gitlab.com/gitlab-org/gitlab-foss/-/issues2019-08-07T08:34:17Zhttps://gitlab.com/gitlab-org/gitlab-foss/-/issues/35832Quick actions for assigning and removing group milestones2019-08-07T08:34:17ZVictor Wuvictor@gitlab.comQuick actions for assigning and removing group milestones- Within an issue or merge request.
- Within the description or a comment.
- Quick action for assigning and removing group milestones.
- Same command / UI as in here for quick actions on project milestones: https://docs.gitlab.com/ee/use...- Within an issue or merge request.
- Within the description or a comment.
- Quick action for assigning and removing group milestones.
- Same command / UI as in here for quick actions on project milestones: https://docs.gitlab.com/ee/user/project/quick_actions.html.
- We can use the same command / UI since group milestones and project milestones cannot have the same name.https://gitlab.com/gitlab-org/gitlab-foss/-/issues/35810404 on "Edit milestone" page when followed link on Group Milestones page2019-08-07T08:34:20ZJulian K.404 on "Edit milestone" page when followed link on Group Milestones page### Summary
Link to "Edit Milestone" for group milestones (introduced in GitLab 9.4) references a wrong milestone, resulting in 404 on `/groups/<group>/milestones/‹wrong ID›/edit`.
### Steps to reproduce
- Create **group milestone** o...### Summary
Link to "Edit Milestone" for group milestones (introduced in GitLab 9.4) references a wrong milestone, resulting in 404 on `/groups/<group>/milestones/‹wrong ID›/edit`.
### Steps to reproduce
- Create **group milestone** on `/groups/‹group›/milestones/`
- Go to `/groups/‹group›/milestones/`
- Click "Edit" on the newly created milestone.
### What is the current *bug* behavior?
The "Edit" link reference has a wrong milestone ID in it. The "Edit" page is actually accessible when browsed via /groups/‹group›/milestones/‹correct ID›/edit
It seems like an incorrect number range (one of a project milestone?) is looked up for creating the link reference.
### What is the expected *correct* behavior?
The "Edit Milestone" for the selected group milestone appears.
### Relevant logs and/or screenshots
production.log:
```
Started GET "/groups/‹group›/milestones/37/edit" for 10.0.200.187 at 2017-08-01 10:28:36 +0200
Processing by Groups::MilestonesController#edit as HTML
Parameters: {"group_id"=>"‹group›", "id"=>"37"}
Filter chain halted as :milestone rendered or redirected
Completed 404 Not Found in 28ms (Views: 0.9ms | ActiveRecord: 3.3ms)
Started POST "/api/v4/jobs/request" for 10.0.200.201 at 2017-08-01 10:28:36 +0200
Started GET "/-/metrics" for 127.0.0.1 at 2017-08-01 10:28:36 +0200
Processing by MetricsController#index as HTML
Filter chain halted as :validate_prometheus_metrics rendered or redirected
Completed 404 Not Found in 2ms (Views: 0.8ms | ActiveRecord: 0.0ms)
```
### Output of checks
This bug might also happen on GitLab.com.
#### Results of GitLab environment info
<details>
<summary>Expand for output related to GitLab environment info</summary>
<pre>
System information
System: Ubuntu 16.04
Current User: git
Using RVM: no
Ruby Version: 2.3.3p222
Gem Version: 2.6.6
Bundler Version:1.13.7
Rake Version: 10.5.0
Redis Version: 3.2.5
Git Version: 2.13.0
Sidekiq Version:5.0.0
Go Version: unknown
GitLab information
Version: 9.4.2
Revision: a2ffceb
Directory: /opt/gitlab/embedded/service/gitlab-rails
DB Adapter: postgresql
URL: https://gitlab.domain.com
HTTP Clone URL: https://gitlab.domain.com/some-group/some-project.git
SSH Clone URL: git@gitlab.domain.com:some-group/some-project.git
Using LDAP: yes
Using Omniauth: no
GitLab Shell
Version: 5.3.1
Repository storage paths:
- default: /var/opt/gitlab/git-data/repositories
Hooks: /opt/gitlab/embedded/service/gitlab-shell/hooks
Git: /opt/gitlab/embedded/bin/git
</pre>
</details>
#### Results of GitLab application Check
<details>
<summary>Expand for output related to the GitLab application check</summary>
<pre>
Checking GitLab Shell ...
GitLab Shell version >= 5.3.1 ? ... OK (5.3.1)
Repo base directory exists?
default... yes
Repo storage directories are symlinks?
default... no
Repo paths owned by git:root, or git:git?
default... yes
Repo paths access is drwxrws---?
default... yes
hooks directories in repos are links: ...
4/1 ... ok
14/2 ... ok
6/3 ... ok
6/4 ... ok
7/5 ... ok
5/6 ... ok
6/7 ... ok
6/8 ... ok
6/9 ... ok
3/10 ... ok
5/11 ... ok
6/12 ... ok
6/13 ... ok
6/14 ... ok
8/15 ... ok
6/16 ... ok
6/17 ... ok
6/18 ... ok
10/19 ... ok
2/20 ... ok
2/21 ... ok
2/22 ... ok
14/26 ... ok
3/27 ... ok
17/28 ... ok
10/29 ... ok
14/30 ... ok
2/31 ... repository is empty
14/32 ... ok
14/37 ... ok
10/38 ... ok
10/39 ... ok
10/40 ... ok
10/41 ... ok
10/42 ... ok
10/43 ... ok
14/44 ... ok
14/45 ... ok
14/46 ... ok
Running /opt/gitlab/embedded/service/gitlab-shell/bin/check
Check GitLab API access: OK
Access to /var/opt/gitlab/.ssh/authorized_keys: OK
Send ping to redis server: OK
gitlab-shell self-check successful
Checking GitLab Shell ... Finished
Checking Sidekiq ...
Running? ... yes
Number of Sidekiq processes ... 1
Checking Sidekiq ... Finished
Checking Reply by email ...
Reply by email is disabled in config/gitlab.yml
Checking Reply by email ... Finished
Checking LDAP ...
Server: ldapmain
LDAP authentication... Success
LDAP users with access to your GitLab server (only showing the first 100 results)
DN: uid=admin,ou=people,dc=domain,dc=com uid: admin
DN: uid=abc,ou=people,dc=domain,dc=com uid: abc
DN: uid=def,ou=people,dc=domain,dc=com uid: def
DN: uid=ghj,ou=people,dc=domain,dc=com uid: ghj
DN: uid=klm,ou=people,dc=domain,dc=com uid: klm
DN: uid=nop,ou=people,dc=domain,dc=com uid: nop
DN: uid=qrs,ou=people,dc=domain,dc=com uid: qrs
DN: uid=tuv,ou=people,dc=domain,dc=com uid: tuv
DN: uid=wxy,ou=people,dc=domain,dc=com uid: wxy
DN: uid=zab,ou=people,dc=domain,dc=com uid: zab
DN: uid=cde,ou=people,dc=domain,dc=com uid: cde
Checking LDAP ... Finished
Checking GitLab ...
Git configured correctly? ... yes
Database config exists? ... yes
All migrations up? ... yes
Database contains orphaned GroupMembers? ... no
GitLab config exists? ... yes
GitLab config up to date? ... yes
Log directory writable? ... yes
Tmp directory writable? ... yes
Uploads directory exists? ... yes
Uploads directory has correct permissions? ... yes
Uploads directory tmp has correct permissions? ... no
Try fixing it:
sudo chown -R git /var/opt/gitlab/gitlab-rails/uploads
sudo find /var/opt/gitlab/gitlab-rails/uploads -type f -exec chmod 0644 {} \;
sudo find /var/opt/gitlab/gitlab-rails/uploads -type d -not -path /var/opt/gitlab/gitlab-rails/uploads -exec chmod 0700 {} \;
For more information see:
doc/install/installation.md in section "GitLab"
Please fix the error above and rerun the checks.
Init script exists? ... skipped (omnibus-gitlab has no init script)
Init script up-to-date? ... skipped (omnibus-gitlab has no init script)
Projects have namespace: ...
4/1 ... yes
14/2 ... yes
6/3 ... yes
6/4 ... yes
7/5 ... yes
5/6 ... yes
6/7 ... yes
6/8 ... yes
6/9 ... yes
3/10 ... yes
5/11 ... yes
6/12 ... yes
6/13 ... yes
6/14 ... yes
8/15 ... yes
6/16 ... yes
6/17 ... yes
6/18 ... yes
10/19 ... yes
2/20 ... yes
2/21 ... yes
2/22 ... yes
14/26 ... yes
3/27 ... yes
17/28 ... yes
10/29 ... yes
14/30 ... yes
2/31 ... yes
14/32 ... yes
14/37 ... yes
10/38 ... yes
10/39 ... yes
10/40 ... yes
10/41 ... yes
10/42 ... yes
10/43 ... yes
14/44 ... yes
14/45 ... yes
14/46 ... yes
Redis version >= 2.8.0? ... yes
Ruby version >= 2.3.3 ? ... yes (2.3.3)
Git version >= 2.7.3 ? ... yes (2.13.0)
Active users: ... 9
Checking GitLab ... Finished
</pre>
</details>
https://gitlab.com/gitlab-org/gitlab-foss/-/issues/35748View group milestones on dashboard milestone page2019-09-11T12:16:40ZDavid Flanagandavid@rawkode.devView group milestones on dashboard milestone page### Description
- View group milestones on dashboard milestone page, i.e. it would appear here for the gitlab.com instance: https://gitlab.com/dashboard/milestones.
- Use the same UI as the group milestones page, where you have both proj...### Description
- View group milestones on dashboard milestone page, i.e. it would appear here for the gitlab.com instance: https://gitlab.com/dashboard/milestones.
- Use the same UI as the group milestones page, where you have both project milestones and group milestones shown.
An example of that group milestones page for the gitlab-org group is https://gitlab.com/groups/gitlab-org/milestones.
- Indicate the type of milestone being group milestone. In the image below, it is `Project Milestone` for existing list items. The new group milestones list items are group milestones so they should say `Group Milestone`
- ![image](https://gitlab.com/gitlab-org/gitlab-ce/uploads/8609ff94a5013da98a310cdd22500c6b/image.png)
- The dashboard milestone page currently has dynamic milestone links (that suck in project milestones). We should not change any of this functionality for this issue. These should not be changed. They will be handled in a future issue (see https://gitlab.com/gitlab-org/gitlab-ce/issues/39545).
- The scope of this issue is only to introduce _new_ group milestone links, that link directly to a native group milestone page, for example, https://gitlab.com/groups/gitlab-org/-/milestones/15.
- Another issue will introduce _new_ project milestone links (since the dynamic links will be removed). That is not in scope for this issue. This will be done in https://gitlab.com/gitlab-org/gitlab-ce/issues/49289.
### Out of scope
Let's scope these additional details in separate issues.
- Indicate the project or group path where the milestone is
- ![image](/uploads/a069e2b4662aa0af9832dfe504e2e846/image.png)
### Original description
<details>
### Summary
Browsing to `/dashboard/milestones` and the new Group Milestones aren't listed
### Steps to reproduce
Create a Group Milestones and browse to `/dashboard/milestones`
### What is the current *bug* behavior?
Group Milestones are missing
### What is the expected *correct* behavior?
Group Milestones should be listed
</details>11.2Kushal Pandyakushal@gitlab.comPedro Moreira da SilvaVictor Wuvictor@gitlab.comChantal RollisonKushal Pandyakushal@gitlab.comhttps://gitlab.com/gitlab-org/gitlab-foss/-/issues/35580Cannot import in a group a gitlab-exported project with milestones2019-08-07T08:34:34ZAlexandra CasapuCannot import in a group a gitlab-exported project with milestones### Summary
It seems I cannot import into a group a project which I exported from gitlab, if it has project milestones.
### Steps to reproduce
1. Create in gitlab a project with issues and project milestones
2. Export the project
...### Summary
It seems I cannot import into a group a project which I exported from gitlab, if it has project milestones.
### Steps to reproduce
1. Create in gitlab a project with issues and project milestones
2. Export the project
3. Create a new group
3. Try to import the project to the same account, in the newly created group
==> I get an error and the project cannot be imported
Error importing repository into [project name] - Validation failed: Group milestone should belong either to a project or a group
### Example Project
initial project: https://gitlab.com/alexandra.casapu/initial-milestones-project
project where I want to import the export of the initial project: https://gitlab.com/group-for-imported-project/imported-project/import/new
### What is the current *bug* behavior?
I get a validation error and the project is not imported.
### What is the expected *correct* behavior?
I should be able to import that project, as I don't have any group milestones defined. I only have project milestones. Even if they have the same name, they should be different accross projects. Maybe I have 2 projects which have the milestone "Version 1 release", but I want to set different dates for the 2 releases, so it makes sense to be able to have different milestones with the same names, in different projects.
### Output of checks
I can reproduce the bug on gitlab.com, and also on my local installation (GitLab 9.4.0).
### Possible fixes
This might be related to the group milestones feature, but I haven't pinpointed the problem in the code.
I have tried a workaround for this, namely to simply import the project in my account, and then to move it to the group, but I get an error: "Cannot move project", without any further details.
I have a lot of issues(tasks) and milestones defined and I would not like to spend the time to create them again, so fixing this bug would help me greatly.10.0Micaël BergeronMicaël Bergeronhttps://gitlab.com/gitlab-org/gitlab-foss/-/issues/35570(Add option to) start "new milestone" calendar on Monday instead of Sunday2019-08-07T08:34:35ZSander de Jong(Add option to) start "new milestone" calendar on Monday instead of Sunday### Description
Currently, when selecting the start/end date of a new milestone, the calendar starts on Sunday. This is what the US uses (as well as Canada and Japan), but in the rest of the world the calendar starts on Monday (ISO 8601 ...### Description
Currently, when selecting the start/end date of a new milestone, the calendar starts on Sunday. This is what the US uses (as well as Canada and Japan), but in the rest of the world the calendar starts on Monday (ISO 8601 standard). This makes it confusing to select dates.
### Proposal
Make Monday the first day of the week, or add an option to change between Sunday/Monday
### Links / references
* https://www.timeanddate.com/calendar/days/
* https://www.iso.org/iso-8601-date-and-time-format.html
### Documentation blurb
?
#### Overview
Add an option to make Monday the first day of the week in calendars. This is the worldwide default, Sunday as the first day is used by a minority group. This makes it less confusing for the rest of the world.
#### Use cases
This is useful for everyone living in a country where Monday is considered the first day of the week. i.e. most of the world
### Feature checklist
Make sure these are completed before closing the issue,
with a link to the relevant commit.
- [ ] [Feature assurance](https://about.gitlab.com/handbook/product/#feature-assurance)
- [ ] Documentation
- [ ] Added to [features.yml](https://gitlab.com/gitlab-com/www-gitlab-com/blob/master/data/features.yml)https://gitlab.com/gitlab-org/gitlab-foss/-/issues/35554404 when creating a new milestones from dashboard/milestones2018-05-16T09:33:16ZCindy Pallares 🦉cindy@gitlab.com404 when creating a new milestones from dashboard/milestones### Summary
When attempting to create a new milestone from the dashboard view a 404 is returned
![milestones](/uploads/f18768f93765aee9e56302fc5763004b/milestones.gif)
### Steps to reproduce
1. Head to <host>/dashboard/milestones
2...### Summary
When attempting to create a new milestone from the dashboard view a 404 is returned
![milestones](/uploads/f18768f93765aee9e56302fc5763004b/milestones.gif)
### Steps to reproduce
1. Head to <host>/dashboard/milestones
2. Click on the New Milestone button
### What is the current *bug* behavior?
A 404 page
![The_page_you_re_looking_for_could_not_be_found__404__and_Kaptures](/uploads/05d27162ec73d143357fd0735252ce11/The_page_you_re_looking_for_could_not_be_found__404__and_Kaptures.png)
### What is the expected *correct* behavior?
A new milestone should be created for that project
#### GitLab version
9.4.0-eehttps://gitlab.com/gitlab-org/gitlab-foss/-/issues/35481Milestone in sidebar does not link to group milestone page2019-08-07T08:34:40ZVictor Wuvictor@gitlab.comMilestone in sidebar does not link to group milestone pageSee this issue: https://gitlab.com/gitlab-org/gitlab-ce/issues/24395
The milestone is 9.7, which is a native group milestone for gitlab.org.
It does _not_ link to the group milestone page.See this issue: https://gitlab.com/gitlab-org/gitlab-ce/issues/24395
The milestone is 9.7, which is a native group milestone for gitlab.org.
It does _not_ link to the group milestone page.9.4Jarka Košanovájarka@gitlab.comJarka Košanovájarka@gitlab.comhttps://gitlab.com/gitlab-org/gitlab-foss/-/issues/35454Two buttons with the same name and function2017-07-24T16:32:14ZLukeTwo buttons with the same name and function### Summary
There are two "new merge request" buttons.
### Steps to reproduce
* Update to 9.4.0
* Turn on new UI.
* Go to issues
* Go to milestones
* See two green buttons
### Example Project
https://gitlab.com/Luke081515/testproj/m...### Summary
There are two "new merge request" buttons.
### Steps to reproduce
* Update to 9.4.0
* Turn on new UI.
* Go to issues
* Go to milestones
* See two green buttons
### Example Project
https://gitlab.com/Luke081515/testproj/milestones
### What is the current *bug* behavior?
Two green buttons with the same name and function
### What is the expected *correct* behavior?
Only one button.
### Relevant logs and/or screenshots
![dub](/uploads/b1cfaf79de939e7b1d426a07950bc9c3/dub.PNG)Phil HughesPhil Hugheshttps://gitlab.com/gitlab-org/gitlab-foss/-/issues/35279consistent group milestone2019-08-07T08:34:50Zbenoît chesneauconsistent group milestone### Description
Currently we have the following:
- group milestones only shows list on issues and doesn't provide the same view you can have per projects
- the group milestone isn't displayed in the project milestones
### Proposal
*...### Description
Currently we have the following:
- group milestones only shows list on issues and doesn't provide the same view you can have per projects
- the group milestone isn't displayed in the project milestones
### Proposal
* [ ] Have a similar view to the project view at the group levels for milestones.
* [ ] Show the group milestones in the project milestones when one of its issue is associated to the group milestone.
This would remove the need of creating meta projects to handle a group milestone.https://gitlab.com/gitlab-org/gitlab-foss/-/issues/35045Estimated times in Milestone view2021-11-17T14:02:35ZBas de KortEstimated times in Milestone view### Description
If I have 5 small issues (small estimated times) in a milestone and 1 issue that is estimated to take severe time to fix, the milestone view does not account for that. It simply has a progressbar which shows x out of y i...### Description
If I have 5 small issues (small estimated times) in a milestone and 1 issue that is estimated to take severe time to fix, the milestone view does not account for that. It simply has a progressbar which shows x out of y issues resolved. It would be very handy if you could also show a view based on the estimates in the issues.
It would also be nice to see the total estime for the milestone.
### Proposal
If issues have no estimates simply keep the display as is, but if the issues in the milestone do have estimates add another progressbar which shows information based on the estimates time.
So let's say we have an issue estimated to take 1h and 4 issues estimated to take 10m and we have finished the 1h task, to see a progressbar like this:
```
[----- ] 1/5 issues solved
[--------------- ] 1h / 1h40m done
```
This way you get a clear view on the estimated time left in this milestone.
#### Overview
What is it?
A way to get insight in the estimated time left in a milestone.
Why should someone use this feature?
It can be used as a guidance tool for planning
#### Use cases
Who is this for? Provide one or more use cases.
This is to quickly get an insight in the estimated time required to finish all issues in a milestone.
### Feature checklist
Make sure these are completed before closing the issue,
with a link to the relevant commit.
- [ ] [Feature assurance](https://about.gitlab.com/handbook/product/#feature-assurance)
- [ ] Documentation
- [ ] Added to [features.yml](https://gitlab.com/gitlab-com/www-gitlab-com/blob/master/data/features.yml)https://gitlab.com/gitlab-org/gitlab-foss/-/issues/34852Build failure in master "MilestonesFinder with order default orders by due date"2017-09-05T14:34:25ZMike GreilingBuild failure in master "MilestonesFinder with order default orders by due date"This has been showing up consistently in master since !12280 was merged:
https://gitlab.com/gitlab-org/gitlab-ce/-/jobs/21570333
```
Failures:
1) MilestonesFinder with order default orders by due date
Failure/Error: expect(resu...This has been showing up consistently in master since !12280 was merged:
https://gitlab.com/gitlab-org/gitlab-ce/-/jobs/21570333
```
Failures:
1) MilestonesFinder with order default orders by due date
Failure/Error: expect(result.first).to eq(milestone_1)
expected: #<Milestone id: 29, title: "one test", project_id: nil, description: nil, due_date: "2017-07-07", cre...e_html: "one test", description_html: "", start_date: nil, cached_markdown_version: 1, group_id: 22>
got: #<Milestone id: 30, title: "My title 501", project_id: nil, description: nil, due_date: nil, created_...ml: "My title 501", description_html: "", start_date: nil, cached_markdown_version: 1, group_id: 22>
(compared using ==)
Diff:
@@ -1,14 +1,14 @@
-#<Milestone:0x00000021ef1188
- id: 29,
- title: "one test",
+#<Milestone:0x00000021212980
+ id: 30,
+ title: "My title 501",
project_id: nil,
description: nil,
- due_date: Fri, 07 Jul 2017,
+ due_date: nil,
created_at: Fri, 07 Jul 2017 21:25:28 UTC +00:00,
updated_at: Fri, 07 Jul 2017 21:25:28 UTC +00:00,
state: "active",
- iid: 1,
- title_html: "one test",
+ iid: 2,
+ title_html: "My title 501",
description_html: "",
start_date: nil,
cached_markdown_version: 1,
# ./spec/finders/milestones_finder_spec.rb:77:in `block (3 levels) in <top (required)>'
# ./spec/spec_helper.rb:90:in `block (2 levels) in <top (required)>'
```
/cc @felipe_artur @selfup @smcgivern9.4https://gitlab.com/gitlab-org/gitlab-foss/-/issues/34778Support references to group milestones and create system notes2019-08-07T08:35:15ZSean McGivernSupport references to group milestones and create system notesWhen there is a group milestone, it doesn't get linked as a reference. Here, v2.5 is a group milestone:
![image](/uploads/300ea6521feb8d0c0761c0c812f3d0af/image.png)
We should take inspiration from group labels here. In particular, we ...When there is a group milestone, it doesn't get linked as a reference. Here, v2.5 is a group milestone:
![image](/uploads/300ea6521feb8d0c0761c0c812f3d0af/image.png)
We should take inspiration from group labels here. In particular, we don't need a reference prefix / suffix for group milestones - we can just look for them if there is no matching project milestone.
When doing this, we should:
1. Support references.
2. Add a system note when a group milestone is set, using that reference. (IID is tricky here because it could be either the project IID or group IID.)
3. Add this to autocomplete.
4. Enable slash commands for group milestones.9.5Sean McGivernSean McGivernhttps://gitlab.com/gitlab-org/gitlab-foss/-/issues/34622Create group milestones api endpoint2019-08-07T08:35:22ZFelipe ArturCreate group milestones api endpointFollow up of
https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/12280/diffsFollow up of
https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/12280/diffs9.5Felipe ArturFelipe Arturhttps://gitlab.com/gitlab-org/gitlab-foss/-/issues/34309Drop GFM support for the title of Milestone/MergeRequest in template2018-01-20T02:10:44ZTakuya NoguchiDrop GFM support for the title of Milestone/MergeRequest in template### Description
The title of Milestone/MergeRequest should be treated as plain, not as markdown (GFM), when linking the title to the Milestone/MergeRequest with `link_to_gfm` as seen #34289.
### Proposal
Use `link_to` instead of `link...### Description
The title of Milestone/MergeRequest should be treated as plain, not as markdown (GFM), when linking the title to the Milestone/MergeRequest with `link_to_gfm` as seen #34289.
### Proposal
Use `link_to` instead of `link_to_gfm` in their templates. `link_to` is much faster than `link_to_gdm`.
#### Note
The `title`/`full_title` of Commit is expected to be in the markdown format so this proposal leaves it as is.
### Links / references
#34289
`/label` ~"feature proposal" ~milestones ~backend ~performanceTakuya NoguchiTakuya Noguchihttps://gitlab.com/gitlab-org/gitlab-foss/-/issues/34289Drop GFM support in Issue/MergeRequest in Milestone2019-09-14T07:07:19ZTakuya NoguchiDrop GFM support in Issue/MergeRequest in Milestone### Description
Drop GFM support in Issue/MergeRequest in Milestone page to speed up page rendering.
### Proposal
Milestone page with many issues and/or merge requests (typically 30-100) is extremely slow (meta: #33885) due to GFM sup...### Description
Drop GFM support in Issue/MergeRequest in Milestone page to speed up page rendering.
### Proposal
Milestone page with many issues and/or merge requests (typically 30-100) is extremely slow (meta: #33885) due to GFM support of their **title** there.
Even on Issues and Merge Requests page, the title of each issue/merge request does not have GFM support, so we should drop GFM support on Milestone page both for **the consistency** and **performance**.
### Research
- https://gitlab.com/gitlab-org/gitlab-ce/issues/33885#note_33427661
- https://gitlab.com/gitlab-org/gitlab-ce/issues/33885#note_33427891
### Links / references
Meta: #33885
---
`/label` ~"feature proposal" ~milestones ~performance ~backendTakuya NoguchiTakuya Noguchihttps://gitlab.com/gitlab-org/gitlab-foss/-/issues/34116Incorrect Milestones for filtering on Group Issues2019-08-07T08:35:49ZTakuya NoguchiIncorrect Milestones for filtering on Group Issues### Summary
Milestone filtering on Group Issues (e.g. https://gitlab.com/groups/gitlab-org/issues) shows milestones from dashboard issues. When a user is not logged in, they will get an error message.
### Steps to reproduce
1. Open an...### Summary
Milestone filtering on Group Issues (e.g. https://gitlab.com/groups/gitlab-org/issues) shows milestones from dashboard issues. When a user is not logged in, they will get an error message.
### Steps to reproduce
1. Open any Group Issues (e.g., https://gitlab.com/groups/gitlab-org/issues) on your browser (with larger screen to see the milestone filtering dropdown) and click the milestone filtering dropdown to get this bug.
2. Repeat the above step in an incognito windown
### What is the current *bug* behavior?
#### for logged in user
Currently logged in users can see different milestones from targeted Group's ones when trying to filter Group Issues by Milestone on Web UI.
#### for anonymous user
Currently anonymous (non-login) users can see an unreasonable error message when trying to filter Group Issues by Milestone on Web UI.
### Relevant logs and/or screenshots
#### for anonymous user
![group-issues-milestone-filtering-for-anon](/uploads/e08d3185817524ef5d268ba122062e4c/group-issues-milestone-filtering-for-anon.gif)
### Output of checks / Results of GitLab environment info
This bug happens on GitLab.com. (as of GitLab EE 9.3.0-rc5)
`/label` ~bug9.4Takuya NoguchiTakuya Noguchihttps://gitlab.com/gitlab-org/gitlab-foss/-/issues/33815Milestone labelling2019-08-07T08:36:18ZSheena O Connelsheena@dotmodus.comMilestone labelling### Description
Allow milestone labelling or tagging. Much like how you can add labels to issues. Also allow filtering milestones by label.
### Proposal
### Links / references
### Documentation blurb
1. Why should someone use it; wh...### Description
Allow milestone labelling or tagging. Much like how you can add labels to issues. Also allow filtering milestones by label.
### Proposal
### Links / references
### Documentation blurb
1. Why should someone use it; what's the underlying problem.
It is often the case that there are a bunch of milestones that have not yet been scheduled and are of various priority or related to different major features. Eg: there might be a high prioroity milestone that is all about some part of a UI; and a slightly lower priority milestone that is all about some scheduled tasks. Or whatever. Different priorities and flavours of milestones cant easily be represented. Personally I use namespacing a lot. eg: "p1 web: login forms", "p2 sched: daily settlement", etc where the p value is the priority. This has some shortcomings though because there is no milestone filter-by-name functionality.
2. What is the solution
Allow milestones to be given labels. And allow for the milestone page to allow filtering by label. (And name and author if possible)
3. How does someone use this
The same way as you would for issueshttps://gitlab.com/gitlab-org/gitlab-foss/-/issues/33803500 error in Project Milestone detail page with JSON format request2019-08-07T08:36:20ZTakuya Noguchi500 error in Project Milestone detail page with JSON format request### Summary
Project Milestone detail page with the request of JSON format always returns a 500 error of the HTTP status code, not 406.
### Steps to reproduce
1. You can see 500 error when you execute the following code in your t...### Summary
Project Milestone detail page with the request of JSON format always returns a 500 error of the HTTP status code, not 406.
### Steps to reproduce
1. You can see 500 error when you execute the following code in your terminal:
```sh
curl -v -H 'Accept: application/json' https://gitlab.com/gitlab-org/gitlab-ce/milestones/1
```
### Example Project
Reproduced on gitlab.com (as of 2017-07-17) as well as `master` of gitlab-ce source.
### What is the current *bug* behavior?
```
< HTTP/1.1 500 Internal Server Error
< Content-Type: text/html; charset=utf-8
< [...]
<
<!DOCTYPE html>
<html>
<head>
<meta content="width=device-width, initial-scale=1, maximum-scale=1" name="viewport">
<title>Something went wrong (500)</title>
[...]
```
### What is the expected *correct* behavior?
```
< HTTP/1.1 406 Not Acceptable
< Content-Type: text/html; charset=utf-8
< Content-Length: 0
< [...]
```
### Relevant logs and/or screenshots
```
ActionView::MissingTemplate at /gitlab-org/gitlab-ce/milestones/1
=================================================================
> Missing template projects/milestones/show, projects/application/show, application/show with {:locale=>[:en], :formats=>[:json], :variants=>[], :handlers=>[:erb, :builder, :raw, :ruby, :coffee, :haml]}. Searched in:
```
### Output of checks / Results of GitLab environment info / Results of GitLab application Check
This bug happens on GitLab.com.
### Possible fixes
We may return 406 status code.Takuya NoguchiTakuya Noguchihttps://gitlab.com/gitlab-org/gitlab-foss/-/issues/33712Merge Requests/Participants/Labels tabs in Milestones freeze at progress anim...2017-06-21T07:35:14ZKevyn-Alexandre ParéMerge Requests/Participants/Labels tabs in Milestones freeze at progress animation### Summary
The tabs in `Milestones` are not loading except the `issues` tab after update from 9.1.3 to 9.2.5.
This is happening on our internal server and on gitlab.com
### Steps to reproduce
1. Running Ubuntu 16.04
1. Chr...### Summary
The tabs in `Milestones` are not loading except the `issues` tab after update from 9.1.3 to 9.2.5.
This is happening on our internal server and on gitlab.com
### Steps to reproduce
1. Running Ubuntu 16.04
1. Chromium Version 58.0.3029.110 Built on Ubuntu , running on Ubuntu 16.04 (64-bit)
1. Or Firefox 53.0.2 (64-bit)
1. Select `Milestones`/(Merge Requests or Participants or Labels)
### Example Project
### What is the current *bug* behavior?
Merge Requests in `Milestones` are not listed the progress animation loop forever.
### What is the expected *correct* behavior?
Load the Merge Requests associated to the `Milestones`.
### Relevant logs and/or screenshots
### Output of checks
This bug happens on GitLab.com
#### Results of GitLab environment info
<details>
<summary>Expand for output related to GitLab environment info</summary>
<pre>
(For installations with omnibus-gitlab package run and paste the output of:
`sudo gitlab-rake gitlab:env:info`)
-> gitlab-rake gitlab:env:info
System information
System: Ubuntu 16.04
Current User: git
Using RVM: no
Ruby Version: 2.3.3p222
Gem Version: 2.6.6
Bundler Version:1.13.7
Rake Version: 10.5.0
Redis Version: 3.2.5
Git Version: 2.11.1
Sidekiq Version:5.0.0
GitLab information
Version: 9.2.5
Revision: 6f2e590
Directory: /opt/gitlab/embedded/service/gitlab-rails
DB Adapter: postgresql
URL: http://builder8.rogue-research.com
HTTP Clone URL: http://builder8.rogue-research.com/some-group/some-project.git
SSH Clone URL: git@builder8.rogue-research.com:some-group/some-project.git
Using LDAP: no
Using Omniauth: no
GitLab Shell
Version: 5.0.4
Repository storage paths:
- default: /var/opt/gitlab/git-data/repositories
Hooks: /opt/gitlab/embedded/service/gitlab-shell/hooks
Git: /opt/gitlab/embedded/bin/git
</pre>
</details>
#### Results of GitLab application Check
<details>
<summary>Expand for output related to the GitLab application check</summary>
<pre>
(For installations with omnibus-gitlab package run and paste the output of:
`sudo gitlab-rake gitlab:check SANITIZE=true`)
(For installations from source run and paste the output of:
`sudo -u git -H bundle exec rake gitlab:check RAILS_ENV=production SANITIZE=true`)
(we will only investigate if the tests are passing)
</pre>
</details>
### Possible fixes
(If you can, link to the line of code that might be responsible for the problem)https://gitlab.com/gitlab-org/gitlab-foss/-/issues/33586Native group milestone issue list and merge request list2019-08-07T08:36:33ZVictor Wuvictor@gitlab.comNative group milestone issue list and merge request list## Resources
BE @felipe_artur | FE @selfup | UX @cperessini | PM @victorwu
Follow up of https://gitlab.com/gitlab-org/gitlab-ce/issues/30126.
Show the issue lists and the merge request lists on the native group milestone page.## Resources
BE @felipe_artur | FE @selfup | UX @cperessini | PM @victorwu
Follow up of https://gitlab.com/gitlab-org/gitlab-ce/issues/30126.
Show the issue lists and the merge request lists on the native group milestone page.Backlog