GitLab FOSS issueshttps://gitlab.com/gitlab-org/gitlab-foss/-/issues2019-08-07T08:07:34Zhttps://gitlab.com/gitlab-org/gitlab-foss/-/issues/28604Release 8.16.72019-08-07T08:07:34ZJames LopezRelease 8.16.7- Picked into respective `stable` branches. [`Pick into Stable` 8.16 merged merge requests]:
- [x] https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/8735
- [x] https://gitlab.com/gitlab-org/gitlab-ee/merge_requests/1206
- [x] ...- Picked into respective `stable` branches. [`Pick into Stable` 8.16 merged merge requests]:
- [x] https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/8735
- [x] https://gitlab.com/gitlab-org/gitlab-ee/merge_requests/1206
- [x] https://gitlab.com/gitlab-org/gitlab-ee/merge_requests/1264
- [ ] ~~https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/9400~~
- [x] https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/9091
- [x] Merge `ce/8-16-stable` into `ee/8-16-stable-ee`
- [x] Check [`omnibus-gitlab/8-16-stable` CHANGELOG.md][omnibus-stable-changelog]
- [x] Check [`omnibus-gitlab/8-16-stable-ee` CHANGELOG.md][omnibus-stable-ee-changelog]
- [x] While waiting for tests to be green, now is a good time to start on the blog post: https://gitlab.com/gitlab-com/www-gitlab-com/merge_requests/5129
- [x] Ensure [tests are green on CE]
- [x] Ensure [tests are green on EE]
- [x] Check for any problematic migrations in EE (EE migrations include CE ones), and paste the diff in a snippet: `git diff v8.16.6-ee..8-16-stable-ee -- db/migrate` =>
- [x] Tag the `8.16.7` version using the [`release` task]:
```sh
bundle exec rake "release[8.16.7]"
```
- [x] Check that [EE packages are built], [CE packages are built] and appears on `packages.gitlab.com`: [EE](https://packages.gitlab.com/app/gitlab/gitlab-ee/search?q=8.16.7) / [CE](https://packages.gitlab.com/app/gitlab/gitlab-ce/search?q=8.16.7)
- [ ] In `#infrastructure`:
```
I'm going to deploy `8.16.7` to staging
```
- [ ] Deploy [`8.16.7`](https://packages.gitlab.com/gitlab/gitlab-ee/packages/ubuntu/xenial/gitlab-ee_8.16.7-ee.0_amd64.deb) to [staging.gitlab.com]
- [ ] In `#infrastructure`:
```
I'm going to deploy `8.16.7` to production
```
- [ ] Deploy [`8.16.7`](https://packages.gitlab.com/gitlab/gitlab-ee/packages/ubuntu/xenial/gitlab-ee_8.16.7-ee.0_amd64.deb) to [GitLab.com]
- [x] Create the `8.16.7` version on https://version.gitlab.com
- [x] Deploy the blog post
- [x] Tweet (prepare the Tweet text below or paste the tweet URL instead):
```
GitLab 8.16.7 is released! BLOG_POST_URL DESCRIPTION OF THE CHANGES
```
- In the [8.16 Regressions](https://gitlab.com/gitlab-org/gitlab-ce/issues/26770) issue:
- [x] Add the following notice:
```
`8.16.7` has been tagged, further fixes will go into `8.16.8` as necessary.
```
- [x] Remove notes for the regressions fixed by version `8.16.7`
- [x] Add [`omnibus-gitlab/8.16.7+ce.0` CHANGELOG.md][omnibus-tag-changelog] items to [`omnibus-gitlab/master` CHANGELOG.md][omnibus-master-changelog]
---
For references:
- https://dev.gitlab.org/gitlab/gitlab-ee/commits/8-16-stable-ee
- https://dev.gitlab.org/gitlab/gitlabhq/commits/8-16-stable
- https://dev.gitlab.org/gitlab/omnibus-gitlab/commits/8-16-stable-ee
- https://dev.gitlab.org/gitlab/omnibus-gitlab/commits/8-16-stable
[`Pick into Stable` 8.16 merged merge requests]: https://gitlab.com/groups/gitlab-org/merge_requests?label_name%5B%5D=Pick+into+Stable&milestone_title=8.16&scope=all&sort=id_desc&state=merged
[omnibus-stable-changelog]: https://gitlab.com/gitlab-org/omnibus-gitlab/blob/8-16-stable/CHANGELOG.md
[omnibus-stable-ee-changelog]: https://gitlab.com/gitlab-org/omnibus-gitlab/blob/8-16-stable-ee/CHANGELOG.md
[tests are green on CE]: https://dev.gitlab.org/gitlab/gitlabhq/commits/8-16-stable
[tests are green on EE]: https://dev.gitlab.org/gitlab/gitlab-ee/commits/8-16-stable-ee
[EE packages are built]: https://dev.gitlab.org/gitlab/omnibus-gitlab/commits/8-10-stable-ee
[CE packages are built]: https://dev.gitlab.org/gitlab/omnibus-gitlab/commits/8-10-stable
[omnibus-tag-changelog]: https://gitlab.com/gitlab-org/omnibus-gitlab/blob/8.16.7+ce.0/CHANGELOG.md
[omnibus-master-changelog]: https://gitlab.com/gitlab-org/omnibus-gitlab/blob/master/CHANGELOG.md
[EE packages are built]: https://dev.gitlab.org/gitlab/omnibus-gitlab/commits/8-16-stable-ee
[CE packages are built]: https://dev.gitlab.org/gitlab/omnibus-gitlab/commits/8-16-stable
[`gitlab/gitlab-ee`]: https://packages.gitlab.com/gitlab/gitlab-ee
[`gitlab/gitlab-ce`]: https://packages.gitlab.com/gitlab/gitlab-ce
[`release` task]: https://gitlab.com/gitlab-org/release-tools/blob/master/doc%2Frake-tasks.md#releaseversion
[`patch_issue` task]: https://gitlab.com/gitlab-org/release-tools/blob/master/doc%2Frake-tasks.md#patch_issueversion
[staging.gitlab.com]: https://dev.gitlab.org/cookbooks/chef-repo/blob/master/doc/deploying.md
[GitLab.com]: https://dev.gitlab.org/cookbooks/chef-repo/blob/master/doc/deploying.md8.16James LopezJames Lopezhttps://gitlab.com/gitlab-org/gitlab-foss/-/issues/267708.16 Regressions2019-08-07T08:07:41ZJames Lopez8.16 RegressionsThis is a meta issue to index possible regressions in this monthly release
and any patch versions.
Please do not raise or discuss issues directly in this issue but link to
issues that might warrant a patch release. If there is a Merge R...This is a meta issue to index possible regressions in this monthly release
and any patch versions.
Please do not raise or discuss issues directly in this issue but link to
issues that might warrant a patch release. If there is a Merge Request
that fixes the issue, please link to that as well.
Please only post one regression issue and/or merge request per comment.
Comments will be updated by the release manager as they are addressed.8.16James LopezJames Lopezhttps://gitlab.com/gitlab-org/gitlab-foss/-/issues/26641Broken remove dot git migration in staging2017-07-26T02:01:04ZJames LopezBroken remove dot git migration in stagingCopied from https://gitlab.com/gitlab-org/gitlab-ce/issues/26392#note_21323412
RC1 migrations failed in staging because of:
```shell
Exception: namespace directory cannot be moved
/opt/gitlab/embedded/service/gitlab-rails/db/migr...Copied from https://gitlab.com/gitlab-org/gitlab-ce/issues/26392#note_21323412
RC1 migrations failed in staging because of:
```shell
Exception: namespace directory cannot be moved
/opt/gitlab/embedded/service/gitlab-rails/db/migrate/20161226122833_remove_dot_git_from_usernames.rb:81:in `block in move_namespace'
```
This happened because the path existed already:
```ruby
gitlab_shell.exists?('/var/opt/gitlab/git-data/repositories', 'offending_path')
=> true
```
See actual offending path in https://gitlab.slack.com/files/jameslopez/F3QP09KEW/-.rb
Not sure if the path was supposed to be in `routes` but `route_exists?` didn't find it... So it blows up as `gitlab_shell.mv_namespace(repository_storage_path, path_was, path)` is `false`
One solution would be to `gitlab_shell.exists?('/var/opt/gitlab/git-data/repositories', 'offending_path')`8.16James LopezJames Lopezhttps://gitlab.com/gitlab-org/gitlab-foss/-/issues/26392Release 8.162019-08-07T08:07:42ZJames LopezRelease 8.16Release post: https://gitlab.com/gitlab-com/www-gitlab-com/merge_requests/4522
Regressions issue: https://gitlab.com/gitlab-org/gitlab-ce/issues/26770
### 2nd: (15 working days before the 22nd)
#### RC1
- [ ] Ensure `omnibus-...Release post: https://gitlab.com/gitlab-com/www-gitlab-com/merge_requests/4522
Regressions issue: https://gitlab.com/gitlab-org/gitlab-ce/issues/26770
### 2nd: (15 working days before the 22nd)
#### RC1
- [ ] Ensure `omnibus-gitlab` is ready to build packages by asking the Omnibus maintainers
- Follow the [Creating RC1] guide:
- [x] Update the "Installation from Source" guide
- [x] Create the Update guides
- [x] Have someone run `bin/rake gitlab:update_templates` and open a merge request to master with ~"Pick into Stable"
- [x] Merge [GitLab CE into EE] via merge request: https://gitlab.com/gitlab-org/gitlab-ee/merge_requests/1037
- [x] Check for any problematic migrations in EE (EE migrations include CE ones), and paste the diff in a snippet: `git diff LATEST_PATCH_TAG-ee..master -- db/migrate` => https://gitlab.com/snippets/35018
- [x] Sync CE, EE, and Omnibus to `dev`
- [x] In `#core`:
```
@developers
I am about to tag `8.16.0-rc1`. I will still merge `master` into
`8-16-stable` until the 17th.
```
- [x] Ensure [tests are green on CE](https://dev.gitlab.org/gitlab/gitlabhq/commits/master)
- [x] Ensure [tests are green on EE](https://dev.gitlab.org/gitlab/gitlab-ee/commits/master)
- [x] In `#releases`: I'm going to tag `8.16.0-rc1`
- [x] Tag the `8.16.0-rc1` version using the [`release` task]:
```sh
bundle exec rake "release[8.16.0-rc1]"
```
- [x] Check that [EE packages are built], [CE packages are built] and appears on `packages.gitlab.com`: [EE & CE](https://packages.gitlab.com/app/gitlab/unstable/search?q=8.16.0-rc1)
- [x] In `#infrastructure`: I'm going to deploy `8.16.0-rc1` to staging
- [x] Deploy [`8.16.0-rc1`](https://packages.gitlab.com/gitlab/unstable/packages/ubuntu/xenial/gitlab-ee_8.16.0-rc1.ee.0_amd64.deb) to [staging.gitlab.com]
- [x] In `#infrastructure`: I'm going to deploy `8.16.0-rc1` to production
- [ ] Deploy [`8.16.0-rc1`](https://packages.gitlab.com/gitlab/unstable/packages/ubuntu/xenial/gitlab-ee_8.16.0-rc1.ee.0_amd64.deb) to [GitLab.com]
- [x] Create the [regression issue] in the CE issue tracker using the [`regression_issue` task] and bookmark it:
```sh
bundle exec rake "regression_issue[8.16.0]"
```
- [x] Prepare the [blog post] using the [`new_release_post` task], in the [`www-gitlab-com` project]:
```sh
bundle exec rake "new_release_post[8.16]"
```
### Anytime between 2nd (15 working days before the 22nd) and 17th (4 working days before the 22nd)
#### RC2
- [x] Merge CE `master` into CE `8-16-stable`
- [x] Merge EE `master` into EE `8-16-stable-ee`
- Follow the [Creating subsequent RCs] guide for `8.16.0-rc2`:
- [x] Merge CE `8-16-stable` into EE `8-16-stable-ee` following the [Merging a CE stable branch into its EE counterpart] guide https://gitlab.com/gitlab-org/gitlab-ee/merge_requests/1054
- [x] Check for any problematic migrations in EE (EE migrations include CE ones), and paste the diff in a snippet: `git diff v8.16.0-rc1-ee..8-16-stable-ee -- db/migrate` => https://gitlab.com/snippets/35355
- [x] Sync CE, EE, and Omnibus to `dev`
- [x] Ensure [tests are green on CE]
- [x] Ensure [tests are green on EE]
- [x] In `#releases`: I'm going to tag `8.16.0-rc2`
- [x] Tag the `8.16.0-rc2` version using the [`release` task]:
```sh
bundle exec rake "release[8.16.0-rc2]"
```
- [ ] Check that [EE packages are built], [CE packages are built] and appears on `packages.gitlab.com`: [EE & CE](https://packages.gitlab.com/app/gitlab/unstable/search?q=8.16.0-rc2)
- [x] In `#infrastructure`: I'm going to deploy `8.16.0-rc2` to staging
- [ ] Deploy [`8.16.0-rc2`](https://packages.gitlab.com/gitlab/unstable/packages/ubuntu/xenial/gitlab-ee_8.16.0-rc2.ee.0_amd64.deb) to [staging.gitlab.com]
- [ ] In `#infrastructure`: I'm going to deploy `8.16.0-rc2` to production
- [ ] Deploy [`8.16.0-rc2`](https://packages.gitlab.com/gitlab/unstable/packages/ubuntu/xenial/gitlab-ee_8.16.0-rc2.ee.0_amd64.deb) to [GitLab.com]
#### RC3
- [x] Merge CE `master` into CE `8-16-stable`
- [x] Merge EE `master` into EE `8-16-stable-ee`
- Follow the [Creating subsequent RCs] guide for `8.16.0-rc3`:
- [x] Merge CE `8-16-stable` into EE `8-16-stable-ee` following the [Merging a CE stable branch into its EE counterpart] guide => https://gitlab.com/gitlab-org/gitlab-ee/merge_requests/1061
- [x] Check for any problematic migrations in EE (EE migrations include CE ones), and paste the diff in a snippet: `git diff v8.16.0-rc2-ee..8-16-stable-ee -- db/migrate` =>
- [x] Sync CE, EE, and Omnibus to `dev`
- [x] Ensure [tests are green on CE]
- [x] Ensure [tests are green on EE]
- [x] In `#releases`: I'm going to tag `8.16.0-rc3`
- [x] Tag the `8.16.0-rc3` version using the [`release` task]:
```sh
bundle exec rake "release[8.16.0-rc3]"
```
- [x] Check that [EE packages are built], [CE packages are built] and appears on `packages.gitlab.com`: [EE & CE](https://packages.gitlab.com/app/gitlab/unstable/search?q=8.16.0-rc3)
- [x] In `#infrastructure`: I'm going to deploy `8.16.0-rc3` to staging
- [x] Deploy [`8.16.0-rc3`](https://packages.gitlab.com/gitlab/unstable/packages/ubuntu/xenial/gitlab-ee_8.16.0-rc3.ee.0_amd64.deb) to [staging.gitlab.com]
- [x] In `#infrastructure`: I'm going to deploy `8.16.0-rc3` to production
- [x] Deploy [`8.16.0-rc3`](https://packages.gitlab.com/gitlab/unstable/packages/ubuntu/xenial/gitlab-ee_8.16.0-rc3.ee.0_amd64.deb) to [GitLab.com]
#### RC4
- [x] Cherry-pick merge requests labeled [`Picked into Stable`] for the current
milestone (you can take advantage of the
[`Picked into Stable` 8.16 merged merge requests] page) into
the CE `8-16-stable` and EE `8-16-stable-ee`
branches, respectively
- Follow the [Creating subsequent RCs] guide for `8.16.0-rc4` (**be sure to use the correct RC number**):
- [x] Merge CE `8-16-stable` into EE `8-16-stable-ee` following the [Merging a CE stable branch into its EE counterpart] guide => https://gitlab.com/gitlab-org/gitlab-ee/merge_requests/1074
- [x] Check for any problematic migrations in EE (EE migrations include CE ones), and paste the diff in a snippet: `git diff v8.16.0-rc3-ee..8-16-stable-ee -- db/migrate` =>
- [x] Sync CE, EE, and Omnibus to `dev`
- [x] Ensure [tests are green on CE]
- [x] Ensure [tests are green on EE]
- [x] In `#releases`: I'm going to tag `8.16.0-rc4`
- [x] Tag the `8.16.0-rc4` version using the [`release` task]:
```sh
bundle exec rake "release[8.16.0-rc4]"
```
- [ ] Check that [EE packages are built], [CE packages are built] and appears on `packages.gitlab.com`: [EE & CE](https://packages.gitlab.com/app/gitlab/unstable/search?q=8.16.0-rc4)
- [ ] In `#infrastructure`: I'm going to deploy `8.16.0-rc4` to staging
- [ ] Deploy [`8.16.0-rc4`](https://packages.gitlab.com/gitlab/unstable/packages/ubuntu/xenial/gitlab-ee_8.16.0-rc4.ee.0_amd64.deb) to [staging.gitlab.com]
- [ ] In `#infrastructure`: I'm going to deploy `8.16.0-rc4` to production
- [ ] Deploy [`8.16.0-rc4`](https://packages.gitlab.com/gitlab/unstable/packages/ubuntu/xenial/gitlab-ee_8.16.0-rc4.ee.0_amd64.deb) to [GitLab.com]
- [ ] Tweet about the `8.16.0-rc4` release:
```
GitLab 8.16.0-rc4 is available: https://packages.gitlab.com/gitlab/unstable
Use at your own risk. Please link regressions issues from
LINK_TO_REGRESSION_ISSUE
```
#### RC5
- [x] Cherry-pick merge requests labeled [`Picked into Stable`] for the current
milestone (you can take advantage of the
[`Picked into Stable` 8.16 merged merge requests] page) into
the CE `8-16-stable` and EE `8-16-stable-ee`
branches, respectively
- Follow the [Creating subsequent RCs] guide for `8.16.0-rc5` (**be sure to use the correct RC number**):
- [x] Merge CE `8-16-stable` into EE `8-16-stable-ee` following the [Merging a CE stable branch into its EE counterpart] guide
- [x] Check for any problematic migrations in EE (EE migrations include CE ones), and paste the diff in a snippet: `git diff v8.16.0-rc4-ee..8-16-stable-ee -- db/migrate` => https://gitlab.com/gitlab-org/gitlab-ce/snippets/35857
- [x] Sync CE, EE, and Omnibus to `dev`
- [x] Ensure [tests are green on CE]
- [x] Ensure [tests are green on EE]
- [x] In `#releases`: I'm going to tag `8.16.0-rc5`
- [x] Tag the `8.16.0-rc5` version using the [`release` task]:
```sh
bundle exec rake "release[8.16.0-rc5]"
```
- [x] Check that [EE packages are built], [CE packages are built] and appears on `packages.gitlab.com`: [EE & CE](https://packages.gitlab.com/app/gitlab/unstable/search?q=8.16.0-rc5)
- [x] In `#infrastructure`: I'm going to deploy `8.16.0-rc5` to staging
- [ ] Deploy [`8.16.0-rc5`](https://packages.gitlab.com/gitlab/unstable/packages/ubuntu/xenial/gitlab-ee_8.16.0-rc5.ee.0_amd64.deb) to [staging.gitlab.com]
- [ ] In `#infrastructure`: I'm going to deploy `8.16.0-rc5` to production
- [ ] Deploy [`8.16.0-rc5`](https://packages.gitlab.com/gitlab/unstable/packages/ubuntu/xenial/gitlab-ee_8.16.0-rc5.ee.0_amd64.deb) to [GitLab.com]
- [ ] Tweet about the `8.16.0-rc5` release:
```
GitLab 8.16.0-rc5 is available: https://packages.gitlab.com/gitlab/unstable
Use at your own risk. Please link regressions issues from
LINK_TO_REGRESSION_ISSUE
```
#### RC6
- [x] Cherry-pick merge requests labeled [`Picked into Stable`] for the current
milestone (you can take advantage of the
[`Picked into Stable` 8.16 merged merge requests] page) into
the CE `8-16-stable` and EE `8-16-stable-ee`
branches, respectively
- Follow the [Creating subsequent RCs] guide for `8.16.0-rc6` (**be sure to use the correct RC number**):
- [x] Merge CE `8-16-stable` into EE `8-16-stable-ee` following the [Merging a CE stable branch into its EE counterpart] guide
- [x] Check for any problematic migrations in EE (EE migrations include CE ones), and paste the diff in a snippet: `git diff v8.16.0-rc5-ee..8-16-stable-ee -- db/migrate` =>
- [x] Sync CE, EE, and Omnibus to `dev`
- [x] Ensure [tests are green on CE]
- [x] Ensure [tests are green on EE]
- [x] In `#releases`: I'm going to tag `8.16.0-rc6`
- [x] Tag the `8.16.0-rc6` version using the [`release` task]:
```sh
bundle exec rake "release[8.16.0-rc6]"
```
- [x] Check that [EE packages are built], [CE packages are built] and appears on `packages.gitlab.com`: [EE & CE](https://packages.gitlab.com/app/gitlab/unstable/search?q=8.16.0-rc6)
- [x] In `#infrastructure`: I'm going to deploy `8.16.0-rc6` to staging
- [x] Deploy [`8.16.0-rc6`](https://packages.gitlab.com/gitlab/unstable/packages/ubuntu/xenial/gitlab-ee_8.16.0-rc6.ee.0_amd64.deb) to [staging.gitlab.com]
- [x] In `#infrastructure`: I'm going to deploy `8.16.0-rc6` to production
- [x] Deploy [`8.16.0-rc6`](https://packages.gitlab.com/gitlab/unstable/packages/ubuntu/xenial/gitlab-ee_8.16.0-rc6.ee.0_amd64.deb) to [GitLab.com]
- [ ] Tweet about the `8.16.0-rc6` release:
```
GitLab 8.16.0-rc6 is available: https://packages.gitlab.com/gitlab/unstable
Use at your own risk. Please link regressions issues from
LINK_TO_REGRESSION_ISSUE
```
### 12th: (7 working days before the 22nd)
- [ ] Determine QA person and notify this person: MENTION_THIS_PERSON_HERE
- [ ] Do QA and fix anything coming out of it: LINK_TO_QA_ISSUE
### Anytime between 18th (3 working days before the 22nd) and 20th (1 working day before the 22nd)
- [x] In `#core`:
```
@developers
TL;DR: Ensure the `8.16.0` milestone and the `Pick into Stable` label are set, no need to ping me.
From now on, please follow the "Change for stable release" process:
https://gitlab.com/gitlab-org/gitlab-ce/blob/master/CONTRIBUTING.md#changes-for-stable-releases
```
**Copy-paste the tasks below for any other RCs (be sure to update the RC number).**
```
#### RC3
- [ ] Cherry-pick merge requests labeled [`Picked into Stable`] for the current
milestone (you can take advantage of the
[`Picked into Stable` 8.16 merged merge requests] page) into
the CE `8-16-stable` and EE `8-16-stable-ee`
branches, respectively
- Follow the [Creating subsequent RCs] guide for `8.16.0-rc3` (**be sure to use the correct RC number**):
- [ ] Merge CE `8-16-stable` into EE `8-16-stable-ee` following the [Merging a CE stable branch into its EE counterpart] guide
- [x] Check for any problematic migrations in EE (EE migrations include CE ones), and paste the diff in a snippet: `git diff v8.16.0-rc2-ee..8-16-stable-ee -- db/migrate` =>
- [x] Sync CE, EE, and Omnibus to `dev`
- [x] Ensure [tests are green on CE]
- [x] Ensure [tests are green on EE]
- [x] In `#releases`: I'm going to tag `8.16.0-rc3`
- [ ] Tag the `8.16.0-rc3` version using the [`release` task]:
```sh
bundle exec rake "release[8.16.0-rc3]"
```
- [ ] Check that [EE packages are built], [CE packages are built] and appears on `packages.gitlab.com`: [EE & CE](https://packages.gitlab.com/app/gitlab/unstable/search?q=8.16.0-rc3)
- [ ] In `#infrastructure`: I'm going to deploy `8.16.0-rc3` to staging
- [ ] Deploy [`8.16.0-rc3`](https://packages.gitlab.com/gitlab/unstable/packages/ubuntu/xenial/gitlab-ee_8.16.0-rc3.ee.0_amd64.deb) to [staging.gitlab.com]
- [ ] In `#infrastructure`: I'm going to deploy `8.16.0-rc3` to production
- [ ] Deploy [`8.16.0-rc3`](https://packages.gitlab.com/gitlab/unstable/packages/ubuntu/xenial/gitlab-ee_8.16.0-rc3.ee.0_amd64.deb) to [GitLab.com]
- [ ] Tweet about the `8.16.0-rc3` release:
```
GitLab 8.16.0-rc3 is available: https://packages.gitlab.com/gitlab/unstable
Use at your own risk. Please link regressions issues from
LINK_TO_REGRESSION_ISSUE
```
```
### 18th: (3 working days before the 22nd)
- [x] Check that everyone is mentioned on the [blog post] using `@all`:
```
Hello @all, this is the monthly release post that will go out on the 22nd,
announcing the new GitLab version. Look through it to see if we can make any
changes and feel free to comment with suggestions or questions!
```
or, if the blog post is still very much a work in progress:
```
Hello @all, this is the merge request for the monthly release post that will
go out on the 22nd, announcing the new GitLab version. Right now it's all
boilerplate, but feel free to remind us about things that shouldn't be left
out!
```
### 19th: (2 working days before the 22nd)
- [x] Ask in `#core` for suggestions about who should be this release's MVP.
Once chosen, add them to the [blog post] and to the [MVP page], in the
same merge request
### 20th: (1 working day before the 22nd)
Ideally, the last RC should be released no later than this day and should point
to the same commit as the final release.
### 22nd before 1900 CET:
- Before 0800 PDT / 1700 CET:
- [x] Cherry-pick merge requests labeled [`Picked into Stable`] for the current
milestone (you can take advantage of the
[`Picked into Stable` 8.16 merged merge requests] page) into
the CE `8-16-stable` and EE `8-16-stable-ee`
branches, respectively
- [x] Merge CE `8-16-stable` into EE `8-16-stable-ee` following the [Merging a CE stable branch into its EE counterpart] guide
- [x] Check for any problematic migrations in EE (EE migrations include CE ones), and paste the diff in a snippet: `git diff v8.16.0-rc3-ee..8-16-stable-ee -- db/migrate` => https://gitlab.com/gitlab-org/gitlab-ce/snippets/36456
- [x] Sync CE, EE, and Omnibus to `dev`
- [x] Ensure [tests are green on CE]
- [x] Ensure [tests are green on EE]
- [x] In `#releases`: I'm going to tag `8.16.0`
- [x] Tag the `8.16.0` version using the [`release` task]:
```sh
bundle exec rake "release[8.16.0]"
```
- [x] Check that [EE packages are built], [CE packages are built] and appears on `packages.gitlab.com`: [EE](https://packages.gitlab.com/app/gitlab/gitlab-ee/search?q=8.16.0) / [CE](https://packages.gitlab.com/app/gitlab/gitlab-ce/search?q=8.16.0)
- [ ] Update the version in the `VERSION` file to `8.17.0-pre` and create the `v8.17.0.pre` tag: (doing this on the 23rd)
```sh
echo "8.17.0-pre" > VERSION
git add VERSION && git ci # ci = commit --gpg-sign --signoff --verbose
git pdog # pdog = push dev,origin,github
git tag -s v8.17.0.pre -m "Update VERSION to 8.17.0.pre"
git pdog v8.17.0.pre:v8.17.0.pre
```
- Before 0900 PDT / 1800 CET:
- [x] In `#infrastructure`: I'm going to deploy `8.16.0` to staging
- [x] Deploy [`8.16.0`](https://packages.gitlab.com/gitlab/gitlab-ee/packages/ubuntu/xenial/gitlab-ee_8.16.0-ee.0_amd64.deb) to [staging.gitlab.com]
- [x] In `#infrastructure`: I'm going to deploy `8.16.0` to production
- [x] Deploy [`8.16.0`](https://packages.gitlab.com/gitlab/gitlab-ee/packages/ubuntu/xenial/gitlab-ee_8.16.0-ee.0_amd64.deb) to [GitLab.com]
- [x] Create the `8.16.0` version on https://version.gitlab.com
- [x] Create the first patch issue using the [`patch_issue` task]:
```sh
bundle exec rake "patch_issue[8.16.1]"
```
- At 1000 PDT / 1900 CET:
- [x] Publish the release [blog post]
- [x] Ensure someone tweets about the `8.16.0` release
[regression issue]: LINK_TO_REGRESSION_ISSUE
[blog post]: LINK_TO_WIP_BLOG_POST
[Creating RC1]: https://gitlab.com/gitlab-org/release-tools/blob/master/doc/release-candidates.md#creating-rc1
[tests are green on CE]: https://dev.gitlab.org/gitlab/gitlabhq/commits/8-16-stable
[tests are green on EE]: https://dev.gitlab.org/gitlab/gitlab-ee/commits/8-16-stable-ee
[EE packages are built]: https://dev.gitlab.org/gitlab/omnibus-gitlab/commits/8-16-stable-ee
[CE packages are built]: https://dev.gitlab.org/gitlab/omnibus-gitlab/commits/8-16-stable
[`gitlab/unstable`]: https://packages.gitlab.com/gitlab/unstable
[`new_release_post` task]: https://gitlab.com/gitlab-com/www-gitlab-com/#create-release-blog-post
[`www-gitlab-com` project]: https://gitlab.com/gitlab-com/www-gitlab-com/
[`gitlab/gitlab-ee`]: https://packages.gitlab.com/gitlab/gitlab-ee
[`gitlab/gitlab-ce`]: https://packages.gitlab.com/gitlab/gitlab-ce
[Sync CE, EE, and Omnibus to `dev`]: https://gitlab.com/gitlab-org/release-tools/blob/master/doc/pro-tips.md#add-a-git-pdo-and-a-git-pdog-aliases
[Creating subsequent RCs]: https://gitlab.com/gitlab-org/release-tools/blob/master/doc/release-candidates.md#creating-subsequent-rcs
[GitLab CE into EE]: https://gitlab.com/gitlab-org/release-tools/blob/master/doc/merge-ce-into-ee.md#merging-ce-master-into-ee-master
[Merging a CE stable branch into its EE counterpart]: https://gitlab.com/gitlab-org/release-tools/blob/master/doc/merge-ce-into-ee.md#merging-a-ce-stable-branch-into-its-ee-counterpart
[`Picked into Stable`]: https://gitlab.com/gitlab-org/gitlab-ce/blob/master/CONTRIBUTING.md#changes-for-stable-releases
[`release` task]: https://gitlab.com/gitlab-org/release-tools/blob/master/doc%2Frake-tasks.md#releaseversion
[`patch_issue` task]: https://gitlab.com/gitlab-org/release-tools/blob/master/doc%2Frake-tasks.md#patch_issueversion
[`regression_issue` task]: https://gitlab.com/gitlab-org/release-tools/blob/master/doc%2Frake-tasks.md#regression_issueversion
[MVP page]: https://gitlab.com/gitlab-com/www-gitlab-com/blob/master/source/mvp/index.html
[`Picked into Stable` 8.16 merged merge requests]: https://gitlab.com/groups/gitlab-org/merge_requests?label_name%5B%5D=Pick+into+Stable&milestone_title=8.16&scope=all&sort=id_desc&state=merged
[staging.gitlab.com]: https://dev.gitlab.org/cookbooks/chef-repo/blob/master/doc/staging.md
[GitLab.com]: https://dev.gitlab.org/cookbooks/chef-repo/blob/master/doc/deploying.md8.16James LopezJames Lopezhttps://gitlab.com/gitlab-org/gitlab-foss/-/issues/26242HackerOne reported issue: Export files not renamed when a user changes the na...2017-10-10T10:11:06ZBrian NeelHackerOne reported issue: Export files not renamed when a user changes the namespaceJobert from HackerOne reported this issue: https://hackerone.com/reports/195058
## Vulnerability details
When a user renames its namespace, another user can claim the namespace and download old export files from the victim. The att...Jobert from HackerOne reported this issue: https://hackerone.com/reports/195058
## Vulnerability details
When a user renames its namespace, another user can claim the namespace and download old export files from the victim. The attack scenario here is that someone would scrape existing GitLab namespaces (users and groups, which are public) and see if they're renamed (freeing up the old namespace). The attacker can then claim the namespace the victim's old export files.
### Impact
This may expose confidential project information, including the repository code, merge requests, issues, and snippets.
### Proof of concept
Follow the steps below to reproduce the vulnerability.
**As the victim**
* Create a group called test
* Create a new private project in the test group called test
* Click the Generate export button in the project's settings page
* Now rename the group to new-test
**As the attacker**
* Create a group called test (this is possible because the old group was renamed to new-test)
* Create a new private project in the test group called test
* Go to http://gitlab-instance/test/test/download_export
* Profit! The attacker will download the export file generated by the victim
### Remediation
Expire download links when the namespace OR project URL changes. This vulnerability also applies when changing the project URL, although that is less severe. This might grant users access to private repositories, although far less likely than the PoC outlined in this report.
He also wishes @DouweM a happy birthday. :)8.16James LopezJames Lopezhttps://gitlab.com/gitlab-org/gitlab-foss/-/issues/25890Cross-project references copy no longer works2019-08-07T08:44:01ZStan HuCross-project references copy no longer worksI was used to being able to copy a cross-project reference such as the following:
![image](/uploads/eddeacef45cf1c0bf06db17fb989eaee/image.png)
But now it omits the reference and only includes the issue number. Was there a reason we ch...I was used to being able to copy a cross-project reference such as the following:
![image](/uploads/eddeacef45cf1c0bf06db17fb989eaee/image.png)
But now it omits the reference and only includes the issue number. Was there a reason we changed this?8.16James LopezJames Lopezhttps://gitlab.com/gitlab-org/gitlab-foss/-/issues/25346import_export incorrectly assigns importer as commenter when admin2019-09-11T11:29:18ZWilliam Georgeimport_export incorrectly assigns importer as commenter when admin### Summary
When using gitlab's import/export feature as an admin, the importers name is appearing as the comment author when it should be the original author.
### Steps to reproduce
- Export a project that contains comments.
- Import...### Summary
When using gitlab's import/export feature as an admin, the importers name is appearing as the comment author when it should be the original author.
### Steps to reproduce
- Export a project that contains comments.
- Import the project into a new gitlab instance.
- All the comments are assigned to the importer.
### Expected behavior
The comments should be assigned to the member that originally created the comment.
### Actual behavior
The comment is assigned to the importer
#### Results of GitLab environment info
I'm afraid I can not run these commands, but both instances are running: GitLab Enterprise Edition 8.13.5-ee 94cc667
### Possible fixes
Interestingly if you goto the member's profile that originally created comment. It does appear on their activity feed that they have commented. When you click through, it highlights the comment, but still has the importers name.
![Bug](/uploads/e8da60de2d1de5fa144400d550aa1b0e/Bug.png)8.16James LopezJames Lopezhttps://gitlab.com/gitlab-org/gitlab-foss/-/issues/19124Sidekiq appears to kill big export jobs2017-08-04T21:43:42ZJames LopezSidekiq appears to kill big export jobsSome big export jobs never finish and they seem to be killed, possibly by Sidekiq. An example is trying to export CE repo in gitlab.com
Relevant part of the log:
```ruby
WARN: Work still in progress [<struct Sidekiq::BasicFetch::U...Some big export jobs never finish and they seem to be killed, possibly by Sidekiq. An example is trying to export CE repo in gitlab.com
Relevant part of the log:
```ruby
WARN: Work still in progress [<struct Sidekiq::BasicFetch::UnitOfWork queue="queue:gitlab_shell", job="{\"class\":\"ProjectExportWorker\",\"args\":[ID1,ID2],\"retry\":true,\"queue\":\"gitlab_shell\",\"jid\":\"a9c309ac09b5c688f24c56eb\",\"created_at\":1466687806.3562632,\"enqueued_at\":1466687806.3563974}">
```
We may have the same problem trying to import a big file.8.16James LopezJames Lopezhttps://gitlab.com/gitlab-org/gitlab-foss/-/issues/17235Project queued for deletion is not obvious and leads to confusion when re-cre...2017-08-04T21:44:40ZDrew BlessingProject queued for deletion is not obvious and leads to confusion when re-creatingZendesk issue: https://gitlab.zendesk.com/agent/tickets/22125
Also, we see this report in the support forum quite often, too.
If a user deletes a project with the intention of immediately re-creating it, it's not clear that the pro...Zendesk issue: https://gitlab.zendesk.com/agent/tickets/22125
Also, we see this report in the support forum quite often, too.
If a user deletes a project with the intention of immediately re-creating it, it's not clear that the project is actually queued for deletion and not immediately deleted. As a result, users often see an error that the project name has already been taken. Is there a way we can give the user a nicer error message saying that the project is still being deleted and to try again later?
cc/ @jameslopez 8.16James LopezJames Lopez