1. 24 Oct, 2019 1 commit
    • Bob Van Landuyt's avatar
      Only assign merge params when allowed · 20cb4f7a
      Bob Van Landuyt authored
      When a user updates a merge request coming from a fork, they should
      not be able to set `force_remove_source_branch` if they cannot push
      code to the source project.
      
      Otherwise developers of the target project could remove the source
      branch of the source project by setting this flag through the API.
      20cb4f7a
  2. 23 Oct, 2019 1 commit
  3. 18 Sep, 2019 1 commit
  4. 13 Sep, 2019 1 commit
  5. 10 Sep, 2019 1 commit
  6. 04 Sep, 2019 1 commit
    • Christian Couder's avatar
      Support adding and removing labels w/ push opts · f00db0c3
      Christian Couder authored
      MergeRequests::PushOptionsHandlerService has been updated to allow
      adding and removing labels to a merge request using git push options.
      
      To create a new merge request and add 2 labels to it:
      
            git push -u origin -o merge_request.create \
              -o merge_request.label="My label 1" \
              -o merge_request.label="My label 2"
      
      To update an existing merge request and remove a label while
      adding a different label:
      
            git push -u origin -o merge_request.label="My added label" \
              -o merge_request.unlabel="My removed label"
      
      Issue https://gitlab.com/gitlab-org/gitlab-ce/issues/64320
      f00db0c3
  7. 17 Jul, 2019 1 commit
    • Bob Van Landuyt's avatar
      Filter params in MR build service · 6c27c0d3
      Bob Van Landuyt authored
      Reusing the existing `IssuableBaseService#filter_params` which uses
      the policies to determine what params a user can set, and which values
      it can be set to.
      
      This also removed the need for the seperate call to
      `IssuableBaseService#ensure_milestone_available`.
      
      The `Issues::BuildService` does not suffer from this because it limits
      the params that are assignable to the `title`, `description` and
      `milestone_id`.
      6c27c0d3
  8. 14 Feb, 2019 1 commit
    • Jarka Košanová's avatar
      Check issue milestone availability · 30ab6ee4
      Jarka Košanová authored
      Add project when creating milestone in specs
      
      We validate milestone is from the same
      project/parent group as issuable ->
      we need to set project in specs correctly
      
      Improve methods names and specs organization
      30ab6ee4
  9. 14 Dec, 2018 1 commit
    • Bob Van Landuyt's avatar
      Validate projects in MR build service · 08dbd93b
      Bob Van Landuyt authored
      This validates the correct abilities for both projects. Only
      `read_project` isn't enough:
      
      For the `source_project` we validate `create_merge_request_from` this
      also validates that the user has developer access to the project.
      
      For the `target_project` we validate `create_merge_reqeust_in` this
      also validates that the user has access to the project's repository.
      
      To avoid generating diffs for unrelated projects we also validate that
      the projects are in the same fork network now.
      08dbd93b
  10. 21 Nov, 2018 1 commit
  11. 07 Nov, 2018 2 commits
    • Bob Van Landuyt's avatar
      Allow limiting quick actions to execute · c85a19f9
      Bob Van Landuyt authored
      Sometimes we don't want to trigger any quick actions that cause side
      effects. For example when building a record to validate. This allows
      listing the quick actions that need to be performed.
      c85a19f9
    • Bob Van Landuyt's avatar
      Apply patches when creating MR via email · 6fbdc5ed
      Bob Van Landuyt authored
      This allows users to add patches as attachments to merge request
      created via email.
      
      When an email to create a merge request is sent, all the attachments
      ending in `.patch` will be applied to the branch specified in the
      subject of the email. If the branch did not exist, it will be created
      from the HEAD of the repository.
      
      When the patches could not be applied, the error message will be
      replied to the user.
      
      The patches can have a maximum combined size of 2MB for now.
      6fbdc5ed
  12. 06 Sep, 2018 1 commit
  13. 25 Aug, 2018 3 commits
  14. 17 Jul, 2018 1 commit
  15. 07 Mar, 2018 1 commit
  16. 14 Feb, 2018 1 commit
  17. 13 Feb, 2018 1 commit
  18. 02 Feb, 2018 1 commit
  19. 10 Jan, 2018 1 commit
  20. 09 Jan, 2018 1 commit
  21. 05 Dec, 2017 1 commit
    • Jan Provaznik's avatar
      Create merge request from email · 8cce7073
      Jan Provaznik authored
      * new merge request can be created by sending an email to the specific
      email address (similar to creating issues by email)
      * for the first iteration, source branch must be specified in the mail
      subject, other merge request parameters can not be set yet
      * user should enable "Receive notifications about your own activity" in
      user settings to receive a notification about created merge request
      
      Part of #32878
      8cce7073
  22. 28 Nov, 2017 1 commit
    • Sean McGivern's avatar
      Ensure MRs always use branch refs for comparison · 3c6a4d63
      Sean McGivern authored
      If a merge request was created with a branch name that also matched a tag name,
      we'd generate a comparison to or from the tag respectively, rather than the
      branch. Merging would still use the branch, of course.
      
      To avoid this, ensure that when we get the branch heads, we prepend the
      reference prefix for branches, which will ensure that we generate the correct
      comparison.
      3c6a4d63
  23. 25 Nov, 2017 1 commit
  24. 16 Nov, 2017 1 commit
  25. 26 Apr, 2017 1 commit
  26. 06 Apr, 2017 1 commit
  27. 17 Mar, 2017 1 commit
  28. 21 Feb, 2017 1 commit
  29. 31 Jan, 2017 1 commit
    • Maxim Rydkin's avatar
      refactor merge request build service · 14326c88
      Maxim Rydkin authored
      add changelog entry
      
      replace local variables `merge_request` with instance ones
      
      modify `MergeRequests::BuildService` to fix failed tests
      
      extract `assign_target_project` method
      
      remove unnecessary instance variables
      
      remove exclamation marks and rewrite conditionals to improve readability
      
      extract `params_does_not_contain_branches?` method, rename `unprepared_merge_request` method to `uncreatable_merge_request`
      
      replace instance variables `merge_request` and `error_messages` with getters and setters; divide `set_title_and_description` method on two separate ones
      
      refactor `execute` method
      
      return `set_title_and_description` method
      
      rename `branches_selected?` method to `branches_present?` to make it more different from `branches_specified?`
      
      fixes after discussion
      
      renamed method branches_valid?
      
      fix space
      
      return assigning methods into `execute` method
      
      simplify `find_target_branch` and `find_source_project` methods
      
      fix spec `merge request issuable record that supports slash commands in its description and notes`
      14326c88
  30. 16 Dec, 2016 1 commit
  31. 08 Dec, 2016 1 commit
  32. 29 Nov, 2016 1 commit
  33. 19 Nov, 2016 1 commit
  34. 01 Nov, 2016 1 commit
  35. 11 Oct, 2016 1 commit
  36. 01 Sep, 2016 1 commit
  37. 03 Aug, 2016 1 commit