1. 29 Aug, 2018 5 commits
  2. 25 Aug, 2018 1 commit
    • Bob Van Landuyt's avatar
      Reject ruby interpolation in externalized strings · 08c0a1b8
      Bob Van Landuyt authored
      When using ruby interpolation in externalized strings, they can't be
      detected. Which means they will never be presented to be translated.
      
      To mix variables into translations we need to use `sprintf`
      instead.
      
      Instead of:
      
          _("Hello #{subject}")
      
      Use:
      
          _("Hello %{subject}) % { subject: 'world' }
      08c0a1b8
  3. 16 Aug, 2018 1 commit
  4. 08 Aug, 2018 1 commit
  5. 09 Jul, 2018 1 commit
  6. 22 Jun, 2018 1 commit
  7. 20 Jun, 2018 1 commit
    • Bob Van Landuyt's avatar
      Add a cop for `FinderMethods` · f3f1df14
      Bob Van Landuyt authored
      This notifies developers when calling `find(_by!)` chained on
      `execute`. And suggests using the methods from `FinderMethods`. These
      will perform the correct authorization checks on the resource when it
      is found.
      f3f1df14
  8. 19 Jun, 2018 1 commit
    • Sean McGivern's avatar
      Disallow methods that copy data on large tables · eb086a4b
      Sean McGivern authored
      {change_column_type,rename_column}_concurrently both copy data from one column
      to another during a migration, which should not be done on GitLab.com. Instead,
      we should use background migrations.
      eb086a4b
  9. 29 May, 2018 1 commit
  10. 23 Apr, 2018 1 commit
  11. 18 Apr, 2018 2 commits
  12. 09 Apr, 2018 1 commit
  13. 06 Apr, 2018 1 commit
  14. 21 Mar, 2018 1 commit
  15. 08 Mar, 2018 1 commit
  16. 31 Jan, 2018 1 commit
  17. 12 Jan, 2018 1 commit
  18. 11 Jan, 2018 1 commit
  19. 26 Dec, 2017 1 commit
  20. 22 Dec, 2017 1 commit
  21. 13 Dec, 2017 1 commit
  22. 11 Dec, 2017 1 commit
    • Sean McGivern's avatar
      Add cop for use of remove_column · 1ab33b15
      Sean McGivern authored
      remove_column should only be used in the up (or change) step of a migration if
      it's a post-deployment migration. Otherwise there will be downtime due to the
      ActiveRecord column cache, which we can avoid by using the IgnorableColumn
      concern in combination with a post-deployment migration.
      1ab33b15
  23. 22 Nov, 2017 2 commits
  24. 21 Nov, 2017 1 commit
  25. 17 Nov, 2017 3 commits
  26. 16 Nov, 2017 1 commit
  27. 21 Oct, 2017 1 commit
  28. 18 Oct, 2017 1 commit
  29. 10 Oct, 2017 1 commit
  30. 07 Oct, 2017 1 commit
    • jacopo's avatar
      Replaces `tag: true` into `:tag` in the specs · 0ce67858
      jacopo authored
      Replaces all the explicit include metadata syntax in the specs (tag:
      true) into the implicit one (:tag).
      Added a cop to prevent future errors and handle autocorrection.
      0ce67858
  31. 18 Sep, 2017 2 commits