1. 14 Feb, 2019 1 commit
    • Jarka Košanová's avatar
      Check issue milestone availability · 30ab6ee4
      Jarka Košanová authored
      Add project when creating milestone in specs
      
      We validate milestone is from the same
      project/parent group as issuable ->
      we need to set project in specs correctly
      
      Improve methods names and specs organization
      30ab6ee4
  2. 14 Dec, 2018 1 commit
    • Bob Van Landuyt's avatar
      Validate projects in MR build service · 08dbd93b
      Bob Van Landuyt authored
      This validates the correct abilities for both projects. Only
      `read_project` isn't enough:
      
      For the `source_project` we validate `create_merge_request_from` this
      also validates that the user has developer access to the project.
      
      For the `target_project` we validate `create_merge_reqeust_in` this
      also validates that the user has access to the project's repository.
      
      To avoid generating diffs for unrelated projects we also validate that
      the projects are in the same fork network now.
      08dbd93b
  3. 21 Nov, 2018 1 commit
  4. 07 Nov, 2018 2 commits
    • Bob Van Landuyt's avatar
      Allow limiting quick actions to execute · c85a19f9
      Bob Van Landuyt authored
      Sometimes we don't want to trigger any quick actions that cause side
      effects. For example when building a record to validate. This allows
      listing the quick actions that need to be performed.
      c85a19f9
    • Bob Van Landuyt's avatar
      Apply patches when creating MR via email · 6fbdc5ed
      Bob Van Landuyt authored
      This allows users to add patches as attachments to merge request
      created via email.
      
      When an email to create a merge request is sent, all the attachments
      ending in `.patch` will be applied to the branch specified in the
      subject of the email. If the branch did not exist, it will be created
      from the HEAD of the repository.
      
      When the patches could not be applied, the error message will be
      replied to the user.
      
      The patches can have a maximum combined size of 2MB for now.
      6fbdc5ed
  5. 06 Sep, 2018 1 commit
  6. 25 Aug, 2018 3 commits
  7. 17 Jul, 2018 1 commit
  8. 07 Mar, 2018 1 commit
  9. 14 Feb, 2018 1 commit
  10. 13 Feb, 2018 1 commit
  11. 02 Feb, 2018 1 commit
  12. 10 Jan, 2018 1 commit
  13. 09 Jan, 2018 1 commit
  14. 05 Dec, 2017 1 commit
    • Jan Provaznik's avatar
      Create merge request from email · 8cce7073
      Jan Provaznik authored
      * new merge request can be created by sending an email to the specific
      email address (similar to creating issues by email)
      * for the first iteration, source branch must be specified in the mail
      subject, other merge request parameters can not be set yet
      * user should enable "Receive notifications about your own activity" in
      user settings to receive a notification about created merge request
      
      Part of #32878
      8cce7073
  15. 28 Nov, 2017 1 commit
    • Sean McGivern's avatar
      Ensure MRs always use branch refs for comparison · 3c6a4d63
      Sean McGivern authored
      If a merge request was created with a branch name that also matched a tag name,
      we'd generate a comparison to or from the tag respectively, rather than the
      branch. Merging would still use the branch, of course.
      
      To avoid this, ensure that when we get the branch heads, we prepend the
      reference prefix for branches, which will ensure that we generate the correct
      comparison.
      3c6a4d63
  16. 25 Nov, 2017 1 commit
  17. 16 Nov, 2017 1 commit
  18. 26 Apr, 2017 1 commit
  19. 06 Apr, 2017 1 commit
  20. 17 Mar, 2017 1 commit
  21. 21 Feb, 2017 1 commit
  22. 31 Jan, 2017 1 commit
    • Maxim Rydkin's avatar
      refactor merge request build service · 14326c88
      Maxim Rydkin authored
      add changelog entry
      
      replace local variables `merge_request` with instance ones
      
      modify `MergeRequests::BuildService` to fix failed tests
      
      extract `assign_target_project` method
      
      remove unnecessary instance variables
      
      remove exclamation marks and rewrite conditionals to improve readability
      
      extract `params_does_not_contain_branches?` method, rename `unprepared_merge_request` method to `uncreatable_merge_request`
      
      replace instance variables `merge_request` and `error_messages` with getters and setters; divide `set_title_and_description` method on two separate ones
      
      refactor `execute` method
      
      return `set_title_and_description` method
      
      rename `branches_selected?` method to `branches_present?` to make it more different from `branches_specified?`
      
      fixes after discussion
      
      renamed method branches_valid?
      
      fix space
      
      return assigning methods into `execute` method
      
      simplify `find_target_branch` and `find_source_project` methods
      
      fix spec `merge request issuable record that supports slash commands in its description and notes`
      14326c88
  23. 16 Dec, 2016 1 commit
  24. 08 Dec, 2016 1 commit
  25. 29 Nov, 2016 1 commit
  26. 19 Nov, 2016 1 commit
    • Alex Sanford's avatar
      Fix regression in Merge request form · 16a8d644
      Alex Sanford authored
      Merge request !7163 caused an error message to appear on the Merge
      Request form when it was first loaded by the user. This commit fixes
      that regression bug.
      16a8d644
  27. 01 Nov, 2016 1 commit
  28. 11 Oct, 2016 1 commit
  29. 01 Sep, 2016 1 commit
  30. 03 Aug, 2016 1 commit
  31. 21 Jun, 2016 1 commit
    • Sean McGivern's avatar
      Fix auto-MR-close text from branch name · b2f60bb9
      Sean McGivern authored
      Rails's form helpers use the `$attr_before_type_cast` method where
      available, and this value only appears to be updated on assignment, not
      when the object is mutated in some other way:
      
          [1] pry(main)> mr = MergeRequest.new
          => #<MergeRequest:0x007fcf28395d88 ...>
          [2] pry(main)> mr.description = 'foo'
          => "foo"
          [3] pry(main)> mr.description << ' bar'
          => "foo bar"
          [4] pry(main)> mr.description
          => "foo bar"
          [5] pry(main)> mr.description_before_type_cast
          => "foo"
          [6] pry(main)> mr.description += ' bar'
          => "foo bar bar"
          [7] pry(main)> mr.description_before_type_cast
          => "foo bar bar"
      b2f60bb9
  32. 03 Jun, 2016 2 commits
  33. 13 May, 2016 1 commit
  34. 06 May, 2016 2 commits
  35. 25 Apr, 2016 1 commit