Commit bee5c080 authored by Kamil Trzciński's avatar Kamil Trzciński

Fix Rubocop failures

parent 54831bd4
...@@ -60,12 +60,12 @@ class Projects::ClustersController < Projects::ApplicationController ...@@ -60,12 +60,12 @@ class Projects::ClustersController < Projects::ApplicationController
.new(project, current_user, cluster_params) .new(project, current_user, cluster_params)
.execute(cluster) .execute(cluster)
if cluster.valid? if cluster.valid?
flash[:notice] = "Cluster was successfully updated." flash[:notice] = "Cluster was successfully updated."
redirect_to project_cluster_path(project, project.cluster) redirect_to project_cluster_path(project, project.cluster)
else else
render :show render :show
end end
end end
def destroy def destroy
......
...@@ -31,5 +31,4 @@ describe Projects::ClustersController, '(JavaScript fixtures)', type: :controlle ...@@ -31,5 +31,4 @@ describe Projects::ClustersController, '(JavaScript fixtures)', type: :controlle
expect(response).to be_success expect(response).to be_success
store_frontend_fixture(response, example.description) store_frontend_fixture(response, example.description)
end end
end end
...@@ -34,7 +34,7 @@ describe Gcp::Cluster do ...@@ -34,7 +34,7 @@ describe Gcp::Cluster do
end end
context 'when too long' do context 'when too long' do
let(:gcp_project_id) { 'A'*64 } let(:gcp_project_id) { 'A' * 64 }
it { is_expected.to be_falsey } it { is_expected.to be_falsey }
end end
...@@ -62,7 +62,7 @@ describe Gcp::Cluster do ...@@ -62,7 +62,7 @@ describe Gcp::Cluster do
end end
context 'when too long' do context 'when too long' do
let(:gcp_cluster_name) { 'A'*64 } let(:gcp_cluster_name) { 'A' * 64 }
it { is_expected.to be_falsey } it { is_expected.to be_falsey }
end end
...@@ -106,7 +106,7 @@ describe Gcp::Cluster do ...@@ -106,7 +106,7 @@ describe Gcp::Cluster do
end end
context 'when too long' do context 'when too long' do
let(:project_namespace) { 'A'*64 } let(:project_namespace) { 'A' * 64 }
it { is_expected.to be_falsey } it { is_expected.to be_falsey }
end end
......
...@@ -13,7 +13,7 @@ describe Ci::CreateClusterService do ...@@ -13,7 +13,7 @@ describe Ci::CreateClusterService do
gcp_project_id: 'gcp-project', gcp_project_id: 'gcp-project',
gcp_cluster_name: 'test-cluster', gcp_cluster_name: 'test-cluster',
gcp_cluster_zone: 'us-central1-a', gcp_cluster_zone: 'us-central1-a',
gcp_cluster_size: 1, gcp_cluster_size: 1
} }
end end
...@@ -34,7 +34,7 @@ describe Ci::CreateClusterService do ...@@ -34,7 +34,7 @@ describe Ci::CreateClusterService do
gcp_project_id: 'gcp-project', gcp_project_id: 'gcp-project',
gcp_cluster_name: 'test-cluster', gcp_cluster_name: 'test-cluster',
gcp_cluster_zone: 'us-central1-a', gcp_cluster_zone: 'us-central1-a',
gcp_cluster_size: 'ABC', gcp_cluster_size: 'ABC'
} }
end end
......
...@@ -8,7 +8,7 @@ describe WaitForClusterCreationWorker do ...@@ -8,7 +8,7 @@ describe WaitForClusterCreationWorker do
before do before do
allow(operation).to receive(:status).and_return(status) allow(operation).to receive(:status).and_return(status)
allow(operation).to receive(:start_time).and_return(1.minutes.ago) allow(operation).to receive(:start_time).and_return(1.minute.ago)
allow(operation).to receive(:status_message).and_return('error') allow(operation).to receive(:status_message).and_return('error')
allow_any_instance_of(Ci::FetchGcpOperationService).to receive(:execute).and_yield(operation) allow_any_instance_of(Ci::FetchGcpOperationService).to receive(:execute).and_yield(operation)
end end
...@@ -17,7 +17,7 @@ describe WaitForClusterCreationWorker do ...@@ -17,7 +17,7 @@ describe WaitForClusterCreationWorker do
let(:status) { 'RUNNING' } let(:status) { 'RUNNING' }
it 'reschedules worker' do it 'reschedules worker' do
expect(WaitForClusterCreationWorker).to receive(:perform_in) expect(described_class).to receive(:perform_in)
described_class.new.perform(cluster.id) described_class.new.perform(cluster.id)
end end
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment