Commit 385aa460 authored by Stan Hu's avatar Stan Hu

Cache Flipper persisted names directly to local memory storage

Now that application settings are no longer dominating network traffic,
we see that the Feature#persisted_names is using a significant amount of
CPU and network bandwidth for Redis. Move this cache into the
thread-local memory storage to reduce Redis overhead.
parent e07ebe66
Pipeline #69031291 passed with stages
in 73 minutes and 58 seconds
---
title: Cache Flipper persisted names directly to local memory storage
merge_request: 30265
author:
type: performance
......@@ -34,7 +34,9 @@ class Feature
begin
# We saw on GitLab.com, this database request was called 2300
# times/s. Let's cache it for a minute to avoid that load.
Rails.cache.fetch('flipper:persisted_names', expires_in: 1.minute) { FlipperFeature.feature_names }
Gitlab::ThreadMemoryCache.cache_backend.fetch('flipper:persisted_names', expires_in: 1.minute) do
FlipperFeature.feature_names
end
end
end
......
......@@ -40,7 +40,7 @@ describe Feature do
.once
.and_call_original
expect(Rails.cache)
expect(Gitlab::ThreadMemoryCache.cache_backend)
.to receive(:fetch)
.once
.with('flipper:persisted_names', expires_in: 1.minute)
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment