• Yorick Peterse's avatar
    Merge issuable "reopened" state into "opened" · 6ef87a20
    Yorick Peterse authored
    Having two states that essentially mean the same thing is very much like
    having a boolean "true" and boolean "mostly-true": it's rather silly.
    This commit merges the "reopened" state into the "opened" state while
    taking care of system notes still showing messages along the lines of
    "Alice reopened this issue".
    A big benefit from having only two states (opened and closed) is that
    indexing and querying becomes simpler and more performant. For example,
    to get all the opened queries we no longer have to query both states:
        SELECT *
        FROM issues
        WHERE project_id = 2
        AND state IN ('opened', 'reopened');
    Instead we can query a single state directly, which can be much faster:
        SELECT *
        FROM issues
        WHERE project_id = 2
        AND state = 'opened';
    Further, only having two states makes indexing easier as we will only
    ever filter (and thus scan an index) using a single value. Partial
    indexes could help but aren't supported on MySQL, complicating the
    development process and not being helpful for MySQL.
20170719150301_merge_issuable_reopened_into_opened_state.rb 759 Bytes