• Stan Hu's avatar
    Fix inconsistency in Redis performance bar stats · 9dd59df6
    Stan Hu authored
    peek-redis resets its counters at the start of an ActionController
    notification (`start_processing.action_controller`), which causes it to
    miss some Redis queries that precede it, such as the database load
    balancer and Rack Attack queries. This produces inconsistencies in the
    performance bar between the number of calls and their durations with the
    actual calls in the detailed view.
    We fix this by getting rid of peek-redis in favor of consolidating all
    logic into the `RedisDetailed` view, which tracks Redis queries using
    `RequestStore`. This has the nice property of removing thread-specific
    counters as well.
    Closes https://gitlab.com/gitlab-org/gitlab-ce/issues/64707
This project manages its dependencies using Bundler. Learn more
Gemfile 10.3 KB