lint-rugged 1022 Bytes
Newer Older
1 2 3
#!/usr/bin/env ruby

ALLOWED = [
4
  # Needed to handle repositories that are not in any storage
5 6
  'lib/gitlab/bare_repository_import/repository.rb',

7
  # Needed to avoid using the git binary to validate a branch name
8 9 10 11 12 13
  'lib/gitlab/git_ref_validator.rb',

  # Reverted Rugged calls due to Gitaly atop NFS performance
  # See https://docs.gitlab.com/ee/development/gitaly.html#legacy-rugged-code.
  'lib/gitlab/git/rugged_impl/',
  'lib/gitlab/gitaly_client/storage_settings.rb'
14 15 16
].freeze

rugged_lines = IO.popen(%w[git grep -i -n rugged -- app config lib], &:read).lines
17
rugged_lines = rugged_lines.select { |l| /^[^:]*\.rb:/ =~ l }
18
rugged_lines = rugged_lines.reject { |l| l.start_with?(*ALLOWED) }
19
rugged_lines = rugged_lines.reject { |l| /(include|prepend) Gitlab::Git::RuggedImpl/ =~ l}
20 21 22 23 24 25 26 27 28 29 30 31
rugged_lines = rugged_lines.reject do |line|
  code, _comment = line.split('# ', 2)
  code !~ /rugged/i
end

exit if rugged_lines.empty?

puts "Using Rugged is only allowed in test and #{ALLOWED}\n\n"

puts rugged_lines

exit(false)