### Summary I have to periodically manually clear backups as the backup_keep_time is not respected, and I also see plenty of people on -ce also reporting this issue. ### Steps to reproduce Set backup_keep_time, and backup_upload_connection to use AWS provider (I'm S3 compatible DigitalOcean). ### What is the current *bug* behavior? Backups are not deleted. ### What is the expected *correct* behavior? Backups > backup_keep_time should be removed. #### Results of GitLab environment info <details> <pre> System information System: Ubuntu 18.04 Proxy: no Current User: git Using RVM: no Ruby Version: 2.5.3p105 Gem Version: 2.7.6 Bundler Version:1.16.6 Rake Version: 12.3.1 Redis Version: 3.2.12 Git Version: 2.18.1 Sidekiq Version:5.2.3 Go Version: unknown GitLab information Version: 11.6.2-ee Revision: 308f077aa39 Directory: /opt/gitlab/embedded/service/gitlab-rails DB Adapter: postgresql DB Version: 9.6.8 URL: https://gitlab.bitzesty.com HTTP Clone URL: https://gitlab.bitzesty.com/some-group/some-project.git SSH Clone URL: git@gitlab.bitzesty.com:some-group/some-project.git Elasticsearch: no Geo: no Using LDAP: no Using Omniauth: yes Omniauth Providers: google_oauth2 GitLab Shell Version: 8.4.3 Repository storage paths: - default: /var/opt/gitlab/git-data/repositories Hooks: /opt/gitlab/embedded/service/gitlab-shell/hooks Git: /opt/gitlab/embedded/bin/git </pre> </details> #### Results of GitLab application Check <details> <summary>Expand for output related to the GitLab application check</summary> <pre> Checking GitLab subtasks ... Checking GitLab Shell ... GitLab Shell: ... GitLab Shell version >= 8.4.3 ? ... OK (8.4.3) Running /opt/gitlab/embedded/service/gitlab-shell/bin/check Check GitLab API access: OK Redis available via internal API: OK Access to /var/opt/gitlab/.ssh/authorized_keys: OK gitlab-shell self-check successful Checking GitLab Shell ... Finished Checking Gitaly ... Gitaly: ... default ... OK Checking Gitaly ... Finished Checking Sidekiq ... Sidekiq: ... Running? ... yes Number of Sidekiq processes ... 1 Checking Sidekiq ... Finished Checking Incoming Email ... Incoming Email: ... Reply by email is disabled in config/gitlab.yml Checking Incoming Email ... Finished Checking LDAP ... LDAP: ... LDAP is disabled in config/gitlab.yml Checking LDAP ... Finished Checking GitLab App ... Git configured correctly? ... yes Database config exists? ... yes All migrations up? ... yes Database contains orphaned GroupMembers? ... no GitLab config exists? ... yes GitLab config up to date? ... yes Log directory writable? ... yes Tmp directory writable? ... yes Uploads directory exists? ... yes Uploads directory has correct permissions? ... yes Uploads directory tmp has correct permissions? ... yes Init script exists? ... skipped (omnibus-gitlab has no init script) Init script up-to-date? ... skipped (omnibus-gitlab has no init script) Projects have namespace: ... 6/4 ... yes 6/5 ... yes 6/6 ... yes 6/7 ... yes 10/8 ... yes 11/9 ... yes 11/10 ... yes 12/11 ... yes 13/12 ... yes 13/13 ... yes 13/14 ... yes 13/15 ... yes 13/16 ... yes 13/17 ... yes 13/18 ... yes 13/19 ... yes 13/20 ... yes 13/21 ... yes 14/22 ... yes 14/23 ... yes 14/24 ... yes 14/25 ... yes 14/26 ... yes 14/27 ... yes 14/28 ... yes 14/29 ... yes 14/30 ... yes 14/31 ... yes 14/32 ... yes 14/33 ... yes 14/34 ... yes 13/35 ... yes 13/36 ... yes 11/37 ... yes 14/38 ... yes 15/39 ... yes 15/40 ... yes 15/41 ... yes 18/42 ... yes 14/43 ... yes 15/44 ... yes 15/45 ... yes 15/46 ... yes 17/47 ... yes 17/48 ... yes 13/49 ... yes 13/50 ... yes 15/51 ... yes 15/52 ... yes 15/53 ... yes 18/54 ... yes 15/55 ... yes 15/56 ... yes 15/57 ... yes 15/58 ... yes 15/59 ... yes 6/60 ... yes 18/61 ... yes 14/62 ... yes 14/63 ... yes 14/64 ... yes 14/65 ... yes 14/66 ... yes 14/67 ... yes 14/68 ... yes 13/69 ... yes 13/70 ... yes 15/71 ... yes 14/72 ... yes 13/73 ... yes 13/74 ... yes 15/75 ... yes 13/76 ... yes 13/77 ... yes 6/78 ... yes 6/79 ... yes 15/80 ... yes 15/81 ... yes 20/82 ... yes 21/83 ... yes 23/84 ... yes 24/85 ... yes 22/86 ... yes 22/87 ... yes 22/88 ... yes 18/89 ... yes 2/90 ... yes 22/91 ... yes 22/92 ... yes 22/93 ... yes 22/94 ... yes 25/95 ... yes 25/96 ... yes 25/97 ... yes 22/98 ... yes 15/99 ... yes 15/100 ... yes 15/101 ... yes 26/102 ... yes 26/103 ... yes 27/104 ... yes 28/105 ... yes 18/106 ... yes 15/107 ... yes 29/108 ... yes 29/109 ... yes 15/110 ... yes 31/111 ... yes 31/112 ... yes 21/113 ... yes 18/114 ... yes 42/115 ... yes 43/117 ... yes 48/119 ... yes 48/120 ... yes 48/121 ... yes 3/122 ... yes Redis version >= 2.8.0? ... yes Ruby version >= 2.3.5 ? ... yes (2.5.3) Git version >= 2.18.0 ? ... yes (2.18.1) Git user has default SSH configuration? ... yes Active users: ... 17 Elasticsearch version 5.6 - 6.x? ... skipped (elasticsearch is disabled) Checking GitLab App ... Finished Checking GitLab subtasks ... Finished </pre> </details> ### Possible fixes