GPG signed commits

What does this MR do?

1. Shows gpg signed commits (excl. tags)
2. If the gpg key is verified (= the gpg was added to GitLab and the user's email matches the key's email) a "Verified" batch is displayed
3. If the gpg key is not verified or does not exist on GitLab an "Unverified" batch is displayed
4. If the commit is not signed, the behaviour is unchanged
5. Allows the user to add gpg keys to his profile

Are there points in the code the reviewer needs to double check?

Why was this MR needed?

Git allows to signed commits. This PR enables displaying those commits.

The development of this MR is sponsored by @siemens (/cc @bufferoverflow).

Screenshots (if relevant)

Commits list:

Commit details:

Badge popovers:

User settings > GPG key:

Does this MR meet the acceptance criteria?

• Changelog entry added
• Documentation created/updated
• API support added
• Tests
  • Added for this feature/bug
  • All builds are passing
• Conform by the merge request performance guides
• Conform by the style guides
• Branch has no merge conflicts with master (if it does - rebase it please)
• Squashed related commits together

What are the relevant issue numbers?

Closes https://gitlab.com/gitlab-org/gitlab-ce/issues/20268.

app/controllers/profiles/gpg_keys_controller.rb

 class Profiles::GpgKeysController < Profiles::ApplicationController
+  before_action :set_gpg_key, only: [:destroy, :revoke]
+
   def index
     @gpg_keys = current_user.gpg_keys
     @gpg_key = GpgKey.new
@@ -16,8 +18,7 @@ def create
   end
 
   def destroy
-    @gpp_key = current_user.gpg_keys.find(params[:id])
-    @gpp_key.destroy
+    @gpg_key.destroy
 
     respond_to do |format|
       format.html { redirect_to profile_gpg_keys_url, status: 302 }
@@ -26,8 +27,7 @@ def destroy
   end
 
   def revoke
-    @gpp_key = current_user.gpg_keys.find(params[:id])
-    @gpp_key.revoke
+    @gpg_key.revoke
 
     respond_to do |format|
       format.html { redirect_to profile_gpg_keys_url, status: 302 }
@@ -40,4 +40,8 @@ def revoke
   def gpg_key_params
     params.require(:gpg_key).permit(:key)
   end
+
+  def set_gpg_key
+    @gpg_key = current_user.gpg_keys.find(params[:id])
+  end
 end