Added Prometheus Service and Prometheus graphs
-
Review changes -
-
Download -
Patches
-
Plain diff
What does this MR do?
Part of https://gitlab.com/gitlab-org/gitlab-ce/issues/26910
This MR adds a Prometheus Service, with support for fetching metrics for an environment and displaying that on environments page.
We miss actual data fetching, but this is a placeholder that can be used to be worked on.
Are there points in the code the reviewer needs to double check?
Why was this MR needed?
Screenshots (if relevant)
Does this MR meet the acceptance criteria?
-
Changelog entry added -
Documentation created/updated -
API support added - Tests
-
Added for this feature/bug -
All builds are passing
-
-
Conform by the merge request performance guides -
Conform by the style guides -
Branch has no merge conflicts with master
(if it does - rebase it please) -
Squashed related commits together
What are the relevant issue numbers?
Functionality Notes
Kamil: Please, edit queries and @jivanvl can add graphs to metrics action of environments_controller, as part of my MR: https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/8935
Kamil: For development make sure to have sidekiq running as the data is fetched in the background, API can return the http status code 204 it means that the data is not yet ready, retry with some delay if that happens. In normal circumstances you will receive a 200 http status code with the JSON status: true
Josh: I spun up a prometheus server outside of the omnibus package, here: https://kubeprom.35.185.3.210.nip.io/graph. This one has the k8s metrics we want to use for this.
\cc @joshlambert @ayufan
Merge request reports
- version 279310bc99
- version 26c78e7fe3
- version 2501a6c1b9
- version 24fda6a54a
- version 23d9917e54
- version 22dc8c63ef
- version 21fe9e5103
- version 2017296cb2
- version 1944325b48
- version 1829e23595
- version 17c95f1a15
- version 169c893e54
- version 1569866fc6
- version 14f9390414
- version 135739c269
- version 12b198dc33
- version 11c3e41613
- version 10ff918058
- version 98cac0bb3
- version 8a947eebc
- version 7f8fc6a23
- version 6a9b4bcf8
- version 5fb2447cb
- version 4fda3a7b7
- version 3a2ed9e86
- version 2da54fd99
- version 18067ba1c
- master (base)
- latest version87d3cdcd42 commits,
- version 279310bc9941 commits,
- version 26c78e7fe340 commits,
- version 2501a6c1b939 commits,
- version 24fda6a54a38 commits,
- version 23d9917e5436 commits,
- version 22dc8c63ef31 commits,
- version 21fe9e510328 commits,
- version 2017296cb227 commits,
- version 1944325b4826 commits,
- version 1829e2359525 commits,
- version 17c95f1a1524 commits,
- version 169c893e5423 commits,
- version 1569866fc622 commits,
- version 14f939041421 commits,
- version 135739c26914 commits,
- version 12b198dc3313 commits,
- version 11c3e4161312 commits,
- version 10ff91805811 commits,
- version 98cac0bb310 commits,
- version 8a947eebc10 commits,
- version 7f8fc6a239 commits,
- version 6a9b4bcf88 commits,
- version 5fb2447cb7 commits,
- version 4fda3a7b76 commits,
- version 3a2ed9e865 commits,
- version 2da54fd995 commits,
- version 18067ba1c3 commits,
- Side-by-side
- Inline