Skip to content

GitLab Next

  • Projects
  • Groups
  • Snippets
  • Help
    • Loading...
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
GitLab FOSS
GitLab FOSS
  • Project overview
    • Project overview
    • Details
    • Activity
    • Releases
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
    • Locked Files
  • Issues 0
    • Issues 0
    • List
    • Boards
    • Labels
    • Service Desk
    • Milestones
    • Iterations
  • Merge Requests 0
    • Merge Requests 0
  • Requirements
    • Requirements
    • List
  • Operations
    • Operations
    • Incidents
    • Environments
  • Packages & Registries
    • Packages & Registries
    • Container Registry
  • Analytics
    • Analytics
    • Code Review
    • Insights
    • Issue
    • Repository
    • Value Stream
  • Snippets
    • Snippets
  • Members
    • Members
  • Activity
  • Graph
  • Create a new issue
  • Commits
  • Issue Boards
Collapse sidebar
  • GitLab.org
  • GitLab FOSSGitLab FOSS
  • Merge Requests
  • !7931

Merged
Opened Dec 05, 2016 by Filipa Lacerda@filipaContributor6 of 9 tasks completed6/9 tasks

Resolve "Manual actions on pipeline graph"

  • Overview 90
  • Commits 54
  • Pipelines 50
  • Changes 19

What does this MR do?

Improves the pipeline graph:

  • add actions to each node
  • always show the status icon
  • improves style
  • adds new icons to use only on the pipeline graph
  • fixes tooltip body
  • adds partial to render the graph node

Hover state:

@dimitrieh

This MR does not implements 100% of the mockups - https://gitlab-org.gitlab.io/gitlab-design/progress/dimitrie/pipelines-graphic/22604-spec-previews/#artboard0

As you can see in the mockups, each node has 2 separate hover states, one for the all content and one for the action icon. In order to not hover the all content when we hover the action icon we would need to refactor the all HTML & CSS of all the pipeline graph, lines included. The hover problem can be seen in the following video. video

As you can see in the video, the build node is hovered even when the mouse seems to be far from the element.

It does not seem wise to me to change the HTML & CSS now for two reasons:

  • we would need to rewrite almost everything;
  • we will probably rewrite everything when we move this to vue.

Given the latter point, and considering it will be a bug effort to make the hover states equal to the mockups, I suggest we do that when we rewrite the all view. This is fixable, though, but requires some effort & time.

I can, although, be missing something. @annabeldunstone do you see any quick/easy fix here?

Screenshots (if relevant)

video

Screen_Shot_2016-12-12_at_12.38.25 Screen_Shot_2016-12-12_at_12.38.31 Screen_Shot_2016-12-12_at_12.38.39 Screen_Shot_2016-12-12_at_12.40.00

Tooltip before Screen_Shot_2016-12-06_at_11.29.54 Tooltip after Screen_Shot_2016-12-06_at_11.56.03

Does this MR meet the acceptance criteria?

  • Changelog entry added
  • Documentation created/updated
  • API support added
  • Tests
    • Added for this feature/bug
    • All builds are passing
  • Conform by the merge request performance guides
  • Conform by the style guides
  • Branch has no merge conflicts with master (if it does - rebase it please)
  • Squashed related commits together

What are the relevant issue numbers?

Closes #22604 (closed)

Assignee
Assign to
Reviewer
Request review from
8.15
Milestone
8.15 (Past due)
Assign milestone
Time tracking
Reference: gitlab-org/gitlab-foss!7931
Source branch: 22604-manual-actions