Skip to content

GitLab Next

Project 'gitlab-org/gitlab-ce' was moved to 'gitlab-org/gitlab-foss'. Please update any links and bookmarks that may still have the old path.
Merged
Created by Leandro Camargo@leandroicoContributor7 of 9 tasks completed7/9 tasks

Add ability to define a coverage regex in the .gitlab-ci.yml

What does this MR do?

It's a feature that adds the possibility of setting up a coverage regex directly inside the gitlab CI YAML file ( .gitlab-ci.yml). If any given job described in the YAML file has a coverage_regex defined in it, then its value will take precedence over the one defined in the project's pipeline settings. Otherwise, the coverage regex in defined on the project level will be used. WIP reason: it's missing the tests for now. I prefer to wait for an experienced reviewer to give me the green light first regarding the solution itself. I don't want to write tests for an alleged wrong solution. If it's good to go, I write the tests on a new commit and ask for a second review (regarding the second commit). If all is good then I squash the commits and ask for the actual merge.

Are there points in the code the reviewer needs to double check?

Yes. Basically everything. This is my first contribution to GitLab and I'm not sure how accurate and efficient my solution is for this problem. I believe it's a good one, but I'm waiting for an experienced reviewer to say so first, before I write and send the tests for my patch.

Why was this MR needed?

Right now, it's only possible to set up a coverage regex on the whole project context and it turns out that there are users that need a way to define coverage regex patterns for multiple different jobs. Each job can have different coverage patterns in their outputs. For further details regarding the motivations that caused this MR to exist, see the issue referenced in this MR ( #20428 (closed)).

Screenshots (if relevant)

Does this MR meet the acceptance criteria?

What are the relevant issue numbers?

Closes #20428 (closed)