Skip to content

GitLab Next

    • GitLab: the DevOps platform
    • Explore GitLab
    • Install GitLab
    • How GitLab compares
    • Get started
    • GitLab docs
    • GitLab Learn
  • Pricing
  • Talk to an expert
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
    • Menu
    Projects Groups Snippets
  • Get a free trial
  • Sign up
  • Login
  • Sign in / Register
  • GitLab FOSS GitLab FOSS
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
    • Locked Files
  • Issues 0
    • Issues 0
    • List
    • Boards
    • Service Desk
    • Milestones
    • Iterations
    • Requirements
  • Merge requests 0
    • Merge requests 0
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages & Registries
    • Packages & Registries
    • Package Registry
    • Container Registry
    • Infrastructure Registry
  • Monitor
    • Monitor
    • Metrics
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • Code review
    • Insights
    • Issue
    • Repository
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Commits
  • Issue Boards
Collapse sidebar

GitLab 15.0 is launching on May 22! This version brings many exciting improvements, but also removes deprecated features and introduces breaking changes that may impact your workflow. To see what is being deprecated and removed, please visit Breaking changes in 15.0 and Deprecations.

  • GitLab.org
  • GitLab FOSSGitLab FOSS
  • Merge requests
  • !7125
Merged
Created Oct 26, 2016 by Rémy Coutable@rymai🔴Maintainer8 of 9 tasks completed8/9 tasks
  • Review changes

  • Download
  • Email patches
  • Plain diff

Add setting to only allow merge requests to be merged when all discussions are resolved

  • Overview 13
  • Commits 3
  • Pipelines 7
  • Changes 20

Originally opened at !6385 (closed) by @rodolfoasantos.


What does this MR do?

Based on #20968 (closed) this merge request adds setting only to allow merge requests to be merged when all discussions are resolved.

Are there points in the code the reviewer needs to double check?

Check if there are other points to add the resolved discussion setting

Why was this MR needed?

Add the possibility to configure the project to only accept merge request when all discussions are resolved

Screenshots

only_allow_merge_if_all_discussions_are_resolved

only_allow_merge_if_all_discussions_are_resolved_msg

Does this MR meet the acceptance criteria?

  • CHANGELOG entry added
  • Documentation created/updated
  • API support added
  • Tests
    • Added for this feature/bug
    • All builds are passing
  • Conform by the merge request performance guides
  • Conform by the style guides
  • Branch has no merge conflicts with master (if you do - rebase it please)
  • Squashed related commits together

What are the relevant issue numbers?

Closes #20968 (closed)

Assignee
Assign to
Reviewer
Request review from
Time tracking
Source branch: 20968-add-setting-to-check-unresolved-discussion