Skip to content

GitLab Next

  • Projects
  • Groups
  • Snippets
  • Help
    • Loading...
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
GitLab FOSS GitLab FOSS
  • Project overview
    • Project overview
    • Details
    • Activity
    • Releases
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
    • Locked Files
  • Issues 0
    • Issues 0
    • List
    • Boards
    • Labels
    • Service Desk
    • Milestones
    • Iterations
  • Merge requests 0
    • Merge requests 0
  • Requirements
    • Requirements
    • List
  • Operations
    • Operations
    • Incidents
    • Environments
  • Packages & Registries
    • Packages & Registries
    • Container Registry
  • Analytics
    • Analytics
    • Code Review
    • Insights
    • Issue
    • Repository
    • Value Stream
  • Snippets
    • Snippets
  • Members
    • Members
  • Activity
  • Graph
  • Create a new issue
  • Commits
  • Issue Boards
Collapse sidebar
  • GitLab.org
  • GitLab FOSSGitLab FOSS
  • Merge requests
  • !6373

Merged
Created Sep 15, 2016 by Guyzmo@guyzmo🐾Contributor9 of 9 tasks completed9/9 tasks

Adding support for personal snippet endpoint on the API

  • Overview 197
  • Commits 1
  • Pipelines 23
  • Changes 11

What does this MR do?

Exposing the snippets feature as an API

Are there points in the code the reviewer needs to double check?

  • it's a first shot, and I'm not very comfy with Ruby/RoR, so all of it! (fixed)
  • the create method has no authentication yet, and when uncommented does not work (403). (fixed)
    • But is it really needed? I mean can the API really be used when having no private key? (fixed)
  • The /snippets/public (or /snippets/all or /snippets/explore) cannot be reached… I guess something's wrong. (fixed)
  • I have no idea where to start to do a /snippets/search endpoint, but that would be useful. (fixed)
  • there's no tests yet. (done)
  • there's no doc yet. (done)

Why was this MR needed?

Because the personal snippet feature had no API implementation…

Does this MR meet the acceptance criteria?

  • CHANGELOG entry added
  • Documentation created/updated
  • API support added
  • Tests
    • Added for this feature/bug
    • All builds are passing
  • Conform by the merge request performance guides
  • Conform by the style guides
  • Branch has no merge conflicts with master (if you do - rebase it please)
  • Squashed related commits together

What are the relevant issue numbers?

#22042 (closed)

Assignee
Assign to
Reviewer
Request review from
8.15
Milestone
8.15 (Past due)
Assign milestone
Time tracking
Source branch: features/api-snippets