Skip to content

Replace the tinder gem by bare HTTP requests

Thomas Balthazar requested to merge tbalthazar/gitlab-ce:13333-consider-updating-http-parser-rb-to-0-6-0 into master

What does this MR do?

It removes the tinder gem (used to talk to the Campfire API) and replaces its use by bare HTTP requests.

Are there points in the code the reviewer needs to double check?

N/A.

Why was this MR needed?

To simplify the potential dependency hell discussed in #13333 (closed).
The initial issue was about updating http_parser.rb which was required by twitter-stream which was required by tinder.
Those 3 gems are not needed anymore.

What are the relevant issue numbers?

#13333 (closed)

Screenshots (if relevant)

N/A.

Does this MR meet the acceptance criteria?

Merge request reports