Skip to content

GitLab Next

  • Menu
Projects Groups Snippets
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • GitLab FOSS GitLab FOSS
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
    • Locked Files
  • Issues 0
    • Issues 0
    • List
    • Boards
    • Service Desk
    • Milestones
    • Iterations
    • Requirements
  • Merge requests 0
    • Merge requests 0
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages & Registries
    • Packages & Registries
    • Package Registry
    • Container Registry
    • Infrastructure Registry
  • Monitor
    • Monitor
    • Metrics
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • Code review
    • Insights
    • Issue
    • Repository
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Commits
  • Issue Boards
Collapse sidebar
  • GitLab.org
  • GitLab FOSSGitLab FOSS
  • Merge requests
  • !5022

Diff line comments resolve

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Phil Hughes requested to merge diff-line-comment-vuejs into master Jun 30, 2016
  • Overview 345
  • Commits 119
  • Pipelines 1
  • Changes 76

What does this MR do?

Diff line comments can be resolved.

Part of #10325 (closed)

To do:

  • Backend (@DouweM)
    • Fix https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/5022#note_13319326. Will be made easier by https://gitlab.com/gitlab-org/gitlab-ce/issues/17237#note_13370331
    • System note when all discussions are resolved
    • Notification when all discussions are resolved
    • Write unit tests
    • Look at resolve time https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/5022#note_13912743 - Fixed by 4a13aa9f
  • Frontend (@iamphill)
    • Fix bugs
    • Write more feature tests
  • Frontend (@connorshea)
    • Address frontend feedback
    • Feature specs for Jump feature
    • Documentation
    • Add Vue.js in a standard way
Assignee
Assign to
Reviewer
Request review from
Time tracking
Source branch: diff-line-comment-vuejs