Decouple membership and notifications

This allow you to have notification setting per project even if you are member of group. It also creates background for having notification settings in project you are not member of.

• Make it work
• Migrations
• CHANGELOG
• More tests
• API

For #3359 (closed)

After this merge request there is still some work to be done:

• create migration that remove duplicates in notification settings table and create uniq index (8.8 probably)
• remove notification_level field from Member model in 9.0
• make proper API for notification settings
• use MemberCreateService instead of Member#after_create callback for creating notification settings (after #14709 (moved))
• maybe more tests

Signed-off-by: Dmitriy Zaporozhets dmitriy.zaporozhets@gmail.com

app/controllers/projects_controller.rb

@@ -102,12 +102,7 @@ def show
           @membership = @project.team.find_member(current_user.id)
 
           if @membership
-            @notification_setting = current_user.notification_settings.find_or_initialize_by(source: @project)
-
-            unless @notification_setting.persisted?
-              @notification_setting.set_defaults
-              @notification_setting.save
-            end
+            @notification_setting = current_user.notification_settings.find_or_create_for(@project)
           end
         end