Skip to content
GitLab
Next
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • GitLab FOSS GitLab FOSS
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
    • Locked Files
  • Issues 0
    • Issues 0
    • List
    • Boards
    • Service Desk
    • Milestones
    • Iterations
    • Requirements
  • Merge requests 1
    • Merge requests 1
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Package Registry
    • Container Registry
    • Infrastructure Registry
  • Monitor
    • Monitor
    • Metrics
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • Code review
    • Insights
    • Issue
    • Repository
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Commits
  • Issue Boards
Collapse sidebar
  • GitLab.orgGitLab.org
  • GitLab FOSSGitLab FOSS
  • Merge requests
  • !31722

Resolve "Run pipeline button for "Pipelines for merge requests""

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Filipa Lacerda requested to merge 65940-run-pipeline into master Aug 12, 2019
  • Overview 118
  • Commits 13
  • Pipelines 34
  • Changes 18

What does this MR do?

Frontend:

(Note for the reviewer/maintainer, this code still uses the old non-vuex pattern with the eventHub)

  • Renders the Run Pipeline button in the MR page only and only when the latest pipeline is detached
  • Disables the button & shows a loading icon when the request is being made
  • Updates the table once the post request has finished
  • Handles the error
  • Added specs
mobile desktop loading error
Screenshot_2019-08-20_at_11.06.36 Screenshot_2019-08-20_at_10.57.29 Screenshot_2019-08-20_at_10.53.48 Screenshot_2019-08-20_at_11.11.59

Backend:

WIP

Does this MR meet the acceptance criteria?

Conformity

  • Changelog entry for user-facing changes, or community contribution. Check the link for other scenarios.
  • Documentation created/updated or follow-up review issue created
  • Code review guidelines
  • Merge request performance guidelines
  • Style guides
  • Database guides
  • Separation of EE specific content

Performance and Testing

  • Review and add/update tests for this feature/bug. Consider all test levels. See the Test Planning Process.
  • Tested in all supported browsers

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • Security reports checked/validated by a reviewer from the AppSec team

Closes #65940 (closed)

Edited Aug 20, 2019 by Filipa Lacerda
Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: 65940-run-pipeline