Skip to content

Resolve "Run pipeline button for "Pipelines for merge requests""

Filipa Lacerda requested to merge 65940-run-pipeline into master

What does this MR do?

Frontend:

(Note for the reviewer/maintainer, this code still uses the old non-vuex pattern with the eventHub)

  • Renders the Run Pipeline button in the MR page only and only when the latest pipeline is detached
  • Disables the button & shows a loading icon when the request is being made
  • Updates the table once the post request has finished
  • Handles the error
  • Added specs
mobile desktop loading error
Screenshot_2019-08-20_at_11.06.36 Screenshot_2019-08-20_at_10.57.29 Screenshot_2019-08-20_at_10.53.48 Screenshot_2019-08-20_at_11.11.59

Backend:

WIP

Does this MR meet the acceptance criteria?

Conformity

Performance and Testing

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • Security reports checked/validated by a reviewer from the AppSec team

Closes #65940 (closed)

Edited by Filipa Lacerda

Merge request reports