Skip to content

GitLab Next

  • Projects
  • Groups
  • Snippets
  • Help
    • Loading...
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
GitLab FOSS
GitLab FOSS
  • Project overview
    • Project overview
    • Details
    • Activity
    • Releases
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
    • Locked Files
  • Issues 0
    • Issues 0
    • List
    • Boards
    • Labels
    • Service Desk
    • Milestones
    • Iterations
  • Merge Requests 0
    • Merge Requests 0
  • Requirements
    • Requirements
    • List
  • Operations
    • Operations
    • Incidents
    • Environments
  • Packages & Registries
    • Packages & Registries
    • Container Registry
  • Analytics
    • Analytics
    • Code Review
    • Insights
    • Issue
    • Repository
    • Value Stream
  • Snippets
    • Snippets
  • Members
    • Members
  • Activity
  • Graph
  • Create a new issue
  • Commits
  • Issue Boards
Collapse sidebar
  • GitLab.org
  • GitLab FOSSGitLab FOSS
  • Merge Requests
  • !29511

The source project of this merge request has been removed.
Merged
Opened Jun 11, 2019 by Fabio Papa@fapapaContributor1 of 12 tasks completed1/12 tasks

Process up to 100 commit messages for references when pushing to a new default branch

  • Overview 6
  • Commits 6
  • Pipelines 3
  • Changes 3

What does this MR do?

Patch for the bug described in #56683 (closed). On first push to the default branch, we are currently not processing commits for references to issues. This is done on purpose, probably for performance reasons, to avoid processing thousands of commits. If we limit the commit processing to a reasonable number of commits, performance will not be impacted significantly, and this will cease to appear as a bug for the vast majority of users.

Does this MR meet the acceptance criteria?

Conformity

  • Changelog entry
  • Documentation created/updated or follow-up review issue created
  • Code review guidelines
  • Merge request performance guidelines
  • Style guides
  • Database guides
  • Separation of EE specific content

Performance and testing

  • Review and add/update tests for this feature/bug. Consider all test levels. See the Test Planning Process.
  • Tested in all supported browsers

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • Security reports checked/validated by a reviewer from the AppSec team
Edited Jun 12, 2019 by Douwe Maan
Assignee
Assign to
Reviewer
Request review from
12.0
Milestone
12.0 (Past due)
Assign milestone
Time tracking
Reference: gitlab-org/gitlab-foss!29511
Source branch: patch-issue-#56683