From 913084e6a3147fb55e66fc38b230f1166b7e9f8b Mon Sep 17 00:00:00 2001
From: Stan Hu <stanhu@gmail.com>
Date: Thu, 3 Jan 2019 13:17:44 -0800
Subject: [PATCH] Fix clone URL not showing if protocol is HTTPS

GitLab 11.6.2 fixed the case for HTTP. However, HTTPS still did
not work because the protocol returned to `http_enabled?`
was the actual protocol in use (e.g. `https` instead of `http`).

Closes https://gitlab.com/gitlab-org/gitlab-ce/issues/55896
---
 app/helpers/application_settings_helper.rb    |  4 +-
 .../unreleased/sh-fix-clone-url-for-https.yml |  5 +++
 .../application_settings_helper_spec.rb       | 39 +++++++++++++++++++
 3 files changed, 46 insertions(+), 2 deletions(-)
 create mode 100644 changelogs/unreleased/sh-fix-clone-url-for-https.yml
 create mode 100644 spec/helpers/application_settings_helper_spec.rb

diff --git a/app/helpers/application_settings_helper.rb b/app/helpers/application_settings_helper.rb
index 5a7c005fd06..c8e4e2e3df9 100644
--- a/app/helpers/application_settings_helper.rb
+++ b/app/helpers/application_settings_helper.rb
@@ -20,7 +20,7 @@ def allowed_protocols_present?
   def enabled_protocol
     case Gitlab::CurrentSettings.enabled_git_access_protocol
     when 'http'
-      gitlab_config.protocol
+      Gitlab.config.gitlab.protocol
     when 'ssh'
       'ssh'
     end
@@ -35,7 +35,7 @@ def ssh_enabled?
   end
 
   def http_enabled?
-    all_protocols_enabled? || enabled_protocol == 'http'
+    all_protocols_enabled? || Gitlab::CurrentSettings.enabled_git_access_protocol == 'http'
   end
 
   def enabled_project_button(project, protocol)
diff --git a/changelogs/unreleased/sh-fix-clone-url-for-https.yml b/changelogs/unreleased/sh-fix-clone-url-for-https.yml
new file mode 100644
index 00000000000..6a17d566685
--- /dev/null
+++ b/changelogs/unreleased/sh-fix-clone-url-for-https.yml
@@ -0,0 +1,5 @@
+---
+title: Fix clone URL not showing if protocol is HTTPS
+merge_request: 24131
+author:
+type: fixed
diff --git a/spec/helpers/application_settings_helper_spec.rb b/spec/helpers/application_settings_helper_spec.rb
new file mode 100644
index 00000000000..705523f1110
--- /dev/null
+++ b/spec/helpers/application_settings_helper_spec.rb
@@ -0,0 +1,39 @@
+# frozen_string_literal: true
+
+require 'spec_helper'
+
+describe ApplicationSettingsHelper do
+  context 'when all protocols in use' do
+    before do
+      stub_application_setting(enabled_git_access_protocol: '')
+    end
+
+    it { expect(all_protocols_enabled?).to be_truthy }
+    it { expect(http_enabled?).to be_truthy }
+    it { expect(ssh_enabled?).to be_truthy }
+  end
+
+  context 'when SSH is only in use' do
+    before do
+      stub_application_setting(enabled_git_access_protocol: 'ssh')
+    end
+
+    it { expect(all_protocols_enabled?).to be_falsey }
+    it { expect(http_enabled?).to be_falsey }
+    it { expect(ssh_enabled?).to be_truthy }
+  end
+
+  shared_examples 'when HTTP protocol is in use' do |protocol|
+    before do
+      allow(Gitlab.config.gitlab).to receive(:protocol).and_return(protocol)
+      stub_application_setting(enabled_git_access_protocol: 'http')
+    end
+
+    it { expect(all_protocols_enabled?).to be_falsey }
+    it { expect(http_enabled?).to be_truthy }
+    it { expect(ssh_enabled?).to be_falsey }
+  end
+
+  it_behaves_like 'when HTTP protocol is in use', 'https'
+  it_behaves_like 'when HTTP protocol is in use', 'http'
+end
-- 
GitLab