Skip to content

GitLab Next

  • Projects
  • Groups
  • Snippets
  • Help
    • Loading...
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
GitLab FOSS GitLab FOSS
  • Project overview
    • Project overview
    • Details
    • Activity
    • Releases
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
    • Locked Files
  • Issues 0
    • Issues 0
    • List
    • Boards
    • Labels
    • Service Desk
    • Milestones
    • Iterations
  • Merge requests 0
    • Merge requests 0
  • Requirements
    • Requirements
    • List
  • Operations
    • Operations
    • Incidents
    • Environments
  • Packages & Registries
    • Packages & Registries
    • Container Registry
  • Analytics
    • Analytics
    • Code Review
    • Insights
    • Issue
    • Repository
    • Value Stream
  • Snippets
    • Snippets
  • Members
    • Members
  • Activity
  • Graph
  • Create a new issue
  • Commits
  • Issue Boards
Collapse sidebar
  • GitLab.org
  • GitLab FOSSGitLab FOSS
  • Merge requests
  • !22684

Merged
Created Oct 30, 2018 by blackst0ne@blackst0neDeveloper3 of 8 tasks completed3/8 tasks

Add Discord integration

  • Overview 67
  • Commits 13
  • Pipelines 12
  • Changes 15

What does this MR do?

Adds a news service - integration with Discord

What are the relevant issue numbers?

Closes #21635 (closed)

Why using fork?

This MR brings the usage of discordrb-webhooks-blackst0ne - a fork of mine. Why do we need to use the fork instead of the upstream version of the gem?

The reason is in dependency conflicts.

The upstream discordrb gem requires 'rest-client >= 2.1.0.rc1' At the same time kubeclient we already use requires 'rest-client ~> 2.0' which raises dependency conflicts.

I have forked discordrb and relaxed the dependency of rest-client. Now it requires 'rest-client ~> 2.0' - the same version as kubeclient expects.

The dependency of rest-client >= 2.1.0.rc1 was added to fix some bugs for Ruby 2.5 on Windows OSes. So it seems we can just relax dependencies and use the gem.

This fork should be replaced by the upstream version when both discordrb and kubeclient start requiring the same version of rest-client.

Does this MR meet the acceptance criteria?

  • Changelog entry added, if necessary
  • Documentation created/updated
  • Tests added for this feature/bug
  • Conforms to the code review guidelines
  • Conforms to the merge request performance guidelines
  • Conforms to the style guides
  • Conforms to the database guides
  • Link to e2e tests MR added if this MR has Requires e2e tests label. See the Test Planning Process.
Edited Nov 05, 2018 by blackst0ne
Assignee
Assign to
Reviewer
Request review from
11.6
Milestone
11.6 (Past due)
Assign milestone
Time tracking
Source branch: blackst0ne-add-discord-service