CE Improve import status table UI
What does this MR do?
EE: https://gitlab.com/gitlab-org/gitlab-ee/merge_requests/8707
Improve import status table UI, replace with vue app.
-
Add "Go to project" button -
Align import buttons to the right -
Remove namespace select grey container -
Removing row status colour and use ci-style status icons to represent status
What are the relevant issue numbers?
Closes https://gitlab.com/gitlab-org/gitlab-ce/issues/14010
Does this MR meet the acceptance criteria?
-
Changelog entry added, if necessary -
Documentation created/updated -
Tests added for this feature/bug -
Conforms to the code review guidelines -
Conforms to the merge request performance guidelines -
Conforms to the style guides -
Conforms to the database guides
Merge request reports
Activity
2 Warnings This merge request is definitely too big (more than 2071 lines changed), please split it into multiple merge requests. 83a82bc7: This commit’s subject line could be improved. Commit subjects are ideally no longer than roughly 50 characters, though we allow up to 72 characters in the subject. If possible, try to reduce the length of the subject to roughly 50 characters. Generated by
DangerEdited by 🤖 GitLab Bot 🤖@dennis could you take a look at this?
assigned to @dennis
and @zj are you available to take a look at backend seeing as I've bugged you already about a couple things?
Rendering the json (https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/22458/diffs?view=inline#827040dc2a70d43f922532b67e034dbb70d9af73_34_41) seems to take a while, longer than it originally took to render the HTML I think. Is there something wrong with my serializers maybe?
Also, do you know a quick way to remove all previously imported repos? I deleted my
repositories/*
but its still showing all the imports and they're just stuck on "importing".Edited by Luke Bennettand @cperessini could you take a look at UX? Sorry for the lack of screenshots, I've currently imported all of my repos and have hit a "max project limit", so right now I cant create any more projects to take screenshots of the github import feature
I will get screenshots up and ping you again when I've resolved this with backend.We now also request the list of projects/repos async, so there is a loading spinner when you first load the import status page. Maybe you want to take a look at this and confirm that it's OK.
Edited by Luke Bennett- Resolved by Luke Bennett
- Resolved by Luke Bennett
- Resolved by Francisco Javier López
- Resolved by Luke Bennett
- Resolved by Luke Bennett
- Resolved by Luke Bennett
- Resolved by Luke Bennett
- Resolved by Luke Bennett
@lbennett I'm getting an empty table in the import page, and I know I have repos in GitHub. I wanted to try again from the start, but it remembers my token and I can't get it to ask me for a new one
We now also request the list of projects/repos async, so there is a loading spinner when you first load the import status page. Maybe you want to take a look at this and confirm that it's OK.
The
Import all projects
button has a spinner. This is not what you're referring to, right?Edited by Chris Peressini
- Resolved by Luke Bennett
- Resolved by Luke Bennett
- Resolved by Luke Bennett
- Resolved by Luke Bennett
- Resolved by Luke Bennett