An error occurred while fetching the assigned milestone of the selected merge_request.
Make GitLab pages support access control
-
Review changes -
-
Download -
Patches
-
Plain diff
What does this MR do?
Adds option to use GitLab access control in project pages #33422 (closed) and implement the necessary changes for pages config file generation.
This depends on the pages MR gitlab-pages!94 (merged).
The changes required for GitLab to automatically configure necessary pages client id, secret etc. are implemented in omnibus-gitlab!2583 (merged).
All feedback is appreciated!
Testing
At the moment this can be tested by creating the authentication id and secret manually and compiling GitLab pages from gitlab-pages branch.
CI
I haven't done any changes to gitlab-ee
so the ee_compat_check
job is failing at the moment.
Are there points in the code the reviewer needs to double check?
Not that I know of.
Why was this MR needed?
Closes #33422 (closed).
Screenshots (if relevant)
Does this MR meet the acceptance criteria?
-
Changelog entry added, if necessary -
Documentation created/updated -
API support added -
Tests added for this feature/bug - Review
-
Has been reviewed by UX -
Has been reviewed by Frontend -
Has been reviewed by Backend -
Has been reviewed by Database
-
-
Conform by the merge request performance guides -
Conform by the style guides -
Squashed related commits together -
Internationalization required/considered -
End-to-end tests pass ( package-and-qa
manual pipeline job)
What are the relevant issue numbers?
Edited by Nick Thomas
Merge request reports
Compare and
- version 36305b9bd6
- version 3513db385c
- version 34086faa1f
- version 3313db385c
- version 322693b209
- version 319a10518c
- version 30027b721d
- version 29027b721d
- version 2882a6ed55
- version 27c35800d9
- version 267ec876e8
- version 258b63204b
- version 24f5298382
- version 23c1bccbb9
- version 221a0508c8
- version 21b567b171
- version 204646e507
- version 1974985086
- version 18987e6968
- version 17b708ac48
- version 16e20760e3
- version 1552586157
- version 14175198f8
- version 133bf97f5d
- version 1241f40631
- version 1169431ce5
- version 10fc0065bb
- version 93247418f
- version 8ede64bf2
- version 7839a4050
- version 6a01196ba
- version 55e2abe35
- version 4af4f6978
- version 387e04177
- version 253fdf503
- version 154e2efa4
- master (base)
- latest version76a1b39d13 commits,
- version 36305b9bd612 commits,
- version 3513db385c11 commits,
- version 34086faa1f12 commits,
- version 3313db385c11 commits,
- version 322693b20910 commits,
- version 319a10518c9 commits,
- version 30027b721d8 commits,
- version 29027b721d8 commits,
- version 2882a6ed557 commits,
- version 27c35800d96 commits,
- version 267ec876e85 commits,
- version 258b63204b5 commits,
- version 24f52983824 commits,
- version 23c1bccbb93 commits,
- version 221a0508c82 commits,
- version 21b567b1717 commits,
- version 204646e5076 commits,
- version 19749850865 commits,
- version 18987e69685 commits,
- version 17b708ac484 commits,
- version 16e20760e33 commits,
- version 15525861573 commits,
- version 14175198f83 commits,
- version 133bf97f5d2 commits,
- version 1241f406312 commits,
- version 1169431ce51 commit,
- version 10fc0065bb1 commit,
- version 93247418f1 commit,
- version 8ede64bf26 commits,
- version 7839a40505 commits,
- version 6a01196ba4 commits,
- version 55e2abe353 commits,
- version 4af4f69782 commits,
- version 387e041772 commits,
- version 253fdf5031 commit,
- version 154e2efa41 commit,
Compare changes
- Side-by-side
- Inline
Files
25Loading