What does this MR do?
Part of https://gitlab.com/gitlab-org/gitlab-ce/issues/41111. Displays a verbose failure reason on Job detail page: root/minimal-ruby-app-test/-/jobs/23
Are there points in the code the reviewer needs to double check?
The HAML part that was removed included some permissions check.
After following the stack on the API ruby code, those permissions seem to be checked to expose the retry_path, so the frontend is relying on retry_path to know if user is authorised.The HAML part that was removed included some permissions check.
~~After following the stack on the API ruby code, those permissions seem to be checked to expose the retry_path, so the frontend is relying on retry_path to know if user is authorised.~~~
^ Fixed.
Why was this MR needed?
Currently when a job fails, we have no direct way to know which is the problem. The only option is to look at job details and read the output log, where we can possibly see some error message. This MR display the error on the job detail page
Screenshots (if relevant)
For failed job
For an allowed to fail job
For a job with no log
When retry button is not primary
Does this MR meet the acceptance criteria?
-
Changelog entry added, if necessary -
Tests added for this feature/bug -
Documentation created/updated - Review
-
Has been reviewed by UX -
Has been reviewed by Frontend -
Has been reviewed by Backend
-
-
Conform by the merge request performance guides -
Conform by the style guides -
Squashed related commits together -
End-to-end tests pass ( package-qamanual pipeline job)
What are the relevant issue numbers?
Closes #44271 (closed)
To do
Implement the following tasks: