Refactor wildcard dispatcher imports
1 unresolved thread
1 unresolved thread
What does this MR do?
Refactor wildcard dispatcher imports
Are there points in the code the reviewer needs to double check?
Why was this MR needed?
Screenshots (if relevant)
Does this MR meet the acceptance criteria?
-
Changelog entry added, if necessary -
Documentation created/updated -
API support added -
Tests added for this feature/bug - Review
-
Has been reviewed by UX -
Has been reviewed by Frontend -
Has been reviewed by Backend -
Has been reviewed by Database
-
-
Conform by the merge request performance guides -
Conform by the style guides -
Squashed related commits together -
Internationalization required/considered -
End-to-end tests pass ( package-qamanual pipeline job)
What are the relevant issue numbers?
Edited by Clement Ho
Merge request reports
Activity
added 73 commits
-
9e8b5498...296a4e68 - 71 commits from branch
master - 396a0661 - Merge branch 'master' into dispatcher-switch
- 78cb6706 - Remove imports for remaining dispatcher paths
-
9e8b5498...296a4e68 - 71 commits from branch
added 15 commits
-
78cb6706...6047a99e - 14 commits from branch
master - fcf0a41c - Merge branch 'master' into dispatcher-switch
-
78cb6706...6047a99e - 14 commits from branch
changed milestone to %10.6
59 issues: enableGFM, 60 milestones: enableGFM, 61 mergeRequests: enableGFM, 62 labels: enableGFM, 63 }); 64 }); 65 } 169 66 170 Dispatcher.prototype.initFieldErrors = function() { 171 $('.gl-show-field-errors').each((i, form) => { 172 new GlFieldErrors(form); 173 }); 174 }; 67 function initPerformanceBar() { 68 if (document.querySelector('#peek')) { 69 import('./performance_bar') @mikegreiling any ideas on how we would move this dynamic import out?
performance bar works on gitlab.com @mikegreiling
Yeah, that's what we are talking about @mikegreiling It's the peek thing
@jschatz1 can you review?
assigned to @jschatz1
mentioned in commit cce53020
mentioned in commit bf3995ad
Please register or sign in to reply