Skip to content

GitLab Next

  • Menu
Projects Groups Snippets
    • Loading...
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • GitLab FOSS GitLab FOSS
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
    • Locked Files
  • Issues 0
    • Issues 0
    • List
    • Boards
    • Service Desk
    • Milestones
    • Iterations
  • Merge requests 2
    • Merge requests 2
  • Requirements
    • Requirements
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Monitor
    • Monitor
    • Incidents
  • Packages & Registries
    • Packages & Registries
    • Container Registry
  • Analytics
    • Analytics
    • Code review
    • Insights
    • Issue
    • Repository
    • Value stream
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Commits
  • Issue Boards
Collapse sidebar
  • GitLab.org
  • GitLab FOSSGitLab FOSS
  • Merge requests
  • !17052

Merged
Created Feb 12, 2018 by Dylan Griffith@DylanGriffithMaintainer9 of 13 tasks completed9/13 tasks

Display ingress IP address in the Kubernetes page

  • Overview 183
  • Commits 27
  • Pipelines 33
  • Changes 27

What does this MR do?

Frontend:

  • Display ingress IP address in the Kubernetes page:
  1. Changes the description prop into a slot to allow to reuse the clipboard button
  2. Renders the ip address with a clipboard button when ingress is installed and the ip is available
  3. Renders a ? when ingress is installed and ip is not available
  4. Renders a different text when ingress is installed
  5. Adds tests

Are there points in the code the reviewer needs to double check?

Why was this MR needed?

Screenshots (if relevant)

Screen_Shot_2018-02-19_at_11.57.51 Screen_Shot_2018-02-19_at_12.07.23 Screen_Shot_2018-02-19_at_12.07.14

Does this MR meet the acceptance criteria?

  • Changelog entry added, if necessary
  • Documentation created/updated
  • API support added
  • Tests added for this feature/bug
  • Review
    • Has been reviewed by UX
    • Has been reviewed by Frontend
    • Has been reviewed by Backend
    • Has been reviewed by Database
  • Conform by the merge request performance guides
  • Conform by the style guides
  • Squashed related commits together
  • Internationalization required/considered
  • End-to-end tests pass (package-qa manual pipeline job)

What are the relevant issue numbers?

#42643 (closed)

Edited Mar 01, 2018 by Dylan Griffith
Assignee
Assign to
Reviewer
Request review from
Time tracking
Source branch: 42643-persist-external-ip-of-ingress-controller-gke

Enable Gitpod?

To use Gitpod you must first enable the feature in the integrations section of your user preferences.

Cancel Enable Gitpod