Skip to content

GitLab Next

    • GitLab: the DevOps platform
    • Explore GitLab
    • Install GitLab
    • How GitLab compares
    • Get started
    • GitLab docs
    • GitLab Learn
  • Pricing
  • Talk to an expert
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
    • Menu
    Projects Groups Snippets
  • Get a free trial
  • Sign up
  • Login
  • Sign in / Register
  • GitLab FOSS GitLab FOSS
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
    • Locked Files
  • Issues 0
    • Issues 0
    • List
    • Boards
    • Service Desk
    • Milestones
    • Iterations
    • Requirements
  • Merge requests 0
    • Merge requests 0
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages & Registries
    • Packages & Registries
    • Package Registry
    • Container Registry
    • Infrastructure Registry
  • Monitor
    • Monitor
    • Metrics
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • Code review
    • Insights
    • Issue
    • Repository
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Commits
  • Issue Boards
Collapse sidebar

GitLab 15.0 is launching on May 22! This version brings many exciting improvements, but also removes deprecated features and introduces breaking changes that may impact your workflow. To see what is being deprecated and removed, please visit Breaking changes in 15.0 and Deprecations.

  • GitLab.org
  • GitLab FOSSGitLab FOSS
  • Merge requests
  • !17052
Merged
Created Feb 12, 2018 by Dylan Griffith@DylanGriffithMaintainer9 of 13 tasks completed9/13 tasks
  • Review changes

  • Download
  • Email patches
  • Plain diff

Display ingress IP address in the Kubernetes page

  • Overview 183
  • Commits 27
  • Pipelines 33
  • Changes 27

What does this MR do?

Frontend:

  • Display ingress IP address in the Kubernetes page:
  1. Changes the description prop into a slot to allow to reuse the clipboard button
  2. Renders the ip address with a clipboard button when ingress is installed and the ip is available
  3. Renders a ? when ingress is installed and ip is not available
  4. Renders a different text when ingress is installed
  5. Adds tests

Are there points in the code the reviewer needs to double check?

Why was this MR needed?

Screenshots (if relevant)

Screen_Shot_2018-02-19_at_11.57.51 Screen_Shot_2018-02-19_at_12.07.23 Screen_Shot_2018-02-19_at_12.07.14

Does this MR meet the acceptance criteria?

  • Changelog entry added, if necessary
  • Documentation created/updated
  • API support added
  • Tests added for this feature/bug
  • Review
    • Has been reviewed by UX
    • Has been reviewed by Frontend
    • Has been reviewed by Backend
    • Has been reviewed by Database
  • Conform by the merge request performance guides
  • Conform by the style guides
  • Squashed related commits together
  • Internationalization required/considered
  • End-to-end tests pass (package-qa manual pipeline job)

What are the relevant issue numbers?

#42643 (closed)

Edited Mar 01, 2018 by Dylan Griffith
Assignee
Assign to
Reviewer
Request review from
Time tracking
Source branch: 42643-persist-external-ip-of-ingress-controller-gke